Skip to content

Commit 643db79

Browse files
committed
feat(combo): remove dummy parameter from pipe; change object reference #7282
1 parent 3e14f8b commit 643db79

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

projects/igniteui-angular/src/lib/combo/combo.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
[style.maxHeight.px]="itemsMaxHeight" [igxDropDownItemNavigation]="dropdown" (focus)="dropdown.onFocus()"
5252
[tabindex]="dropdown.collapsed ? -1 : 0" role="listbox" [attr.id]="dropdown.id">
5353
<igx-combo-item role="option" [itemHeight]='itemHeight' *igxFor="let item of data
54-
| comboFiltering:searchValue:displayKey:filterable:filteringOptions:filteringPipeTrigger
54+
| comboFiltering:searchValue:displayKey:filterable:filteringOptions
5555
| comboGrouping:groupKey:valueKey;
5656
index as rowIndex; containerSize: itemsMaxHeight; scrollOrientation: 'vertical'; itemSize: itemHeight"
5757
[value]="item" [isHeader]="item.isHeader" [index]="rowIndex">

projects/igniteui-angular/src/lib/combo/combo.component.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,6 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
165165
public filteringOptions: IComboFilteringOptions = {
166166
caseSensitive: false
167167
};
168-
/**
169-
* @hidden @internal
170-
*/
171-
public filteringPipeTrigger = 0;
172168
protected stringFilters = IgxStringFilteringOperand;
173169
protected booleanFilters = IgxBooleanFilteringOperand;
174170
protected _groupKey = '';
@@ -1587,8 +1583,7 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
15871583
* @hidden @internal
15881584
*/
15891585
public toggleCaseSensitive() {
1590-
this.filteringOptions.caseSensitive = !this.filteringOptions.caseSensitive;
1591-
this.filteringPipeTrigger++;
1586+
this.filteringOptions = { caseSensitive: !this.filteringOptions.caseSensitive };
15921587
}
15931588
}
15941589

projects/igniteui-angular/src/lib/combo/combo.pipes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { IComboFilteringOptions } from './combo.component';
1515
})
1616
export class IgxComboFilteringPipe implements PipeTransform {
1717
public transform(collection: any[], searchValue: any, displayKey: any,
18-
shouldFilter: boolean, filteringOptions: IComboFilteringOptions, _: any) {
18+
shouldFilter: boolean, filteringOptions: IComboFilteringOptions) {
1919
if (!collection) {
2020
return [];
2121
}

0 commit comments

Comments
 (0)