Skip to content

Commit 6653a81

Browse files
committed
refactor(grid): sorting indicator is now using the header text color when the column header is selected, this change make sure that it will be visible no mater the background color.
1 parent 7a163a4 commit 6653a81

File tree

2 files changed

+28
-10
lines changed

2 files changed

+28
-10
lines changed

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1661,8 +1661,23 @@
16611661
background: var-get($theme, 'header-selected-background');
16621662
opacity: if($variant != 'indigo-design', .7, 1);
16631663

1664-
.sort-icon::after {
1665-
background: var-get($theme, 'header-selected-background');
1664+
.sort-icon {
1665+
color: var-get($theme, 'header-selected-text-color');
1666+
1667+
::after {
1668+
background: var-get($theme, 'header-selected-background');
1669+
}
1670+
}
1671+
1672+
&%igx-grid-th--sorted {
1673+
.sort-icon {
1674+
color: var-get($theme, 'header-selected-text-color');
1675+
1676+
&:focus,
1677+
&:hover {
1678+
color: var-get($theme, 'header-selected-text-color');
1679+
}
1680+
}
16661681
}
16671682
}
16681683

@@ -1673,6 +1688,17 @@
16731688
.sort-icon::after {
16741689
background: var-get($theme, 'header-selected-background');
16751690
}
1691+
1692+
&%igx-grid-th--sorted {
1693+
.sort-icon {
1694+
color: var-get($theme, 'header-selected-text-color');
1695+
1696+
&:focus,
1697+
&:hover {
1698+
color: var-get($theme, 'header-selected-text-color');
1699+
}
1700+
}
1701+
}
16761702
}
16771703

16781704
%igx-grid-th--active {

projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_grid.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@
3636
/// @prop {Map} root-summaries-background [igx-color: ('grays', 200)] - The background color of the summary groups located the footer.
3737
/// @prop {Map} root-summaries-text-color [igx-contrast-color: ('grays', 200)] - The text color of the summary groups located the footer.
3838
$base-dark-grid: (
39-
sortable-header-icon-hover-color: (
40-
igx-color: ('secondary', 100)
41-
),
42-
43-
sorted-header-icon-color: (
44-
igx-contrast-color: ('secondary', 600)
45-
),
46-
4739
content-background: (
4840
igx-color: 'surface',
4941
),

0 commit comments

Comments
 (0)