Skip to content

Commit 66ce35a

Browse files
author
mmart1n
committed
fix(grid): revert resetSummaryHeight changes
- update dev sample
1 parent a82862b commit 66ce35a

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

projects/igniteui-angular/src/lib/grids/summaries/grid-summary.service.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,7 @@ export class IgxGridSummaryService {
130130
}
131131

132132
public resetSummaryHeight() {
133-
if (this.summaryHeight !== this.grid.summaryRowHeight) {
134-
this.summaryHeight = 0;
135-
}
133+
this.summaryHeight = 0;
136134
this.grid.summaryPipeTrigger++;
137135
if (this.grid.rootSummariesEnabled) {
138136
this.retriggerRootPipe++;

src/app/grid-summaries/grid-summaries.sample.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@
3535
${{val}}
3636
</ng-template>
3737
<ng-template igxCustomSummaryCell let-summaryResults>
38-
<div style="font-size: 0.75rem">
39-
<span>Custom summary cell:</span><br>
40-
<span>Number of Summaries: {{ summaryResults.length }}</span><br>
41-
<span>First Summary - {{ summaryResults[0].label }}: {{ summaryResults[0].summaryResult }}</span><br>
42-
<span>Second Summary - {{ summaryResults[1].label }}: {{ summaryResults[1].summaryResult }}</span><br>
43-
<span>Third Summary - {{ summaryResults[2].label }}: {{ summaryResults[2].summaryResult }}</span><br>
44-
<span> Fourth Summary - {{ summaryResults[3].label }}: {{ summaryResults[3].summaryResult }}</span><br>
38+
<div style="font-size: 0.75rem">
39+
<span>Custom summary cell:</span><br>
40+
<span>Number of Summaries: {{ summaryResults.length }}</span><br>
41+
<span>First Summary - {{ summaryResults[0].label }}: {{ summaryResults[0].summaryResult }}</span><br>
42+
<span>Second Summary - {{ summaryResults[1].label }}: {{ summaryResults[1].summaryResult }}</span><br>
43+
<span>Third Summary - {{ summaryResults[2].label }}: {{ summaryResults[2].summaryResult }}</span><br>
44+
<span> Fourth Summary - {{ summaryResults[3].label }}: {{ summaryResults[3].summaryResult }}</span><br>
4545
</div>
4646
</ng-template>
4747
</igx-column>
@@ -89,7 +89,7 @@
8989
<igx-switch [(ngModel)]="rowSelection">Row Selection</igx-switch>
9090

9191
<button (click)="enableSummary()"> Enable Summary for column ReorderLevel</button>
92-
<button (click)="disableSummary()">Disable Summary</button>
92+
<button (click)="toggleSummary()">Toggle Custom Summary</button>
9393
<button (click)="updateData()">Update Data</button>
9494
<button (click)="addRow()">Add Row</button>
9595
<button (click)="deleteRow()">Delete Row</button>

src/app/grid-summaries/grid-summaries.sample.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -803,8 +803,8 @@ export class GridSummaryComponent implements OnInit {
803803
}
804804
}
805805

806-
public disableSummary() {
807-
this.grid1.getColumnByName('UnitsInStock').hasSummary = false;
806+
public toggleSummary() {
807+
this.grid1.getColumnByName('UnitsInStock').hasSummary = !this.grid1.getColumnByName('UnitsInStock').hasSummary;
808808
// this.grid1.recalculateSummaries();
809809
}
810810

0 commit comments

Comments
 (0)