Skip to content

Commit 69623e7

Browse files
authored
Merge branch 'master' into nalipiev/combo-checkbox
2 parents 9de019a + 5466e65 commit 69623e7

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6726,7 +6726,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
67266726

67276727
// eslint-disable-next-line prefer-const
67286728
for (let [row, set] of selectionMap) {
6729-
row = this.paginator && source === this.filteredSortedData ? row + (this.paginator.perPage * this.paginator.page) : row;
6729+
row = this.paginator && (this.pagingMode === GridPagingMode.Local && source === this.filteredSortedData) ? row + (this.paginator.perPage * this.paginator.page) : row;
67306730
row = isRemote ? row - this.virtualizationState.startIndex : row;
67316731
if (!source[row] || source[row].detailsData !== undefined) {
67326732
continue;

src/app/grid-remote-paging/grid-remote-paging.sample.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<div class="dark-grid">
2-
<igx-grid igxPreventDocumentScroll #grid1 [data]="data | async" width="100%" height="540px">
2+
<igx-grid igxPreventDocumentScroll #grid1 [data]="data | async" width="100%" height="540px" [batchEditing]="true"
3+
[pagingMode]="mode">
34
<igx-column field="ID"></igx-column>
45
<igx-column field="ProductName"></igx-column>
56
<igx-column field="QuantityPerUnit"></igx-column>

src/app/grid-remote-paging/grid-remote-paging.sample.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { AfterViewInit, Component, OnDestroy, OnInit, ViewChild } from '@angular/core';
2-
import { IgxGridComponent } from 'igniteui-angular';
2+
import { GridPagingMode, IgxGridComponent } from 'igniteui-angular';
33
import { RemoteService } from '../shared/remote.service';
44
import { Observable } from 'rxjs';
55

@@ -10,6 +10,7 @@ import { Observable } from 'rxjs';
1010
export class GridRemotePagingSampleComponent implements OnInit, AfterViewInit, OnDestroy {
1111
@ViewChild('grid1', { static: true }) public grid1: IgxGridComponent;
1212

13+
public mode: GridPagingMode = GridPagingMode.Remote;
1314
public page = 0;
1415
public totalCount = 0;
1516
public pages = [];

src/app/grid-row-edit/grid-row-edit-sample.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,4 +222,4 @@ <h4>Performance grid with transactions and row edit</h4>
222222
<button igxButton (click)="toggle.close()">Cancel</button>
223223
</div>
224224
</div>
225-
</div>
225+
</div>

0 commit comments

Comments
 (0)