Skip to content

Commit 6b2fe5c

Browse files
authored
fix(date-picker): remove deprecation warning for the label property. #8917 (#8937)
1 parent 9aadae7 commit 6b2fe5c

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

projects/igniteui-angular/src/lib/date-picker/date-picker.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<igx-prefix>
99
<igx-icon>today</igx-icon>
1010
</igx-prefix>
11-
<label *ngIf="labelVisibility&&!_labelDirectiveUserTemplate" igxLabel>{{label}}</label>
11+
<label *ngIf="labelVisibility&&!_labelDirectiveUserTemplate" igxLabel>{{labelInternal}}</label>
1212
<input
1313
class="igx-date-picker__input-date"
1414
igxInput
@@ -27,7 +27,7 @@
2727
<igx-prefix (click)="onOpenClick($event)">
2828
<igx-icon>today</igx-icon>
2929
</igx-prefix>
30-
<label *ngIf="labelVisibility&&!_labelDirectiveUserTemplate" igxLabel>{{label}}</label>
30+
<label *ngIf="labelVisibility&&!_labelDirectiveUserTemplate" igxLabel>{{labelInternal}}</label>
3131
<input
3232
class="igx-date-picker__input-date"
3333
igxInput

projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,22 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
182182
<label igxLabel>Custom label</label>
183183
</igx-date-picker> `)
184184
@Input()
185-
public label = 'Date';
185+
public get label(): string {
186+
return this._label;
187+
}
188+
189+
public set label(v: string) {
190+
this._label = v;
191+
}
192+
193+
public get labelInternal() {
194+
return this._label;
195+
}
196+
197+
/** @hidden @internal */
198+
public get labelTemplate(): IgxLabelDirective {
199+
return this._labelDirectiveUserTemplate;
200+
}
186201

187202
/**
188203
* Gets/Sets the `IgxDatePickerComponent` label visibility.
@@ -459,7 +474,6 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
459474
displayData: this.displayData,
460475
format: this.format,
461476
isSpinLoop: this.isSpinLoop,
462-
label: this.label,
463477
labelVisibility: this.labelVisibility,
464478
locale: this.locale,
465479
mask: this.mask,
@@ -784,6 +798,7 @@ export class IgxDatePickerComponent implements IDatePicker, ControlValueAccessor
784798
private _onOpen = new EventEmitter<IgxDatePickerComponent>();
785799
private _onClose = new EventEmitter<IgxDatePickerComponent>();
786800
private _ngControl: NgControl = null;
801+
private _label = 'Date';
787802

788803
//#region ControlValueAccessor
789804

0 commit comments

Comments
 (0)