refactor(grid): reduce unwarranted deprecation warnings

Author: damyanpetev

projects/igniteui-angular/src/lib/grids/column-actions/column-actions.component.html

@@ -14,7 +14,7 @@ <h4 [attr.id]='titleID' class="igx-column-actions__header-title" *ngIf="title">{
 <div class="igx-column-actions__columns" tabindex="0"
     [style.max-height]="columnsAreaMaxHeight">
     <igx-checkbox
-        *ngFor="let column of columns
+        *ngFor="let column of grid?.columns
             | columnActionEnabled:actionsDirective.actionEnabledColumnsFilter:pipeTrigger
             | filterActionColumns:filterCriteria:pipeTrigger
             | sortActionColumns:columnDisplayOrder:pipeTrigger;"

projects/igniteui-angular/src/lib/grids/column-actions/column-actions.component.ts

@@ -366,7 +366,7 @@ export class IgxColumnActionsComponent implements DoCheck {
      */
     public ngDoCheck() {
         if (this._differ) {
-            const changes = this._differ.diff(this.columns);
+            const changes = this._differ.diff(this.grid?.columns);
             if (changes) {
                 this._pipeTrigger++;
             }

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -900,7 +900,18 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
      */
     @DeprecateProperty('`columnHidingTitle` is deprecated')
     @Input()
-    public columnHidingTitle: string;
+    public get columnHidingTitle(): string {
+        return this._columnHidingTitle;
+    }
+    public set columnHidingTitle(v: string) {
+        this._columnHidingTitle = v;
+    }
+    private _columnHidingTitle: string;
+
+    /** @hidden @internal */
+    public get columnHidingTitleInternal(): string {
+        return this._columnHidingTitle;
+    }
 
     /**
      * Gets/Sets the initial pinning configuration.
@@ -956,7 +967,18 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
      */
     @DeprecateProperty('`columnPinningTitle` is deprecated')
     @Input()
-    public columnPinningTitle: string;
+    public get columnPinningTitle(): string {
+        return this._columnPinningTitle;
+    }
+    public set columnPinningTitle(v: string) {
+        this._columnPinningTitle = v;
+    }
+    private _columnPinningTitle: string;
+
+    /** @hidden @internal */
+    public get columnPinningTitleInternal(): string {
+        return this._columnPinningTitle;
+    }
 
     /**
      * Gets/Sets if the filtering is enabled.
@@ -2198,7 +2220,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
      * <igx-grid [columnHiding]="true" [showToolbar]="true" [hiddenColumnsText]="'Hidden Columns'"></igx-grid>
      * ```
      */
-    @DeprecateProperty('`hiddenColumnsText` is deprecated')
+    // @DeprecateProperty('`hiddenColumnsText` is deprecated')
     @Input()
     get hiddenColumnsText() {
         return this._hiddenColumnsText;
@@ -2232,6 +2254,11 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
         this.notifyChanges();
     }
 
+    /** @hidden @internal */
+    get pinnedColumnsTextInternal() {
+        return this._pinnedColumnsText;
+    }
+
     /**
      * Get transactions service for the grid.
      */

projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-hiding.component.html

@@ -8,7 +8,7 @@
         </div>
     </button>
     <igx-column-actions #actions igxColumnHiding igxToggle (onOpened)="focusSearch(ref.element)" #ref="toggle"
-        [grid]="grid" [title]="grid.columnHidingTitle || title || grid?.resourceStrings.igx_grid_toolbar_hiding_title"
+        [grid]="grid" [title]="grid.columnHidingTitleInternal || title || grid?.resourceStrings.igx_grid_toolbar_hiding_title"
         [filterColumnsPrompt]="prompt || grid?.resourceStrings.igx_grid_toolbar_actions_filter_prompt">
     </igx-column-actions>
 </ng-container>

projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-pinning.component.html

@@ -4,11 +4,11 @@
         <div class="igx-grid-toolbar__button-space">
             <igx-icon fontSet="imx-icons" [name]="!grid.pinnedColumnsCount ? 'unpin-left' : 'pin-left'"></igx-icon>
             <span>{{ grid.pinnedColumnsCount }}</span>
-            <span>{{ grid.pinnedColumnsText }}</span>
+            <span>{{ grid.pinnedColumnsTextInternal }}</span>
         </div>
     </button>
     <igx-column-actions #actions igxColumnPinning igxToggle (onOpened)="focusSearch(ref.element)" #ref="toggle"
-        [grid]="grid" [title]="grid.columnPinningTitle || title || grid?.resourceStrings.igx_grid_toolbar_pinning_title"
+        [grid]="grid" [title]="grid.columnPinningTitleInternal || title || grid?.resourceStrings.igx_grid_toolbar_pinning_title"
         [filterColumnsPrompt]="prompt || grid?.resourceStrings.igx_grid_toolbar_actions_filter_prompt">
     </igx-column-actions>
 </ng-container>