Skip to content

Commit 6e01a2e

Browse files
authored
Merge branch '11.1.x' into dTsvetkov/fiix-8819-11.1.x
2 parents 171a172 + eb38428 commit 6e01a2e

File tree

2 files changed

+48
-5
lines changed

2 files changed

+48
-5
lines changed

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,9 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
669669
filterListItem.isFiltered = true;
670670
}
671671
filterListItem.value = element;
672-
filterListItem.label = element;
672+
filterListItem.label = element ?
673+
this.grid.resourceStrings.igx_grid_filter_true :
674+
this.grid.resourceStrings.igx_grid_filter_false;
673675
filterListItem.indeterminate = false;
674676
this.listData.push(filterListItem);
675677
} else {

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

Lines changed: 45 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3740,7 +3740,7 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
37403740
const listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix, searchComponent);
37413741
expect(listItems.length).toBe(3, 'incorrect rendered list items count');
37423742
expect(listItems[0].innerText).toBe('Select all search results');
3743-
expect(listItems[2].innerText).toBe('false');
3743+
expect(listItems[2].innerText).toBe('False');
37443744
}));
37453745

37463746
it('should scroll items in search list correctly', (async () => {
@@ -4071,7 +4071,7 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
40714071
tick(100);
40724072
fix.detectChanges();
40734073
verifyExcelStyleFilterAvailableOptions(fix,
4074-
['Select All', '(Blanks)', 'false', 'true'],
4074+
['Select All', '(Blanks)', 'False', 'True'],
40754075
[true, true, true, true]);
40764076

40774077
toggleExcelStyleFilteringItems(fix, true, 3);
@@ -4082,7 +4082,7 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
40824082
tick(100);
40834083
fix.detectChanges();
40844084
verifyExcelStyleFilterAvailableOptions(fix,
4085-
['Select All', '(Blanks)', 'false', 'true'],
4085+
['Select All', '(Blanks)', 'False', 'True'],
40864086
[null, true, true, false]);
40874087

40884088
GridFunctions.clickExcelFilterIcon(fix, 'Downloads');
@@ -4108,7 +4108,7 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
41084108
tick(100);
41094109
fix.detectChanges();
41104110
verifyExcelStyleFilterAvailableOptions(fix,
4111-
['Select All', '(Blanks)', 'false', 'true'],
4111+
['Select All', '(Blanks)', 'False', 'True'],
41124112
[null, true, true, false]);
41134113

41144114
GridFunctions.clickExcelFilterIcon(fix, 'ProductName');
@@ -5204,6 +5204,47 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
52045204
const cellValues = GridFunctions.getColumnCells(fix, 'ProductName').map(c => c.nativeElement.innerText).sort();
52055205
expect(cellValues).toEqual(['Web', 'Web']);
52065206
});
5207+
5208+
it('Should display the default True and False resource strings in the search list for boolean column.', fakeAsync(() => {
5209+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'Released');
5210+
flush();
5211+
fix.detectChanges();
5212+
5213+
const searchComponent = GridFunctions.getExcelStyleSearchComponent(fix);
5214+
const listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix, searchComponent);
5215+
5216+
expect(listItems.length).toBe(4, 'incorrect rendered list items count');
5217+
expect(listItems[2].innerText).toBe('False', 'incorrect list item label');
5218+
expect(listItems[3].innerText).toBe('True', 'incorrect list item label');
5219+
5220+
const checkboxes = GridFunctions.getExcelStyleFilteringCheckboxes(fix);
5221+
checkboxes[3].click();
5222+
tick();
5223+
fix.detectChanges();
5224+
5225+
GridFunctions.clickApplyExcelStyleFiltering(fix);
5226+
flush();
5227+
fix.detectChanges();
5228+
5229+
expect(grid.filteredData.length).toEqual(5);
5230+
}));
5231+
5232+
it('Should display the custom resource strings when specified in the search list for boolean column.', fakeAsync(() => {
5233+
grid.resourceStrings.igx_grid_filter_false = 'No';
5234+
grid.resourceStrings.igx_grid_filter_true = 'Yes';
5235+
fix.detectChanges();
5236+
5237+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'Released');
5238+
flush();
5239+
fix.detectChanges();
5240+
5241+
const searchComponent = GridFunctions.getExcelStyleSearchComponent(fix);
5242+
const listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix, searchComponent);
5243+
5244+
expect(listItems.length).toBe(4, 'incorrect rendered list items count');
5245+
expect(listItems[2].innerText).toBe('No', 'incorrect list item label');
5246+
expect(listItems[3].innerText).toBe('Yes', 'incorrect list item label');
5247+
}));
52075248
});
52085249

52095250
describe('Templates: ', () => {

0 commit comments

Comments
 (0)