fix(grid): allow values between -1 and 0

Author: MonikaKirkova

projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.ts

@@ -80,12 +80,13 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
 
     @Input()
     public get value(): any {
-        return this.expression ? this.expression.searchVal : null;
+        return this._value;
     }
 
     public set value(val) {
         if (!val && val !== 0 && (this.expression.searchVal || this.expression.searchVal === 0)) {
             this.expression.searchVal = null;
+            this._value = null;
             const index = this.expressionsList.findIndex(item => item.expression === this.expression);
             if (index === 0 && this.expressionsList.length === 1) {
                 this.filteringService.clearFilter(this.column.field);
@@ -105,6 +106,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
                 return;
             }
 
+            this._value = val;
             this.expression.searchVal = DataUtil.parseValue(this.column.dataType, val);
             if (this.expressionsList.find(item => item.expression === this.expression) === undefined) {
                 this.addExpression(true);
@@ -209,6 +211,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
     private isKeyPressed = false;
     private isComposing = false;
     private _cancelChipClick = false;
+    private _value = null;
 
     /** switch to icon buttons when width is below 432px */
     private readonly NARROW_WIDTH_THRESHOLD = 432;
@@ -238,6 +241,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
         const selectedItem = this.expressionsList.find(expr => expr.isSelected === true);
         if (selectedItem) {
             this.expression = selectedItem.expression;
+            this._value = this.expression.searchVal;
         }
 
         this.filteringService.grid.localeChange
@@ -358,9 +362,6 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
         // The 'iskeyPressed' flag is needed for a case in IE, because the input event is fired on focus and for some reason,
         // when you have a japanese character as a placeholder, on init the value here is empty string .
         const target = eventArgs.target;
-        if ((eventArgs.data === '-' || eventArgs.data === '+') && this.column.dataType === GridColumnDataType.Number) {
-            return;
-        }
         if (this.column.dataType === GridColumnDataType.DateTime) {
             this.value = eventArgs;
             return;
@@ -464,6 +465,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
             this.removeExpression(indexToDeselect, this.expression);
         }
         this.resetExpression();
+        this._value = this.expression.searchVal;
         this.scrollChipsWhenAddingExpression();
     }
 
@@ -637,7 +639,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
         item.isSelected = !item.isSelected;
         if (item.isSelected) {
             this.expression = item.expression;
-
+            this._value = this.expression.searchVal;
             this.focusEditElement();
         }
     }

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

@@ -919,14 +919,19 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
             // Set input and confirm
             GridFunctions.typeValueInFilterRowInput('-1', fix);
 
-            expect(input.componentInstance.value).toEqual(-1);
+            expect(input.componentInstance.value).toEqual('-1');
             expect(grid.rowList.length).toEqual(1);
 
             GridFunctions.typeValueInFilterRowInput('0', fix);
 
-            expect(input.componentInstance.value).toEqual(0);
+            expect(input.componentInstance.value).toEqual('0');
             expect(grid.rowList.length).toEqual(0);
 
+            GridFunctions.typeValueInFilterRowInput('-0.5', fix);
+
+            expect(input.componentInstance.value).toEqual('-0.5');
+            expect(grid.rowList.length).toEqual(1);
+
             GridFunctions.typeValueInFilterRowInput('', fix);
 
             expect(input.componentInstance.value).toEqual(null);

projects/igniteui-angular/src/lib/test-utils/sample-test-data.spec.ts

@@ -72,7 +72,7 @@ export class SampleTestData {
     public static numericData = () => ([
         { Number: -1 },
         { Number: 2.5 },
-        { Number: 35 }
+        { Number: -0.5 }
     ]);
 
     /* Fields: Name: string, Avatar: string; 3 items. */