Skip to content

Commit 76cbbe2

Browse files
committed
fix(tooltip): use default pos settings and expose tooltip pos strategy
1 parent 4dcc5b2 commit 76cbbe2

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

projects/igniteui-angular/src/lib/directives/tooltip/tooltip.common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class TooltipPositionStrategy extends AutoPositionStrategy implements ITo
3838
settings = Object.assign({}, positionSettings, settings);
3939
}
4040

41-
super(settings);
41+
super(settings || positionSettings);
4242
}
4343

4444
/**

projects/igniteui-angular/src/lib/services/overlay/position/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
// Export position strategies
33
export * from './IPositionStrategy';
4+
export * from './ITooltipPositionStrategy';
45
export * from './global-position-strategy';
56
export * from './container-position-strategy';
67
export * from './connected-positioning-strategy';

src/app/tooltip/tooltip.sample.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ <h5 style="margin-top: 0px;">Tooltip Placement</h5>
33
<igx-avatar src="assets/images/avatar/10.jpg" size="medium"
44
#target="tooltipTarget"
55
[igxTooltipTarget]="positionTooltip"
6+
[hasArrow]="true"
67
>
78
</igx-avatar>
89

910
<div #positionTooltip="tooltip" igxTooltip>
10-
Tooltip placement is {{ target.placement }}
11+
Tooltip placement is {{ target.positionSettings?.placement }}
1112
</div>
1213

13-
<igx-select [(ngModel)]="target.placement">
14+
<igx-select (selectionChanging)="setPlacement($event)" [value]="target.positionSettings?.placement">
1415
@for (placement of placementPositions; track placement) {
1516
<igx-select-item [value]="placement">
1617
{{placement}}
@@ -27,8 +28,6 @@ <h4 class="sample-title">Simple tooltip</h4>
2728
[closeButtonTemplate]="customClose"
2829
[overlaySettings]="settings"
2930
src="assets/images/avatar/10.jpg" size="medium"
30-
(onTooltipShow)="showing()"
31-
(onTooltipHide)="hiding()"
3231
aria-describedby="myid">
3332
</igx-avatar>
3433

src/app/tooltip/tooltip.sample.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ import {
1717
IgxSliderComponent,
1818
IgxSwitchComponent,
1919
IgxTooltipDirective,
20-
IgxTooltipTargetDirective, OverlaySettings
20+
IgxTooltipTargetDirective,
21+
ISelectionEventArgs,
22+
OverlaySettings,
23+
Placement,
2124
} from 'igniteui-angular';
2225

2326
@Component({
@@ -59,6 +62,10 @@ export class TooltipSampleComponent implements OnInit {
5962
}
6063

6164
public ngOnInit() {
65+
this.tooltipTarget.positionSettings = {
66+
placement: Placement.Bottom,
67+
};
68+
6269
this.data = [
6370
{
6471
Brand: 'Samsung',
@@ -127,9 +134,11 @@ export class TooltipSampleComponent implements OnInit {
127134
this.tooltipTarget.hideTooltip();
128135
}
129136

130-
public showing() {
131-
}
137+
public setPlacement(args: ISelectionEventArgs) {
138+
const placement: Placement = args.newSelection.value;
132139

133-
public hiding() {
140+
this.tooltipTarget.positionSettings = {
141+
placement: placement,
142+
};
134143
}
135144
}

0 commit comments

Comments
 (0)