Skip to content

Commit 7cffe44

Browse files
committed
chore(*): additional checks
1 parent 0056177 commit 7cffe44

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,7 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
926926
this._editedExpression.inEditMode = false;
927927
}
928928

929-
if (this.parentExpression && !this.parentExpression.inEditMode) {
929+
if (this.parentExpression) {
930930
this.inEditModeChange.emit(this.parentExpression);
931931
}
932932

@@ -952,12 +952,18 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
952952
this.returnFieldSelectOverlaySettings.target = this.selectedReturnFieldsCombo.getEditElement();
953953
this.returnFieldSelectOverlaySettings.excludeFromOutsideClick = [this.selectedReturnFieldsCombo.getEditElement() as HTMLElement];
954954
this.returnFieldSelectOverlaySettings.positionStrategy = new AutoPositionStrategy();
955-
this.fieldSelectOverlaySettings.target = this.fieldSelect.element;
956-
this.fieldSelectOverlaySettings.excludeFromOutsideClick = [this.fieldSelect.element as HTMLElement];
957-
this.fieldSelectOverlaySettings.positionStrategy = new AutoPositionStrategy();
958-
this.conditionSelectOverlaySettings.target = this.conditionSelect.element;
959-
this.conditionSelectOverlaySettings.excludeFromOutsideClick = [this.conditionSelect.element as HTMLElement];
960-
this.conditionSelectOverlaySettings.positionStrategy = new AutoPositionStrategy();
955+
956+
if (this.fieldSelect) {
957+
this.fieldSelectOverlaySettings.target = this.fieldSelect.element;
958+
this.fieldSelectOverlaySettings.excludeFromOutsideClick = [this.fieldSelect.element as HTMLElement];
959+
this.fieldSelectOverlaySettings.positionStrategy = new AutoPositionStrategy();
960+
}
961+
if (this.conditionSelect) {
962+
this.conditionSelectOverlaySettings.target = this.conditionSelect.element;
963+
this.conditionSelectOverlaySettings.excludeFromOutsideClick = [this.conditionSelect.element as HTMLElement];
964+
this.conditionSelectOverlaySettings.positionStrategy = new AutoPositionStrategy();
965+
}
966+
961967

962968
if (!this.selectedField) {
963969
this.fieldSelect.input.nativeElement.focus();

projects/igniteui-angular/src/lib/query-builder/query-builder.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class IgxQueryBuilderComponent implements OnDestroy {
167167
* Returns whether the expression tree can be committed in the current state.
168168
*/
169169
public canCommit(): boolean {
170-
return this.queryTree.canCommitCurrentState() === true;
170+
return this.queryTree?.canCommitCurrentState() === true;
171171
}
172172

173173
/**

0 commit comments

Comments
 (0)