Merge branch 'master' into puppeteer

Author: kdinev

CHANGELOG.md

@@ -7,6 +7,7 @@ All notable changes for each version of this project will be documented in this
 ### New Features
 - `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`:
     - `GroupMemberCountSortingStrategy` is added, which can be used to sort the grid by number of items in each group in ASC or DESC order, if grouping is applied.
+    - A new argument `primaryKey` has been introduced to `IRowDataEventArgs` Interface and part of the event arguments that are emitted by the `rowAdded` and `rowDeleted` events. When the grid has a primary key attribute added, then the emitted `primaryKey` event argument represents the row ID, otherwise it defaults to undefined.
 - `IgxColumnComponent`
     - Added `currRec` and `groupRec` parameters to the `groupingComparer` function that give access to the all properties of the compared records.
 

projects/igniteui-angular/src/lib/grids/tree-grid/tree-cell.component.html

@@ -78,6 +78,7 @@
                 [attr.aria-describedby]="ariaDescribeBy"
                 [attr.aria-invalid]="isInvalid"
                 [igxFocus]="true"
+                [igxTextSelection]="true"
                 [formControl]="formControl"
                 (compositionstart)="grid.crudService.isInCompositionMode = true"
                 (compositionend)="grid.crudService.isInCompositionMode = false"
@@ -93,6 +94,7 @@
                 [igxFocus]="true"
                 [step]="step"
                 type="number"
+                [igxTextSelection]="true"
                 [formControl]="formControl"
             />
         </igx-input-group>
@@ -153,6 +155,7 @@
                 [igxFocus]="true"
                 [step]="step"
                 type="number"
+                [igxTextSelection]="true"
                 [formControl]="formControl"
             />
             <igx-suffix *ngIf="!grid.currencyPositionLeft">{{ currencyCodeSymbol }}</igx-suffix>
@@ -167,6 +170,7 @@
                 [igxFocus]="true"
                 [step]="step"
                 type="number"
+                [igxTextSelection]="true"
                 [formControl]="formControl"
             />
             <igx-suffix> {{ editValue | percent:column.pipeArgs.digitsInfo:grid.locale }} </igx-suffix>

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-integration.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, ComponentFixture, waitForAsync } from '@angular/core/testing';
+import { TestBed, ComponentFixture, waitForAsync, fakeAsync, tick } from '@angular/core/testing';
 import { DebugElement } from '@angular/core';
 import { IgxTreeGridComponent } from './tree-grid.component';
 import { CellType, IgxTreeGridModule } from './public_api';
@@ -593,6 +593,30 @@ describe('IgxTreeGrid - Integration #tGrid', () => {
             const editedParentCell = parentRow.cells.filter(c => c.column.field === 'Age')[0];
             expect(editedParentCell.value).toEqual(80);
         });
+
+        it('should select the text when the first cell (tree grid cell) enters edit mode', fakeAsync(() => {
+            const grid = fix.componentInstance.treeGrid as IgxTreeGridComponent;
+            grid.expandAll();
+            fix.detectChanges();
+
+            // move the 'string' column 'Name' to first position, so its cells are the tree grid cells
+            const colName = grid.getColumnByName('Name');
+            const colHireDate = grid.getColumnByName('HireDate');
+            grid.moveColumn(colName, colHireDate, DropPosition.BeforeDropTarget);
+            fix.detectChanges();
+            tick(100);
+
+            const cell = grid.gridAPI.get_cell_by_index(0, 'Name');
+            cell.setEditMode(true);
+            fix.detectChanges();
+            tick(100);
+
+            expect(cell.editMode).toBe(true);
+            expect(document.activeElement.nodeName).toEqual('INPUT')
+            expect((document.activeElement as HTMLInputElement).value).toBe('John Winchester');
+            expect((document.activeElement as HTMLInputElement).selectionStart).toEqual(0);
+            expect((document.activeElement as HTMLInputElement).selectionEnd).toEqual(15);
+        }));
     });
 
     describe('Batch Editing', () => {