refactor(themes): use already ingested border-radius (#13483)

simeonoff · SisIvanova · web-flow · commit 82b740aa6cae · 2023-09-27T14:32:10.000+03:00
---------

Co-authored-by: Silvia Ivanova &lt;59446295+SisIvanova@users.noreply.github.com&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -67,7 +67,7 @@
     "@types/source-map": "0.5.2",
     "fflate": "^0.7.3",
     "hammerjs": "^2.0.8",
-    "igniteui-theming": "^3.0.6",
+    "igniteui-theming": "^3.1.0",
     "igniteui-trial-watermark": "^2.0.0",
     "lodash-es": "^4.17.21",
     "rxjs": "^6.6.7",
diff --git a/projects/igniteui-angular/package.json b/projects/igniteui-angular/package.json
@@ -76,7 +76,7 @@
         "igniteui-trial-watermark": "^1.0.3",
         "lodash-es": "^4.17.21",
         "uuid": "^9.0.0",
-        "igniteui-theming": "^3.0.6",
+        "igniteui-theming": "^3.1.0",
         "@igniteui/material-icons-extended": "^3.0.0"
     },
     "peerDependencies": {
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/action-strip/_action-strip-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/action-strip/_action-strip-theme.scss
@@ -48,7 +48,7 @@
     }
 
     @if not($actions-border-radius) {
-        $actions-border-radius: border-radius(map.get($theme, 'actions-border-radius')...);
+        $actions-border-radius: map.get($theme, 'actions-border-radius');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/button-group/_button-group-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/button-group/_button-group-theme.scss
@@ -132,10 +132,6 @@
         $shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/button/_button-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/button/_button-theme.scss
@@ -167,10 +167,6 @@
             $_active-shadow: elevation($active-elevation);
         }
 
-        @if not($_border-radius) {
-            $_border-radius: border-radius(map.get($_schema, 'border-radius')...);
-        }
-
         $themes: map.merge($themes, (
             $_name: extend( digest-schema($_schema), (
                 name: $name,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/calendar/_calendar-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/calendar/_calendar-theme.scss
@@ -323,18 +323,6 @@
         $week-number-color: text-contrast($week-number-background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($month-border-radius) {
-        $month-border-radius: border-radius(map.get($theme, 'month-border-radius')...);
-    }
-
-    @if not($date-border-radius) {
-        $date-border-radius: border-radius(map.get($theme, 'date-border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/card/_card-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/card/_card-theme.scss
@@ -88,10 +88,6 @@
         $hover-shadow: elevation($hover-elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         background: $background,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/carousel/_carousel-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/carousel/_carousel-theme.scss
@@ -89,10 +89,6 @@
         }
     }
 
-    @if not($border-radius){
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
 
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/checkbox/_checkbox-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/checkbox/_checkbox-theme.scss
@@ -67,14 +67,6 @@
     $theme: digest-schema($checkbox-schema);
     $meta: map.get($theme, '_meta');
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($border-radius-ripple) {
-        $border-radius-ripple: border-radius(map.get($theme, 'border-radius-ripple')...);
-    }
-
     @return extend($theme, (
         name: $name,
         label-color: $label-color,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/chip/_chip-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/chip/_chip-theme.scss
@@ -203,10 +203,6 @@
         $ghost-shadow: elevation($ghost-elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/dialog/_dialog-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/dialog/_dialog-theme.scss
@@ -65,10 +65,6 @@
         $shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss
@@ -152,14 +152,6 @@
         $shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($item-border-radius) {
-        $item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/expansion-panel/_expansion-panel-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/expansion-panel/_expansion-panel-theme.scss
@@ -71,10 +71,6 @@
         $body-color: text-contrast($body-background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         header-background: $header-background,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss
@@ -455,7 +455,7 @@
     }
 
     @if not($drop-area-border-radius) {
-        $drop-area-border-radius: border-radius(map.get($theme, 'drop-area-border-radius')...);
+        $drop-area-border-radius: map.get($theme, 'drop-area-border-radius');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss
@@ -206,15 +206,15 @@
     }
 
     @if not($box-border-radius) {
-        $box-border-radius: border-radius(map.get($theme, 'box-border-radius')...);
+        $box-border-radius: map.get($theme, 'box-border-radius');
     }
 
     @if not($border-border-radius) {
-        $border-border-radius: border-radius(map.get($theme, 'border-border-radius')...);
+        $border-border-radius: map.get($theme, 'border-border-radius');
     }
 
     @if not($search-border-radius) {
-        $search-border-radius: border-radius(map.get($theme, 'search-border-radius')...);
+        $search-border-radius: map.get($theme, 'search-border-radius');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/list/_list-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/list/_list-theme.scss
@@ -202,14 +202,6 @@
         $item-subtitle-color-active: $item-text-color-active;
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($item-border-radius) {
-        $item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         border-radius: $border-radius,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/navdrawer/_navdrawer-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/navdrawer/_navdrawer-theme.scss
@@ -113,14 +113,6 @@
         $shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($item-border-radius) {
-        $item-border-radius: border-radius(map.get($theme, 'item-border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         border-radius: $border-radius,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/progress/_progress-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/progress/_progress-theme.scss
@@ -55,7 +55,7 @@
     $meta: map.get($theme, '_meta');
 
     @if not($track-border-radius) {
-        $track-border-radius: border-radius(map.get($theme, 'track-border-radius')...);
+        $track-border-radius: map.get($theme, 'track-border-radius');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/snackbar/_snackbar-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/snackbar/_snackbar-theme.scss
@@ -59,10 +59,6 @@
         $shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         border-radius: $border-radius,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/splitter/_splitter-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/splitter/_splitter-theme.scss
@@ -53,10 +53,6 @@
         $expander-color: text-contrast($bar-color);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         bar-color: $bar-color,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/stepper/_stepper-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/stepper/_stepper-theme.scss
@@ -230,11 +230,11 @@
     }
 
     @if not($border-radius-indicator) {
-        $border-radius-indicator: border-radius(map.get($theme, 'border-radius-indicator')...);
+        $border-radius-indicator: map.get($theme, 'border-radius-indicator');
     }
 
     @if not($border-radius-step-header) {
-        $border-radius-step-header: border-radius(map.get($theme, 'border-radius-step-header')...);
+        $border-radius-step-header: map.get($theme, 'border-radius-step-header');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/switch/_switch-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/switch/_switch-theme.scss
@@ -117,15 +117,15 @@
     }
 
     @if not($border-radius-track) {
-        $border-radius-track: border-radius(map.get($theme, 'border-radius-track')...);
+        $border-radius-track: map.get($theme, 'border-radius-track');
     }
 
     @if not($border-radius-thumb) {
-        $border-radius-thumb: border-radius(map.get($theme, 'border-radius-thumb')...);
+        $border-radius-thumb: map.get($theme, 'border-radius-thumb');
     }
 
     @if not($border-radius-ripple) {
-        $border-radius-ripple: border-radius(map.get($theme, 'border-radius-ripple')...);
+        $border-radius-ripple: map.get($theme, 'border-radius-ripple');
     }
 
     @return extend($theme, (
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/tabs/_tabs-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/tabs/_tabs-theme.scss
@@ -164,10 +164,6 @@
         $tab-ripple-color: text-contrast($item-background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         item-text-color: $item-text-color,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/time-picker/_time-picker-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/time-picker/_time-picker-theme.scss
@@ -109,14 +109,6 @@
         $dropdown-shadow: elevation($elevation);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
-    @if not($active-item-border-radius) {
-        $active-item-border-radius: border-radius(map.get($theme, 'active-item-border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/toast/_toast-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/toast/_toast-theme.scss
@@ -55,10 +55,6 @@
         $text-color: text-contrast($background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         background: $background,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/tooltip/_tooltip-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/tooltip/_tooltip-theme.scss
@@ -46,10 +46,6 @@
         $text-color: text-contrast($background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: $selector,
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/watermark/_watermark-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/watermark/_watermark-theme.scss
@@ -48,10 +48,6 @@
         $color: text-contrast($link-background);
     }
 
-    @if not($border-radius) {
-        $border-radius: border-radius(map.get($theme, 'border-radius')...);
-    }
-
     @return extend($theme, (
         name: $name,
         selector: 'igc-trial-watermark',

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`@if not($actions-border-radius) {`
`51`		`- $actions-border-radius: border-radius(map.get($theme, 'actions-border-radius')...);`
	`51`	`+ $actions-border-radius: map.get($theme, 'actions-border-radius');`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`@return extend($theme, (`
Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,6 @@`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`
`92`		`- @if not($border-radius){`
`93`		`- $border-radius: border-radius(map.get($theme, 'border-radius')...);`
`94`		`- }`
`95`		`-`
`96`	`92`	`@return extend($theme, (`
`97`	`93`	`name: $name,`
`98`	`94`