Merge branch '16.1.x' into ikitanov/fix-#14044-16.1.x

Author: IvanKitanov17

projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts

@@ -90,7 +90,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
   @Input()
   public set minValue(value: string | Date) {
     this._minValue = value;
-    this.onValidatorChange();
+    this._onValidatorChange();
   }
 
   /**
@@ -111,7 +111,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
   @Input()
   public set maxValue(value: string | Date) {
     this._maxValue = value;
-    this.onValidatorChange();
+    this._onValidatorChange();
   }
 
   /**
@@ -166,14 +166,14 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
    * ```
    */
   @Input()
-  public set value(value: Date | string) {
+  public set value(value: Date | string | undefined | null) {
     this._value = value;
     this.setDateValue(value);
     this.onChangeCallback(value);
     this.updateMask();
   }
 
-  public get value(): Date | string {
+  public get value(): Date | string | undefined | null {
     return this._value;
   }
 
@@ -218,7 +218,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
   private document: Document;
   private _isFocused: boolean;
   private _defaultInputFormat: string;
-  private _value: Date | string;
+  private _value?: Date | string;
   private _minValue: Date | string;
   private _maxValue: Date | string;
   private _inputDateParts: DatePartInfo[];
@@ -230,9 +230,9 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
     minutes: 1,
     seconds: 1
   };
-  private onTouchCallback: (...args: any[]) => void = noop;
+
   private onChangeCallback: (...args: any[]) => void = noop;
-  private onValidatorChange: (...args: any[]) => void = noop;
+  private _onValidatorChange: (...args: any[]) => void = noop;
 
   private get datePartDeltas(): DatePartDeltas {
     return Object.assign({}, this._datePartDeltas, this.spinDelta);
@@ -392,7 +392,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
 
   /** @hidden @internal */
   public registerOnValidatorChange?(fn: () => void): void {
-    this.onValidatorChange = fn;
+    this._onValidatorChange = fn;
   }
 
   /** @hidden @internal */
@@ -402,7 +402,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
 
   /** @hidden @internal */
   public override registerOnTouched(fn: any): void {
-    this.onTouchCallback = fn;
+    this._onTouchedCallback = fn;
   }
 
   /** @hidden @internal */
@@ -472,7 +472,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
       return;
     }
     this._isFocused = true;
-    this.onTouchCallback();
+    this._onTouchedCallback();
     this.updateMask();
     super.onFocus();
     this.nativeElement.select();

projects/igniteui-angular/src/lib/directives/mask/mask.directive.ts

@@ -143,7 +143,7 @@ export class IgxMaskDirective implements OnInit, AfterViewChecked, ControlValueA
 
     private readonly defaultMask = 'CCCCCCCCCC';
 
-    private _onTouchedCallback: () => void = noop;
+    protected _onTouchedCallback: () => void = noop;
     private _onChangeCallback: (_: any) => void = noop;
 
     constructor(

projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.ts

@@ -48,7 +48,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy {
      * ```html
      * <div
      *   igxToggle
-     *   (onOpened)='onToggleOpened($event)'>
+     *   (opened)='onToggleOpened($event)'>
      * </div>
      * ```
      */
@@ -67,7 +67,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy {
      * ```html
      * <div
      *   igxToggle
-     *   (onOpening)='onToggleOpening($event)'>
+     *   (opening)='onToggleOpening($event)'>
      * </div>
      * ```
      */
@@ -86,7 +86,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy {
      * ```html
      * <div
      *   igxToggle
-     *   (onClosed)='onToggleClosed($event)'>
+     *   (closed)='onToggleClosed($event)'>
      * </div>
      * ```
      */
@@ -124,7 +124,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy {
      * ```html
      * <div
      *   igxToggle
-     *   (onAppended)='onToggleAppended()'>
+     *   (appended)='onToggleAppended()'>
      * </div>
      * ```
      */
@@ -376,7 +376,7 @@ export class IgxToggleDirective implements IToggleView, OnInit, OnDestroy {
 
                 //  in case event is not canceled this will close the toggle and we need to unsubscribe.
                 //  Otherwise if for some reason, e.g. close on outside click, close() gets called before
-                //  onClosed was fired we will end with calling onClosing more than once
+                //  closed was fired we will end with calling closing more than once
                 if (!e.cancel) {
                     this.clearSubscription(this._overlayClosingSub);
                 }