Skip to content

Commit 89a8494

Browse files
MKirovaMKirova
authored andcommitted
fix(igxGrid): When reposition rows ensure object used in overlay instance is updated since original object is copied when set in overlay and changes to original object are never reflected.
1 parent 614dfd0 commit 89a8494

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6458,7 +6458,6 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
64586458
this.configureRowEditingOverlay(id, this.rowList.length <= MIN_ROW_EDITING_COUNT_THRESHOLD);
64596459

64606460
this.rowEditingOverlay.open(this.rowEditSettings);
6461-
this.rowEditPositioningStrategy.isTopInitialPosition = this.rowEditPositioningStrategy.isTop;
64626461
this.rowEditingOverlay.element.addEventListener('wheel', this.rowEditingWheelHandler);
64636462
}
64646463

@@ -6501,14 +6500,19 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
65016500
}
65026501

65036502
private configureRowEditingOverlay(rowID: any, useOuter = false) {
6504-
this.rowEditSettings.outlet = useOuter ? this.parentRowOutletDirective : this.rowOutletDirective;
6503+
let settings = this.rowEditSettings;
6504+
const overlay = this.overlayService.getOverlayById(this.rowEditingOverlay.overlayId);
6505+
if (overlay) {
6506+
settings = overlay.settings;
6507+
}
6508+
settings.outlet = useOuter ? this.parentRowOutletDirective : this.rowOutletDirective;
65056509
this.rowEditPositioningStrategy.settings.container = this.tbody.nativeElement;
65066510
const pinned = this._pinnedRecordIDs.indexOf(rowID) !== -1;
65076511
const targetRow = !pinned ? this.gridAPI.get_row_by_key(rowID) : this.pinnedRows.find(x => x.rowID === rowID);
65086512
if (!targetRow) {
65096513
return;
65106514
}
6511-
this.rowEditSettings.target = targetRow.element.nativeElement;
6515+
settings.target = targetRow.element.nativeElement;
65126516
this.toggleRowEditingOverlay(true);
65136517
}
65146518

0 commit comments

Comments
 (0)