Merge branch '17.2.x' into ganastasov/fix-14314-17.2.x

Author: georgianastasov

projects/igniteui-angular/src/lib/directives/drag-drop/drag-drop.directive.ts

@@ -1463,6 +1463,10 @@ export class IgxDragDirective implements AfterContentInit, OnDestroy {
 
     /** Method setting transformation to the base draggable element. */
     protected setTransformXY(x: number, y: number) {
+        if(x === 0 && y === 0) {
+            this.element.nativeElement.style.transform = '';
+            return;
+        }
         this.element.nativeElement.style.transform = 'translate3d(' + x + 'px, ' + y + 'px, 0px)';
     }
 

projects/igniteui-angular/src/lib/grids/selection/selection.service.ts

@@ -400,8 +400,10 @@ export class IgxGridSelectionService {
             return Array.from(this.rowSelection);
         }
         const selection = [];
+        const gridDataMap = {};
+        this.grid.gridAPI.get_all_data(true).forEach(row => gridDataMap[this.getRecordKey(row)] = row);
         this.rowSelection.forEach(rID => {
-            const rData = this.grid.gridAPI.get_all_data(true).find(row => this.getRecordKey(row) === rID);
+            const rData = gridDataMap[rID];
             const partialRowData = {};
             partialRowData[this.grid.primaryKey] = rID;
             selection.push(rData ? rData : partialRowData);
@@ -607,9 +609,9 @@ export class IgxGridSelectionService {
         if (this.allRowsSelected !== undefined && !newSelection) {
             return this.allRowsSelected;
         }
-        const selectedData = newSelection ? newSelection : [...this.rowSelection]
+        const selectedData = new Set(newSelection ? newSelection : [...this.rowSelection]);
         const allData = this.getRowIDs(this.allData);
-        const unSelectedRows = allData.filter(row => !selectedData.includes(row));
+        const unSelectedRows = allData.filter(row => !selectedData.has(row));
         return this.allRowsSelected = this.allData.length > 0 && unSelectedRows.length === 0;
     }
 

projects/igniteui-angular/src/lib/splitter/splitter.component.spec.ts

@@ -304,6 +304,25 @@ describe('IgxSplitter', () => {
         expect(pane2.element.offsetWidth).toBeCloseTo(pane2_originalSize - 100);
     });
 
+    it('should reset transform style of vertical splitter bar after dragging', async () => {
+        const pane1 =  splitter.panes.toArray()[0];
+        pane1.size = '200px';
+        fixture.detectChanges();
+
+        fixture.componentInstance.type = SplitterType.Vertical;
+        fixture.detectChanges();
+        const splitterBarComponent = fixture.debugElement.query(By.css(SPLITTERBAR_CLASS)).nativeElement;
+
+        const splitterBar = fixture.debugElement.query(By.css(SPLITTERBAR_CLASS)).context;
+        splitterBar.moveStart.emit(pane1);
+        splitterBar.moving.emit(-150);
+        fixture.detectChanges();
+
+        splitterBar.movingEnd.emit(50);
+        fixture.detectChanges();
+
+        expect(splitterBarComponent.style.transform).not.toBe('translate3d(0px, 0px, 0px)');
+    });
 });
 
 describe('IgxSplitter pane toggle', () => {

src/app/grid-performance/grid-performance.sample.html

@@ -1,6 +1,6 @@
 <div style="height: 100vh; width: 100wh">
     <h4 class="sample-title"> Fixed Size Rows</h4>
-    <igx-grid #grid1 [rowHeight]="20" displayDensity="compact" [data]="localData" [rowSelection]="selectionMode" [allowFiltering]="true" [filterMode]="'excelStyleFilter'">
+    <igx-grid #grid1 [rowHeight]="20" primaryKey="ID" displayDensity="compact" [data]="localData" [rowSelection]="selectionMode" [allowFiltering]="true" [filterMode]="'excelStyleFilter'">
         <igx-grid-toolbar [displayDensity]="grid1.displayDensity">
             <igx-grid-toolbar-actions>
                 <igx-grid-toolbar-pinning></igx-grid-toolbar-pinning>

src/app/grid-performance/grid-performance.sample.ts

@@ -20,7 +20,7 @@ export class GridPerformanceSampleComponent implements OnInit {
     public selectionMode;
 
     public ngOnInit() {
-        this.selectionMode = GridSelectionMode.none;
+        this.selectionMode = GridSelectionMode.multiple;
         const cols = [];
         cols.push({
             field: 'ID',

src/app/overlay/overlay.sample.ts

@@ -21,7 +21,8 @@ import {
     IgxLabelDirective,
     IgxButtonDirective,
     IgxRippleDirective,
-    IgxDropDownItemComponent
+    IgxDropDownItemComponent,
+    IChangeCheckboxEventArgs
 } from 'igniteui-angular';
 import { IAnimationParams } from 'igniteui-angular/animations';
 
@@ -81,8 +82,8 @@ export class OverlaySampleComponent implements OnInit {
         }
     }
 
-    public onChange(ev) {
-        switch (ev.radio.name) {
+    public onChange(ev: IChangeCheckboxEventArgs) {
+        switch (ev.owner.name) {
             case 'ps':
                 this.removeSelectedClass('direction');
                 this.removeSelectedClass('start-point');
@@ -240,8 +241,8 @@ export class OverlaySampleComponent implements OnInit {
         this._overlaySettings.outlet = this.useOutlet ? this.outletElement : null;
     }
 
-    public onSwitchChange(ev) {
-        switch (ev.switch.name) {
+    public onSwitchChange(ev: IChangeCheckboxEventArgs) {
+        switch (ev.owner.name) {
             case 'close':
                 this._overlaySettings.closeOnOutsideClick = ev.checked;
                 break;