fix(simple-combo): selectionChanging on input clear and properly event cancel

Author: georgianastasov

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts

@@ -1553,9 +1553,6 @@ describe('IgxSimpleCombo', () => {
             combo.handleInputChange('z');
             fixture.detectChanges();
 
-            combo.onBlur();
-            fixture.detectChanges();
-
             expect(combo.selectionChanging.emit).toHaveBeenCalledTimes(2);
             expect(combo.selectionChanging.emit).toHaveBeenCalledWith({
                 oldValue: "Connecticut",
@@ -1570,6 +1567,41 @@ describe('IgxSimpleCombo', () => {
                 cancel: false
             });
         });
+
+        it('should not change selection when selectionChanging event is canceled', () => {
+            spyOn(combo.selectionChanging, 'emit').and.callThrough();
+            fixture.detectChanges();
+
+            combo.select('Connecticut');
+            fixture.detectChanges();
+
+            expect(combo.selection).toEqual({
+                field: 'Connecticut',
+                region: 'New England'
+            });
+
+            const cancelEventSpy = spyOn(combo.selectionChanging, 'emit').and.callFake((args: ISimpleComboSelectionChangingEventArgs) => {
+                args.cancel = true;
+            });
+
+            combo.handleInputChange('z');
+            fixture.detectChanges();
+
+            expect(cancelEventSpy).toHaveBeenCalled();
+            expect(combo.selection).toEqual({
+                field: 'Connecticut',
+                region: 'New England'
+            });
+
+            combo.handleInputChange(' ');
+            fixture.detectChanges();
+
+            expect(cancelEventSpy).toHaveBeenCalled();
+            expect(combo.selection).toEqual({
+                field: 'Connecticut',
+                region: 'New England'
+            });
+        });
     });
 
     describe('Display density', () => {

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts

@@ -115,8 +115,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
 
     private _collapsing = false;
 
-    private _previousSelection = { selectedItem: '', selection: [] };
-
     /** @hidden @internal */
     public get filteredData(): any[] | null {
         return this._filteredData;
@@ -281,9 +279,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
 
     /** @hidden @internal */
     public override handleInputChange(event?: any): void {
-        if (this.hasSelectedItem) {
-            this._previousSelection = { selectedItem: this.selectedItem, selection: this.selection };
-        }
         if (event !== undefined) {
             this.filterValue = this.searchValue = typeof event === 'string' ? event : event.target.value;
         }
@@ -297,7 +292,7 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
             this.filterValue = '';
         }
         if (super.selection.length) {
-            this.selectionService.clear(this.id);
+            this.clearSelection();
         }
         // when filtering the focused item should be the first item or the currently selected item
         if (!this.dropdown.focusedItem || this.dropdown.focusedItem.id !== this.dropdown.items[0].id) {
@@ -471,10 +466,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
         };
         if (args.newSelection !== args.oldSelection) {
             this.selectionChanging.emit(args);
-        } else if (this._updateInput && newSelection.size === 0 && this._previousSelection.selectedItem !== '') {
-            args.oldValue = this._previousSelection.selectedItem;
-            args.oldSelection = this._previousSelection.selection;
-            this.selectionChanging.emit(args);
         }
         // TODO: refactor below code as it sets the selection and the display text
         if (!args.cancel) {
@@ -493,13 +484,7 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
             this._updateInput = true;
         } else if (this.isRemote) {
             this.registerRemoteEntries(newValueAsArray, false);
-        } else if (args.cancel) {
-            if (this._updateInput && this._previousSelection.selectedItem !== '') {
-                this.selectionService.select_items(this.id, [this._previousSelection.selectedItem], true);
-                this._value = [this._previousSelection.selectedItem];
-            }
         }
-        this._previousSelection = { selectedItem: '', selection: [] };
     }
 
     protected createDisplayText(newSelection: any[], oldSelection: any[]): string {