Skip to content

Commit 8f807a3

Browse files
authored
fix(i18n): Change advanced filtering Cancel and Apply buttons to start with capital letter (#15167)
1 parent ac3985a commit 8f807a3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

projects/igniteui-angular/src/lib/core/i18n/grid-resources.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,8 @@ export const GridResourceStringsEN: IGridResourceStrings = {
235235
igx_grid_excel_custom_dialog_add: 'add filter',
236236
igx_grid_excel_custom_dialog_clear: 'Clear filter',
237237
igx_grid_excel_custom_dialog_header: 'Custom auto-filter on column: ',
238-
igx_grid_excel_cancel: 'cancel',
239-
igx_grid_excel_apply: 'apply',
238+
igx_grid_excel_cancel: 'Cancel',
239+
igx_grid_excel_apply: 'Apply',
240240
igx_grid_excel_search_placeholder: 'Search',
241241
igx_grid_excel_select_all: 'Select All',
242242
igx_grid_excel_select_all_search_results: 'Select all search results',

projects/igniteui-angular/src/lib/test-utils/grid-functions.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ export class GridFunctions {
738738
public static getApplyButtonExcelStyleFiltering(fix: ComponentFixture<any>, menu = null, grid = 'igx-grid') {
739739
const excelMenu = menu ? menu : GridFunctions.getExcelStyleFilteringComponent(fix, grid);
740740
const containedButtons = Array.from(excelMenu.querySelectorAll('.igx-button--contained'));
741-
const applyButton: any = containedButtons.find((rb: any) => rb.innerText === 'apply');
741+
const applyButton: any = containedButtons.find((rb: any) => rb.innerText.toLowerCase() === 'apply');
742742
return applyButton;
743743
}
744744

@@ -750,7 +750,7 @@ export class GridFunctions {
750750
public static clickCancelExcelStyleFiltering(fix: ComponentFixture<any>, menu = null) {
751751
const excelMenu = menu ? menu : GridFunctions.getExcelStyleFilteringComponent(fix);
752752
const flatButtons = Array.from(excelMenu.querySelectorAll('.igx-button--flat'));
753-
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText === 'cancel');
753+
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText.toLowerCase() === 'cancel');
754754
cancelButton.click();
755755
}
756756

@@ -771,7 +771,7 @@ export class GridFunctions {
771771
public static getApplyExcelStyleCustomFiltering(fix: ComponentFixture<any>): HTMLElement {
772772
const customFilterMenu = GridFunctions.getExcelStyleCustomFilteringDialog(fix);
773773
const containedButtons = Array.from(customFilterMenu.querySelectorAll('.igx-button--contained'));
774-
const applyButton = containedButtons.find((rb: any) => rb.innerText === 'apply');
774+
const applyButton = containedButtons.find((rb: any) => rb.innerText.toLowerCase() === 'apply');
775775
return applyButton as HTMLElement;
776776
}
777777

@@ -804,7 +804,7 @@ export class GridFunctions {
804804
public static clickCancelExcelStyleCustomFiltering(fix: ComponentFixture<any>) {
805805
const customFilterMenu = GridFunctions.getExcelStyleCustomFilteringDialog(fix);
806806
const flatButtons = Array.from(customFilterMenu.querySelectorAll('.igx-button--flat'));
807-
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText === 'cancel');
807+
const cancelButton: any = flatButtons.find((rb: any) => rb.innerText.toLowerCase() === 'cancel');
808808
cancelButton.click();
809809
}
810810

0 commit comments

Comments
 (0)