Skip to content

Commit 9028e1b

Browse files
committed
test(*): final fixes for new option
1 parent 76be349 commit 9028e1b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

projects/igniteui-angular/src/lib/directives/input/input.directive.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -722,6 +722,9 @@ describe('IgxInput', () => {
722722

723723
// 3) Check if the input group's --invalid and --required classes are removed when validator is dynamically cleared
724724
fix.componentInstance.removeValidators(formGroup);
725+
// the component cannot both take required on the input and validators. If validators write required, their removal
726+
// cannot cause required to be removed as it may have been part of the initial setup
727+
input.nativeElement.removeAttribute('required');
725728
fix.detectChanges();
726729
tick();
727730

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2276,7 +2276,6 @@ describe('IgxSimpleCombo', () => {
22762276

22772277
expect(combo.valid).toEqual(IgxInputState.INITIAL);
22782278
expect(combo.comboInput.valid).toEqual(IgxInputState.INITIAL);
2279-
expect(combo.comboInput.nativeElement.attributes['required']).toBeDefined();
22802279

22812280
// empty string
22822281
combo.open();

0 commit comments

Comments
 (0)