Skip to content

Commit 9157515

Browse files
authored
Merge branch 'master' into vmihalkov/bug-6321
2 parents efc0cdb + 977a0d6 commit 9157515

File tree

2 files changed

+21
-18
lines changed

2 files changed

+21
-18
lines changed

ROADMAP.md

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,30 @@
44

55
## Milestone 12 (Due by August 17th, 2020)
66

7-
1. igx-grid improve IGridEditEventArgs [#4965](https://github.com/IgniteUI/igniteui-angular/issues/4965)
8-
2. igxCombo has to include caseSensitive property in filter search [#7282](https://github.com/IgniteUI/igniteui-angular/issues/7282)
9-
3. igxCombo default positioning strategy [#7225](https://github.com/IgniteUI/igniteui-angular/issues/7225)
10-
4. igxSelect Add igxHint support [#5584](https://github.com/IgniteUI/igniteui-angular/issues/5584)
11-
5. igxGrid Hide the group area row [#5561](https://github.com/IgniteUI/igniteui-angular/issues/5561)
12-
6. igxDateRangePickerComponent calendar should display selected range if both start and end are filled and valid [#7593](https://github.com/IgniteUI/igniteui-angular/issues/7593)
13-
7. Add support for mixing px and % column widths [#5486](https://github.com/IgniteUI/igniteui-angular/issues/5486)
14-
8. Do not close modal overlay on ESC key press [#7697](https://github.com/IgniteUI/igniteui-angular/issues/7697)
15-
9. Themes: Add Dock Manager Support [#7541](https://github.com/IgniteUI/igniteui-angular/issues/7541)
16-
10. igx-grid - pre-select rows [#6653](https://github.com/IgniteUI/igniteui-angular/issues/6653)
17-
11. Average and Sum are shown on the Ship country level [#7334](https://github.com/IgniteUI/igniteui-angular/issues/7334)
18-
12. Dock Manager Better Default Themes [#7578](https://github.com/IgniteUI/igniteui-angular/issues/7578)
7+
1. **[DONE]** igx-grid improve IGridEditEventArgs [#4965](https://github.com/IgniteUI/igniteui-angular/issues/4965)
8+
2. **[DONE]** igxCombo has to include caseSensitive property in filter search [#7282](https://github.com/IgniteUI/igniteui-angular/issues/7282)
9+
3. **[DONE]** igxCombo default positioning strategy [#7225](https://github.com/IgniteUI/igniteui-angular/issues/7225)
10+
4. **[DONE]** igxSelect Add igxHint support [#5584](https://github.com/IgniteUI/igniteui-angular/issues/5584)
11+
5. **[DONE]** igxGrid Hide the group area row [#5561](https://github.com/IgniteUI/igniteui-angular/issues/5561)
12+
6. **[DONE]** igxDateRangePickerComponent calendar should display selected range if both start and end are filled and valid [#7593](https://github.com/IgniteUI/igniteui-angular/issues/7593)
13+
7. **[DONE]** Add support for mixing px and % column widths [#5486](https://github.com/IgniteUI/igniteui-angular/issues/5486)
14+
8. **[DONE]** Do not close modal overlay on ESC key press [#7697](https://github.com/IgniteUI/igniteui-angular/issues/7697)
15+
9. **[DONE]** Themes: Add Dock Manager Support [#7541](https://github.com/IgniteUI/igniteui-angular/issues/7541)
16+
10. **[DONE]** igx-grid - pre-select rows [#6653](https://github.com/IgniteUI/igniteui-angular/issues/6653)
17+
11. **[DONE]** Average and Sum are shown on the Ship country level [#7334](https://github.com/IgniteUI/igniteui-angular/issues/7334)
18+
12. **[DONE]** Dock Manager Better Default Themes [#7578](https://github.com/IgniteUI/igniteui-angular/issues/7578)
1919
13. Expose templates for all ESF UI parts [#7221](https://github.com/IgniteUI/igniteui-angular/issues/7221)
20-
14. Calendar events when user changes month/year [#7039](https://github.com/IgniteUI/igniteui-angular/issues/7039)
20+
14. **[DONE]** Calendar events when user changes month/year [#7039](https://github.com/IgniteUI/igniteui-angular/issues/7039)
2121
15. igxGrid default column display templates per-type [#7224](https://github.com/IgniteUI/igniteui-angular/issues/7224)
2222
16. Provide "Unfreeze All" option under Freeze button on Data Grid & Tree Grid
2323
To Be Updated [#6549](https://github.com/IgniteUI/igniteui-angular/issues/6549)
2424
17. Exposing onActiveNodeChange output in the Grid [#7601](https://github.com/IgniteUI/igniteui-angular/issues/7601)
25-
18. Refactor commit method of IgxHierarchicalTransactionService to accept same parameters as base type [#5205](https://github.com/IgniteUI/igniteui-angular/issues/5205)
26-
19. Tooltip for grid cell text content [#6215](https://github.com/IgniteUI/igniteui-angular/issues/6215)
27-
20. Add tooltip to column summary [#6505](https://github.com/IgniteUI/igniteui-angular/issues/6505)
25+
18. **[DONE]** Refactor commit method of IgxHierarchicalTransactionService to accept same parameters as base type [#5205](https://github.com/IgniteUI/igniteui-angular/issues/5205)
26+
19. **[DONE]** Tooltip for grid cell text content [#6215](https://github.com/IgniteUI/igniteui-angular/issues/6215)
27+
20. **[DONE]** Add tooltip to column summary [#6505](https://github.com/IgniteUI/igniteui-angular/issues/6505)
28+
21. **[DONE]** IgxToast `show` should take a message param [#7156](https://github.com/IgniteUI/igniteui-angular/issues/7156)
29+
22. **[DONE]** IgxGridState working with IgxHierarchicalGrid [#7025](https://github.com/IgniteUI/igniteui-angular/issues/7025)
30+
23. **[DONE]** Sorting Indicator on all Grid components [#7493](https://github.com/IgniteUI/igniteui-angular/issues/7493)
2831

2932

3033
## Going down the road

projects/igniteui-angular/src/lib/services/overlay/position/auto-position-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export class AutoPositionStrategy extends BaseFitPositionStrategy {
119119
*/
120120
private horizontalPush(connectedFit: ConnectedFit): number {
121121
const leftExtend = connectedFit.left;
122-
const rightExtend = connectedFit.right - connectedFit.viewPortRect.right;
122+
const rightExtend = connectedFit.right - connectedFit.viewPortRect.width;
123123
// if leftExtend < 0 overlay goes beyond left end of the screen. We should push it back with exactly
124124
// as much as it is beyond the screen.
125125
// if rightExtend > 0 overlay goes beyond right end of the screen. We should push it back with the
@@ -141,7 +141,7 @@ export class AutoPositionStrategy extends BaseFitPositionStrategy {
141141
*/
142142
private verticalPush(connectedFit: ConnectedFit): number {
143143
const topExtend = connectedFit.top;
144-
const bottomExtend = connectedFit.bottom - connectedFit.viewPortRect.bottom;
144+
const bottomExtend = connectedFit.bottom - connectedFit.viewPortRect.height;
145145
if (topExtend < 0) {
146146
return Math.abs(topExtend);
147147
} else if (bottomExtend > 0) {

0 commit comments

Comments
 (0)