Skip to content

Commit 93bde60

Browse files
committed
refactor(charts): remove width and height
1 parent ac18963 commit 93bde60

File tree

12 files changed

+6
-76
lines changed

12 files changed

+6
-76
lines changed

projects/igniteui-angular/src/lib/core/styles/components/charts/_category-chart-theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
/// @param {Color} $title-text-color [null] - Sets the color of the chart title.
1919
/// @param {String} $title-text-style [null] - Sets the CSS font property of the chart title.
2020
/// @param {List} $subtitle-margin [null] - Sets the margins (top, right, bottom, left) of the chart subtitle.
21+
/// @param {String} $subtitle-alignment [null] - The horizontal alignment to use for the subtitle.
2122
/// @param {Color} $subtitle-text-color [null] - Sets the color of the chart subtitle.
2223
/// @param {String} $subtitle-text-style [null] - Sets the CSS font property of the chart subtitle.
2324
/// @param {Number} $thickness [null] - Sets the thickness for all series in a chart.
@@ -207,6 +208,7 @@
207208
title-alignment: $title-alignment,
208209
title-text-color: $title-text-color,
209210
title-text-style: $title-text-style,
211+
subtitle-alignment: $subtitle-alignment,
210212
subtitle-text-color: $subtitle-text-color,
211213
subtitle-text-style: $subtitle-text-style,
212214
thickness: $thickness,

projects/igniteui-angular/src/lib/core/styles/components/charts/_data-chart-theme.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/// @param {Map} $palette [$default-palette] - The palette used as basis for styling the component.
88
/// @param {Map} $schema [$light-schema] - The schema used as basis for styling the component.
9-
/// @param {Map} $width [null] - The width of the chart.
10-
/// @param {Map} $height [null] - The height of the chart.
119
/// @param {List} $margin [null] - Sets the margin (top, right, bottom, left) of the chart content.
1210
/// @param {Color} $title-text-color [null] - Sets the color of the chart title.
1311
/// @param {List} $title-margin [null] - Sets the margin (top, right, bottom, left) of the chart title.
@@ -32,8 +30,6 @@
3230
$palette: $default-palette,
3331
$schema: $light-schema,
3432
35-
$width: null,
36-
$height: null,
3733
$margin: null,
3834
$title-text-color: null,
3935
$title-margin: null,
@@ -85,8 +81,6 @@
8581
$subtitle-margin,
8682
(
8783
name: $name,
88-
width: $width,
89-
height: $height,
9084
title-text-color: $title-text-color,
9185
subtitle-text-color: null,
9286
brushes: $brushes,

projects/igniteui-angular/src/lib/core/styles/components/charts/_financial-chart-theme.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/// @param {Map} $palette [$default-palette] - The palette used as basis for styling the component.
88
/// @param {Map} $schema [$light-schema] - The schema used as basis for styling the component.
9-
/// @param {Number} $width [null] - The width of the chart.
10-
/// @param {Number} $height [null] - The height of the chart.
119
/// @param {List} $margin [null] - Sets the margin (top, right, bottom, left) of the chart content.
1210
/// @param {String} $title-alignment [null] - The horizontal alignment to use for the title.
1311
/// @param {Color} $title-text-color [null] - Sets the color of the chart title.
@@ -79,8 +77,6 @@
7977
$palette: $default-palette,
8078
$schema: $light-schema,
8179
82-
$width: null,
83-
$height: null,
8480
$margin: null,
8581
$title-alignment: null,
8682
$title-text-color: null,
@@ -201,8 +197,6 @@
201197
$y-axis-title-margin,
202198
(
203199
name: $name,
204-
width: $width,
205-
height: $height,
206200
margin: $margin,
207201
title-alignment: $title-alignment,
208202
title-text-color: $title-text-color,

projects/igniteui-angular/src/lib/core/styles/components/charts/_funnel-chart-theme.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
/// @param {Map} $palette [$default-palette] - The palette used as basis for styling the component.
88
/// @param {Map} $schema [$light-schema] - The schema used as basis for styling the component.
99
///
10-
/// @param {Number} $width [null] - The width of the chart.
11-
/// @param {Number} $height [null] - The height of the chart.
1210
/// @param {List} $brushes [null] - Defines the palette from which automatically assigned series colors are selected.
1311
/// @param {List} $outlines [null] - Defines the palette from which automatically assigned series outline colors are selected.
1412
/// @param {String} $outer-label-alignment [null] - Sets which side of the chart the outer labels should appear.
@@ -31,9 +29,7 @@
3129
$schema: $light-schema,
3230
3331
$brushes: null,
34-
$height: null,
3532
$outlines: null,
36-
$width: null,
3733
$outer-label-alignment: null,
3834
$outer-label-text-color: null,
3935
$outer-label-visibility: null,
@@ -53,8 +49,6 @@
5349

5450
@return extend($theme, (
5551
name: $name,
56-
width: $width,
57-
height: $height,
5852
brushes: $brushes,
5953
outlines: $outlines,
6054
outer-label-alignment: $outer-label-alignment,

projects/igniteui-angular/src/lib/core/styles/components/charts/_pie-chart-theme.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/// @param {Map} $palette [$default-palette] - The palette used as basis for styling the component.
88
/// @param {Map} $schema [$light-schema] - The schema used as basis for styling the component.
9-
/// @param {Map} $width [null] - Sets the width of the chart.
10-
/// @param {Map} $height [null] - Sets the height of the chart.
119
/// @param {List} $brushes [series] - Defines the palette from which automatically assigned series colors are selected.
1210
/// @param {List} $outlines [series] - Defines the palette from which automatically assigned series outline colors are selected.
1311
/// @param {Number} $label-extent [null] - Sets the pixel amount by which the labels are offset from the edge of the slices.
@@ -31,8 +29,6 @@
3129
$palette: $default-palette,
3230
$schema: $light-schema,
3331
34-
$width: null,
35-
$height: null,
3632
$brushes: null,
3733
$outlines: null,
3834
$label-extent: null,
@@ -57,8 +53,6 @@
5753

5854
@return extend( $theme, (
5955
name: $name,
60-
width: $width,
61-
height: $height,
6256
brushes: $brushes,
6357
outlines: $outlines,
6458
label-extent: $label-extent,
@@ -72,5 +66,3 @@
7266
));
7367
}
7468

75-
// @mixin igx-pie-chart-typography($type-scale, $categories: ()) {};
76-

projects/igniteui-angular/src/lib/core/styles/components/charts/_shape-chart-theme.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/// @param {Map} $palette [$default-palette] - The palette used as basis for styling the component.
88
/// @param {Map} $schema [$light-schema] - The schema used as basis for styling the component.
9-
/// @param {Map} $width [null] - The width of the chart.
10-
/// @param {Map} $height [null] - The height of the chart.
119
/// @param {List} $margin [null] - Sets the margin (top, right, bottom, left) of the chart content.
1210
/// @param {Color} $title-alignment [null] - Sets horizontal alignment which determines the title position, relative to the left and right edges of the control.
1311
/// @param {Color} $title-text-color [null] - Sets the color of the chart title.
@@ -60,8 +58,6 @@
6058
@function igx-shape-chart-theme(
6159
$palette: $default-palette,
6260
$schema: $light-schema,
63-
$width: null,
64-
$height: null,
6561
$margin: null,
6662
$title-text-color: null,
6763
$title-margin: null,
@@ -172,8 +168,6 @@
172168
$y-axis-title-margin,
173169
(
174170
name: $name,
175-
width: $width,
176-
height: $height,
177171
title-text-color: $title-text-color,
178172
subtitle-text-color: $subtitle-text-color,
179173
brushes: $brushes,

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_category-chart.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
/// @property {Color} title-text-color [null] - Sets the color of the chart title.
2121
/// @property {String} title-text-style [null] - Sets the CSS font property of the chart title.
2222
/// @property {List} subtitle-margin [null] - Sets the margins (top, right, bottom, left) of the chart subtitle.
23+
/// @property {String} subtitle-alignment [null] - The horizontal alignment to use for the subtitle.
2324
/// @property {Color} subtitle-text-color [null] - Sets the color of the chart subtitle.
2425
/// @property {String} subtitle-text-style [null] - Sets the CSS font property of the chart subtitle.
2526
/// @property {Number} thickness [null] - Sets the thickness for all series in a chart.
@@ -99,6 +100,8 @@ $_light-category-chart: extend(
99100
map-keys-prefix: 'subtitle'
100101
),
101102

103+
'subtitle-alignment': null,
104+
102105
'subtitle-text-color': (
103106
igx-color: ('grays', 700),
104107
hexrgba: #fff

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_data-chart.scss

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
/// Generates a light base data chart schema.
1010
/// @type {Map}
11-
/// @property {Map} width [null] - The width of the chart.
12-
/// @property {Map} height [null] - The height of the chart.
1311
/// @property {List} margin [null] - Sets the margin (top, right, bottom, left) of the chart content.
1412
/// @property {Color} title-text-color [igx-color: ('grays', 900)] - Sets the color of the chart title.
1513
/// @property {List} title-margin [null] - Sets the margin (top, right, bottom, left) of the chart title.
@@ -24,10 +22,6 @@
2422
/// @see $default-palette
2523
$_light-data-chart: extend(
2624
(
27-
'width': null,
28-
29-
'height': null,
30-
3125
'margin': null,
3226

3327
'title-text-color': (
@@ -54,7 +48,7 @@ $_light-data-chart: extend(
5448
igx-color: ('surface', 500)
5549
),
5650

57-
'title-horizontal-alignment': null
51+
'title-horizontal-alignment': null,
5852
)
5953
);
6054

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_financial-chart.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
/// Generates a light base chart schema.
1010
/// @type {Map}
11-
/// @prop {Number} width [null] - The width of the chart.
12-
/// @prop {Number} height [null] - The height of the chart.
1311
/// @prop {List} margin [null] - Sets the margin (top, right, bottom, left) of the chart content.
1412
/// @prop {String} title-alignment [null] - The horizontal alignment to use for the title.
1513
/// @prop {Color} title-text-color [null] - Sets the color of the chart title.
@@ -71,8 +69,6 @@
7169
/// @see $default-palette
7270
$_light-financial-chart: extend(
7371
(
74-
'width': null,
75-
'height': null,
7672
'margin': null,
7773
'title-alignment': null,
7874
'title-text-color': null,

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_funnel-chart.scss

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
/// Generates a light funnel chart schema.
1010
/// @type {Map}
11-
/// @property {Number} width [null] - The width of the chart.
12-
/// @property {Number} height [null] - The height of the chart.
1311
/// @property {List} brushes [series] - Defines the palette from which automatically assigned series colors are selected.
1412
/// @property {List} outlines [series] - Defines the palette from which automatically assigned series outline colors are selected.
1513
/// @property {String} outer-label-alignment [null] - Sets which side of the chart the outer labels should appear.
@@ -23,26 +21,14 @@
2321
/// @see $default-palette
2422
$_light-funnel-chart: extend(
2523
(
26-
'width': null,
27-
28-
'height': null,
29-
3024
'brushes': series,
31-
3225
'outlines': series,
33-
3426
'outer-label-alignment': null,
35-
3627
'outer-label-text-color': null,
37-
3828
'outer-label-text-style': null,
39-
4029
'outer-label-visibility': null,
41-
4230
'outline-thickness': null,
43-
4431
'text-color': null,
45-
4632
'text-style': null,
4733
)
4834
);

0 commit comments

Comments
 (0)