Merge branch '10.2.x' into mkirova/fix-8407

Author: ChronosSF

projects/igniteui-angular/package.json

@@ -84,7 +84,7 @@
         "web-animations-js": "^2.3.2"
     },
     "igxDevDependencies": {
-        "@igniteui/angular-schematics": "~10.2.620-beta.0"
+        "@igniteui/angular-schematics": "~10.2.620"
     },
     "ng-update": {
         "migrations": "./migrations/migration-collection.json"

projects/igniteui-angular/src/lib/core/utils.ts

@@ -328,7 +328,7 @@ export const NAVIGATION_KEYS = new Set([
 ]);
 export const ROW_EXPAND_KEYS = new Set('right down arrowright arrowdown'.split(' '));
 export const ROW_COLLAPSE_KEYS = new Set('left up arrowleft arrowup'.split(' '));
-export const SUPPORTED_KEYS = new Set([...Array.from(NAVIGATION_KEYS), 'enter', 'f2', 'escape', 'esc', 'pagedown', 'pageup', '+']);
+export const SUPPORTED_KEYS = new Set([...Array.from(NAVIGATION_KEYS), 'enter', 'f2', 'escape', 'esc', 'pagedown', 'pageup', '+', 'add']);
 export const HEADER_KEYS = new Set([...Array.from(NAVIGATION_KEYS), 'escape', 'esc' , 'l']);
 
 /**

projects/igniteui-angular/src/lib/grids/column-actions/column-actions-base.directive.ts

@@ -16,12 +16,12 @@ export abstract class IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel: string;
+    public abstract get checkAllLabel(): string;
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel: string;
+    public abstract get uncheckAllLabel(): string;
 
     /**
      * @hidden @internal

projects/igniteui-angular/src/lib/grids/column-actions/column-hiding.directive.ts

@@ -18,13 +18,16 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Hide All';
+    public get checkAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Hide All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Show All';
-
+    public get uncheckAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Show All';
+    }
     /**
      * @hidden @internal
      */

projects/igniteui-angular/src/lib/grids/column-actions/column-pinning.directive.ts

@@ -18,13 +18,16 @@ export class IgxColumnPinningDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_pinning_check_all_label ?? 'Pin All';
+    public get checkAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_pinning_check_all_label ?? 'Pin All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = this.columnActions.grid?.resourceStrings.igx_grid_pinning_uncheck_all_label ?? 'Unpin All';
-
+    public get uncheckAllLabel(): string {
+        return this.columnActions.grid?.resourceStrings.igx_grid_pinning_uncheck_all_label ?? 'Unpin All';
+    }
     /**
      * @hidden @internal
      */

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

@@ -501,7 +501,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
 
     private generateUniqueValues(columnValues: any[]) {
         if (this.column.dataType === DataType.String && this.column.filteringIgnoreCase) {
-            const filteredUniqueValues = columnValues.map(s => s?.toLowerCase())
+            const filteredUniqueValues = columnValues.map(s => s?.toString().toLowerCase())
                 .reduce((map, val, i) => map.get(val) ? map : map.set(val, columnValues[i]),
                 new Map);
 

projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts

@@ -51,7 +51,6 @@ export class IgxGridNavigationService {
             !this.grid.crudService.rowEditingBlocked && !this.grid.rowInEditMode) { return; }
         const shift = event.shiftKey;
         const ctrl = event.ctrlKey;
-        const alt = event.altKey;
         if (NAVIGATION_KEYS.has(key) && this.pendingNavigation) { event.preventDefault(); return; }
 
         const type = this.isDataRow(this.activeNode.row) ? 'dataCell' :
@@ -224,7 +223,7 @@ export class IgxGridNavigationService {
     }
 
     focusFirstCell(header = true) {
-        if (this.grid.dataView.length && this.activeNode &&
+        if ((header || this.grid.dataView.length) && this.activeNode &&
             (this.activeNode.row === -1 || this.activeNode.row === this.grid.dataView.length ||
             (!header && !this.grid.hasSummarizedColumns))) { return; }
 
@@ -631,6 +630,6 @@ export class IgxGridNavigationService {
     }
 
     private isAddKey(key: string): boolean {
-        return key === '+';
+        return key === '+' || key === 'add'; // add is for IE and Edge
     }
 }

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-add-row-ui.spec.ts

@@ -110,5 +110,22 @@ describe('IgxTreeGrid - Add Row UI #tGrid', () => {
             // should have same parent record.
             expect(addedRow.treeRow.parent).toBe(row.treeRow.parent);
         });
+
+        it('should allow adding row to empty grid', () => {
+            treeGrid.data = [];
+            fix.detectChanges();
+
+            expect(treeGrid.rowList.length).toBe(0);
+
+            // begin add row for empty grid
+            treeGrid.beginAddRowByIndex(null, -1);
+            fix.detectChanges();
+            endTransition();
+
+            treeGrid.endEdit(true);
+            fix.detectChanges();
+
+            expect(treeGrid.rowList.length).toBe(1);
+        });
     });
 });

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

@@ -526,9 +526,9 @@ export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridTy
     protected _getParentRecordId() {
         if (this.addRowParent.asChild) {
             return super._getParentRecordId();
-        } else {
+        } else if (this.addRowParent.rowID !== null && this.addRowParent.rowID !== undefined) {
             const spawnedForRecord =  this._gridAPI.get_rec_by_id(this.addRowParent.rowID);
-            return spawnedForRecord.parent?.rowID;
+            return spawnedForRecord?.parent?.rowID;
         }
     }
 

src/app/grid-column-actions/custom-action-directive.ts

@@ -18,12 +18,16 @@ export class IgxColumnGroupingDirective extends IgxColumnActionsBaseDirective {
     /**
      * @hidden @internal
      */
-    public checkAllLabel = 'Group By All';
+    public get checkAllLabel(): string {
+        return 'Group By All';
+    }
 
     /**
      * @hidden @internal
      */
-    public uncheckAllLabel = 'Ungroup All';
+    public get uncheckAllLabel(): string {
+        return 'Ungroup All';
+    }
 
     /**
      * @hidden @internal