Skip to content

Commit 9a10a4a

Browse files
authored
Merge branch '19.2.x' into gedinakova/advanced-filtering-resources-15788
2 parents a7b3e88 + 0d9ab22 commit 9a10a4a

File tree

9 files changed

+322
-55
lines changed

9 files changed

+322
-55
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"@types/source-map": "0.5.2",
7575
"express": "^4.21.1",
7676
"fflate": "^0.8.1",
77-
"igniteui-theming": "^17.2.0",
77+
"igniteui-theming": "^18.0.1",
7878
"igniteui-trial-watermark": "^3.0.2",
7979
"lodash-es": "^4.17.21",
8080
"rxjs": "^7.8.2",

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"tslib": "^2.3.0",
7474
"igniteui-trial-watermark": "^3.0.2",
7575
"lodash-es": "^4.17.21",
76-
"igniteui-theming": "^17.2.0",
76+
"igniteui-theming": "^18.0.1",
7777
"@igniteui/material-icons-extended": "^3.1.0"
7878
},
7979
"peerDependencies": {

projects/igniteui-angular/src/lib/core/styles/components/tabs/_tabs-theme.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@
187187
button-ripple-color: $button-ripple-color,
188188
border-color: $border-color,
189189
border-radius: $border-radius,
190+
border-color--hover: $border-color--hover,
190191
theme: map.get($schema, '_meta', 'theme'),
191192
_meta: map.merge(if($meta, $meta, ()), (
192193
variant: map.get($schema, '_meta', 'theme'),
@@ -409,7 +410,7 @@
409410
&:focus {
410411
border-top: rem(1px) solid transparent;
411412
border-inline: none;
412-
border-bottom: rem(1px) solid var-get($theme, 'border-color');
413+
border-bottom: rem(1px) solid var-get($theme, 'border-color--hover');
413414
}
414415

415416
igx-icon {

projects/igniteui-angular/src/lib/services/excel/excel-exporter-grid.spec.ts

Lines changed: 77 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ import { IgxHierarchicalGridExportComponent,
4747
import { IgxHierarchicalGridComponent } from '../../grids/hierarchical-grid/public_api';
4848
import { IgxHierarchicalRowComponent } from '../../grids/hierarchical-grid/hierarchical-row.component';
4949
import { GridFunctions } from '../../test-utils/grid-functions.spec';
50-
import { IgxPivotGridMultipleRowComponent, IgxPivotGridTestComplexHierarchyComponent } from '../../test-utils/pivot-grid-samples.spec';
51-
import { IgxPivotGridComponent, PivotRowLayoutType } from '../../grids/pivot-grid/public_api';
50+
import { IgxPivotGridMultipleRowComponent, IgxPivotGridTestComplexHierarchyComponent, SALES_DATA } from '../../test-utils/pivot-grid-samples.spec';
51+
import { IgxPivotGridComponent, IgxPivotNumericAggregate, PivotRowLayoutType } from '../../grids/pivot-grid/public_api';
5252

5353
describe('Excel Exporter', () => {
5454
let exporter: IgxExcelExporterService;
@@ -1461,7 +1461,7 @@ describe('Excel Exporter', () => {
14611461
let grid: IgxPivotGridComponent;
14621462

14631463
beforeEach(waitForAsync(() => {
1464-
options = createExportOptions('PivotGridGridExcelExport');
1464+
options = createExportOptions('PivotGridExcelExport');
14651465
}));
14661466

14671467
it('should export pivot grid', async () => {
@@ -1486,6 +1486,80 @@ describe('Excel Exporter', () => {
14861486
await exportAndVerify(grid, options, actualData.exportPivotGridDataWithHeaders, false);
14871487
});
14881488

1489+
it('should export pivot grid with hierarchical row dimensions.', async () => {
1490+
fix = TestBed.createComponent(IgxPivotGridMultipleRowComponent);
1491+
fix.detectChanges();
1492+
1493+
grid = fix.componentInstance.pivotGrid;
1494+
fix.componentInstance.data = SALES_DATA;
1495+
fix.componentInstance.pivotConfigHierarchy = {
1496+
rows: [
1497+
{
1498+
memberName: 'All_Srep Code Alts',
1499+
enabled: true,
1500+
width: '150px',
1501+
childLevel: {
1502+
memberName: 'SREP_CODE_ALT',
1503+
displayName: 'Srep Code Alt',
1504+
sortDirection: 1,
1505+
enabled: true,
1506+
},
1507+
},
1508+
{
1509+
memberName: 'All_Srep Codes',
1510+
enabled: true,
1511+
width: '150px',
1512+
childLevel: {
1513+
memberName: 'SREP_CODE',
1514+
displayName: 'Srep Code',
1515+
sortDirection: 1,
1516+
enabled: true,
1517+
},
1518+
},
1519+
{
1520+
memberName: 'All_Customers',
1521+
enabled: true,
1522+
width: '150px',
1523+
childLevel: {
1524+
memberName: 'CUST_CODE',
1525+
displayName: 'Customer',
1526+
sortDirection: 1,
1527+
enabled: true,
1528+
},
1529+
}
1530+
],
1531+
columns: [],
1532+
values: [
1533+
{
1534+
member: 'JOBS',
1535+
aggregate: {
1536+
key: 'Count of Jobs',
1537+
aggregator: IgxPivotNumericAggregate.count,
1538+
label: 'Count of Jobs',
1539+
},
1540+
enabled: true,
1541+
dataType: 'number',
1542+
},
1543+
{
1544+
member: 'INV_SALES',
1545+
aggregate: {
1546+
key: 'Sum of Sales',
1547+
aggregator: IgxPivotNumericAggregate.sum,
1548+
label: 'Sum of Sales',
1549+
},
1550+
enabled: true,
1551+
dataType: 'number',
1552+
},
1553+
],
1554+
filters: [],
1555+
};
1556+
grid.pivotUI.showRowHeaders = true;
1557+
fix.detectChanges();
1558+
await wait(300);
1559+
1560+
await exportAndVerify(grid, options, actualData.exportPivotGridHierarchicalRowDimensions, false);
1561+
});
1562+
14891563
it('should export hierarchical pivot grid', async () => {
14901564
fix = TestBed.createComponent(IgxPivotGridTestComplexHierarchyComponent);
14911565
fix.detectChanges();

projects/igniteui-angular/src/lib/services/excel/excel-files.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ export class WorksheetFile implements IExcelFile {
632632
for (const currentCol of headersForLevel) {
633633
const spanLength = isVertical ? currentCol.rowSpan : currentCol.columnSpan;
634634

635-
if (currentCol.level === i && currentCol.headerType !== ExportHeaderType.PivotMergedHeader) {
635+
if (currentCol.level === i) {
636636
let columnCoordinate;
637637
const column = isVertical
638638
? this.rowIndex
@@ -644,7 +644,10 @@ export class WorksheetFile implements IExcelFile {
644644
if (currentCol.headerType === ExportHeaderType.PivotRowHeader) {
645645
rowCoordinate = startValue + 1;
646646
}
647-
const columnValue = dictionary.saveValue(currentCol.header, true, false);
647+
648+
const columnValue = currentCol.headerType === ExportHeaderType.PivotMergedHeader ?
649+
dictionary.saveValue(currentCol.field, true, true) :
650+
dictionary.saveValue(currentCol.header, true, false);
648651

649652
columnCoordinate = (currentCol.field === GRID_LEVEL_COL
650653
? ExcelStrings.getExcelColumn(worksheetData.columnCount + 1)

0 commit comments

Comments
 (0)