refactor(date-range-picker): apply requested changes

Author: jackofdiamond5

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.spec.ts

@@ -637,7 +637,7 @@ describe('IgxDateRangePicker', () => {
                 it('should properly update component value with ngModel bound to projected inputs - #7353', fakeAsync(() => {
                     fixture = TestBed.createComponent(DateRangeTwoInputsNgModelTestComponent);
                     fixture.detectChanges();
-                    const range = { start: new Date(2020, 1, 1), end: new Date(2020, 1, 4) };
+                    const range = (fixture.componentInstance as DateRangeTwoInputsNgModelTestComponent).range;
                     fixture.componentInstance.dateRange.open();
                     fixture.detectChanges();
                     tick();

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts

@@ -641,6 +641,7 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
         // until the current change detection cycle has completed
         Promise.resolve().then(() => {
             this.initialSetValue();
+            this.updateInputs();
         });
     }
 
@@ -922,18 +923,10 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
         if ((!this.value || (!this.value.start && !this.value.end)) && this.hasProjectedInputs && !this._ngControl) {
             const start = this.projectedInputs.find(i => i instanceof IgxDateRangeStartComponent);
             const end = this.projectedInputs.find(i => i instanceof IgxDateRangeEndComponent);
-            const value = {
+            this._value = {
                 start: start.dateTimeEditor.value,
                 end: end.dateTimeEditor.value
             };
-
-            if (start.dateTimeEditor.ngControl && end.dateTimeEditor.ngControl) {
-                // ngModel will handle value setting in the editors
-                // we need to only set the internal value of the picker
-                this._value = value;
-            } else {
-                this.updateValue(value);
-            }
         }
     }
 

projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.spec.ts

@@ -26,8 +26,8 @@ describe('IgxDateTimeEditor', () => {
         let inputFormat: string;
         let inputDate: string;
         function initializeDateTimeEditor(control?: NgControl) {
-            const injector = { get: () => control };
-            dateTimeEditor = new IgxDateTimeEditorDirective(renderer2, elementRef, maskParsingService, DOCUMENT, locale, injector);
+            // const injector = { get: () => control };
+            dateTimeEditor = new IgxDateTimeEditorDirective(renderer2, elementRef, maskParsingService, DOCUMENT, locale);
             dateTimeEditor.inputFormat = inputFormat;
             dateTimeEditor.ngOnInit();
 

projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts

@@ -1,10 +1,10 @@
 import {
   Directive, Input, ElementRef,
-  Renderer2, NgModule, Output, EventEmitter, Inject, LOCALE_ID, OnChanges, SimpleChanges, Host, Optional, Injector, OnInit
+  Renderer2, NgModule, Output, EventEmitter, Inject, LOCALE_ID, OnChanges, SimpleChanges
 } from '@angular/core';
 import {
   ControlValueAccessor,
-  Validator, AbstractControl, ValidationErrors, NG_VALIDATORS, NgControl, NG_VALUE_ACCESSOR,
+  Validator, AbstractControl, ValidationErrors, NG_VALIDATORS, NG_VALUE_ACCESSOR,
 } from '@angular/forms';
 import { formatDate, DOCUMENT } from '@angular/common';
 import { IgxMaskDirective } from '../mask/mask.directive';
@@ -51,7 +51,7 @@ import { IgxDateTimeEditorEventArgs, DatePartInfo, DatePart } from './date-time-
     { provide: NG_VALIDATORS, useExisting: IgxDateTimeEditorDirective, multi: true }
   ]
 })
-export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnChanges, OnInit, Validator, ControlValueAccessor {
+export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnChanges, Validator, ControlValueAccessor {
   /**
    * Locale settings used for value formatting.
    *
@@ -188,9 +188,6 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
   @Output()
   public validationFailed = new EventEmitter<IgxDateTimeEditorEventArgs>();
 
-  /** @hidden @internal */
-  public ngControl: NgControl;
-
   private _value: Date;
   private _format: string;
   private document: Document;
@@ -239,8 +236,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
     protected elementRef: ElementRef,
     protected maskParser: MaskParsingService,
     @Inject(DOCUMENT) private _document: any,
-    @Inject(LOCALE_ID) private _locale: any,
-    private injector: Injector) {
+    @Inject(LOCALE_ID) private _locale: any) {
     super(elementRef, maskParser, renderer);
     this.document = this._document as Document;
     this.locale = this.locale || this._locale;
@@ -260,10 +256,6 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
     }
   }
 
-  public ngOnInit(): void {
-    this.ngControl = this.injector.get<NgControl>(NgControl, null);
-  }
-
   /** Clear the input element value. */
   public clear(): void {
     this.updateValue(null);