test(overlay): fix failing tests

Author: wnvko

projects/igniteui-angular/src/lib/services/overlay/overlay.spec.ts

@@ -1407,7 +1407,8 @@ describe('igxOverlay', () => {
             tick();
 
             expect(lastPositionSpy).toHaveBeenCalledTimes(1);
-            expect(info.settings).toBe(os);
+            expect(info.settings.scrollStrategy).toBe(os.scrollStrategy);
+            expect(info.settings.positionStrategy).toBe(os.positionStrategy);
         }));
     });
 

projects/igniteui-angular/src/lib/services/overlay/overlay.ts

@@ -347,7 +347,7 @@ export class IgxOverlayService implements OnDestroy {
         const elementRect = info.elementRef.nativeElement.getBoundingClientRect();
         info.initialSize = { width: elementRect.width, height: elementRect.height };
         // Get the size before moving the container into the overlay so that it does not forget about inherited styles.
-        this.getComponentSize(info); 
+        this.getComponentSize(info);
         this.moveElementToOverlay(info);
         // Update the container size after moving if there is size.
         if (info.size) {
@@ -416,7 +416,9 @@ export class IgxOverlayService implements OnDestroy {
             return;
         }
         if (settings) {
-            info.settings = settings;
+            settings.positionStrategy ??= info.settings.positionStrategy;
+            settings.scrollStrategy ??= info.settings.scrollStrategy;
+            info.settings = { ...info.settings, ...settings };
         }
         this.updateSize(info);
         info.settings.positionStrategy.position(
@@ -597,7 +599,7 @@ export class IgxOverlayService implements OnDestroy {
                 const createSettings = viewContainerRefOrSettings as OverlayCreateSettings | undefined;
                 let elementInjector: Injector;
                 if (createSettings) {
-                    ({ injector: elementInjector, ...overlaySettings} = createSettings);
+                    ({ injector: elementInjector, ...overlaySettings } = createSettings);
                 }
                 dynamicComponent = createComponent(component, { environmentInjector, elementInjector });
                 this._appRef.attachView(dynamicComponent.hostView);
@@ -615,7 +617,7 @@ export class IgxOverlayService implements OnDestroy {
             info.elementRef = { nativeElement: element };
             info.componentRef = dynamicComponent;
         }
-        info.settings = Object.assign({}, this._defaultSettings, overlaySettings); 
+        info.settings = Object.assign({}, this._defaultSettings, overlaySettings);
         return info;
     }