Merge pull request #9381 from IgniteUI/dTsvetkov/fix-9348-11.1.x

fix(toolbar): Fixed toolbar-hiding action buttons -11.1.x

Author: zdrawku

projects/igniteui-angular/src/lib/core/i18n/grid-resources.ts

@@ -222,8 +222,8 @@ export const GridResourceStringsEN: IGridResourceStrings = {
     igx_grid_advanced_filter_column_placeholder: 'Select column',
     igx_grid_advanced_filter_value_placeholder: 'Value',
     igx_grid_pinned_row_indicator: 'Pinned',
-    igx_grid_hiding_check_all_label: 'Hide All',
-    igx_grid_hiding_uncheck_all_label: 'Show All',
+    igx_grid_hiding_check_all_label: 'Show All',
+    igx_grid_hiding_uncheck_all_label: 'Hide All',
     igx_grid_pinning_check_all_label: 'Pin All',
     igx_grid_pinning_uncheck_all_label: 'Unpin All',
     igx_grid_toolbar_actions_filter_prompt: 'Filter columns list ...',

projects/igniteui-angular/src/lib/grids/column-actions/column-hiding.directive.ts

@@ -19,28 +19,28 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
      * @hidden @internal
      */
     public get checkAllLabel(): string {
-        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Hide All';
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_check_all_label ?? 'Show All';
     }
 
     /**
      * @hidden @internal
      */
     public get uncheckAllLabel(): string {
-        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Show All';
+        return this.columnActions.grid?.resourceStrings.igx_grid_hiding_uncheck_all_label ?? 'Hide All';
     }
     /**
      * @hidden @internal
      */
     public checkAll() {
-        this.columnActions.filteredColumns.forEach(c => c.toggleVisibility(true));
+        this.columnActions.filteredColumns.forEach(c => c.toggleVisibility(false));
 
     }
 
     /**
      * @hidden @internal
      */
     public uncheckAll() {
-        this.columnActions.filteredColumns.forEach(c => c.toggleVisibility(false));
+        this.columnActions.filteredColumns.forEach(c => c.toggleVisibility(true));
     }
 
     /**
@@ -63,10 +63,10 @@ export class IgxColumnHidingDirective extends IgxColumnActionsBaseDirective {
     }
 
     public get allChecked() {
-        return this.columnActions.filteredColumns.every(col => this.columnChecked(col));
+        return this.columnActions.filteredColumns.every(col => !this.columnChecked(col));
     }
 
     public get allUnchecked() {
-        return this.columnActions.filteredColumns.every(col => !this.columnChecked(col));
+        return this.columnActions.filteredColumns.every(col => this.columnChecked(col));
     }
 }

projects/igniteui-angular/src/lib/grids/grid/column-hiding.spec.ts

@@ -579,8 +579,8 @@ describe('Column Hiding UI #grid', () => {
 
             const showAll = GridFunctions.getColumnChooserButton(columnChooserElement, 'Show All');
             const hideAll = GridFunctions.getColumnChooserButton(columnChooserElement, 'Hide All').nativeElement;
-            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement, false);
-            ControlsFunction.verifyButtonIsDisabled(hideAll);
+            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement);
+            ControlsFunction.verifyButtonIsDisabled(hideAll, false);
 
             showAll.triggerEventHandler('click', new Event('click'));
             fix.detectChanges();
@@ -600,11 +600,11 @@ describe('Column Hiding UI #grid', () => {
             fix.detectChanges();
             tick();
 
-            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement, false);
+            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement);
             ControlsFunction.verifyButtonIsDisabled(hideAll, false);
 
             checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, 'ProductName');
-            expect(GridFunctions.getColumnChooserItemInput(checkbox).checked).toBe(false);
+            expect(GridFunctions.getColumnChooserItemInput(checkbox).checked).toBe(true);
 
             showAll.triggerEventHandler('click', new Event('click'));
             fix.detectChanges();
@@ -616,11 +616,11 @@ describe('Column Hiding UI #grid', () => {
             expect(columnChooser.filterCriteria).toBe('', 'Filter criteria is not empty string!');
 
             checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, 'ID');
-            expect(GridFunctions.getColumnChooserItemInput(checkbox).checked).toBe(false);
+            expect(GridFunctions.getColumnChooserItemInput(checkbox).checked).toBe(true);
             checkbox = GridFunctions.getColumnChooserItemElement(columnChooserElement, 'ProductName');
             expect(GridFunctions.getColumnChooserItemInput(checkbox).checked).toBe(true);
 
-            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement, false);
+            ControlsFunction.verifyButtonIsDisabled(showAll.nativeElement);
             ControlsFunction.verifyButtonIsDisabled(hideAll, false);
         }));