perf(*): change how esf generates the unique list in tree grid (use flat data instead of the hierarchical)

Author: mddragnev

projects/igniteui-angular/src/lib/data-operations/data-util.ts

@@ -5,7 +5,7 @@ import { IPagingState, PagingError } from './paging-state.interface';
 import { IGroupByKey } from './groupby-expand-state.interface';
 import { IGroupByRecord } from './groupby-record.interface';
 import { IGroupingState } from './groupby-state.interface';
-import { mergeObjects } from '../core/utils';
+import { cloneArray, mergeObjects } from '../core/utils';
 import { Transaction, TransactionType, HierarchicalTransaction } from '../services/transaction/transaction';
 import { getHierarchy, isHierarchyMatch } from './operations';
 import { ColumnType, GridType } from '../grids/common/grid.interface';
@@ -21,6 +21,8 @@ import {
 import { DefaultDataCloneStrategy, IDataCloneStrategy } from '../data-operations/data-clone-strategy';
 import { IGroupingExpression } from './grouping-expression.interface';
 import { DefaultMergeStrategy, IGridMergeStrategy } from './merge-strategy';
+import { IFilteringExpressionsTree } from './filtering-expressions-tree';
+import { FilteringStrategy, FilterUtil } from './filtering-strategy';
 
 /**
  * @hidden
@@ -278,6 +280,15 @@ export class DataUtil {
         return value;
     }
 
+    public static filterDataByExpressions(data: any[], expressionsTree: IFilteringExpressionsTree, grid: GridType): any {
+        if (expressionsTree.filteringOperands.length) {
+            const state = { expressionsTree, strategy: FilteringStrategy.instance() };
+            data = FilterUtil.filter(cloneArray(data), state, grid);
+        }
+
+        return data;
+    }
+
     private static findParentFromPath(data: any[], primaryKey: any, childDataKey: any, path: any[]): any {
         let collection: any[] = data;
         let result: any;

projects/igniteui-angular/src/lib/data-operations/filtering-strategy.ts

@@ -133,13 +133,13 @@ export abstract class BaseFilteringStrategy implements IFilteringStrategy {
     public getFilterItems(column: ColumnType, tree: IFilteringExpressionsTree): Promise<IgxFilterItem[]> {
         const applyFormatter = column.formatter && this.shouldFormatFilterValues(column);
 
-        const data = column.grid.gridAPI.filterDataByExpressions(tree);
+        const data = this.getFilteredData(column, tree);
 
         const pathParts = columnFieldPath(column.field)
         const seenFormattedFilterItems = new Map<any, IgxFilterItem>()
 
         for (let i = 0; i < data.length; ++i) {
-            const record = this.getRecord(data[i]);
+            const record = data[i]
             const rawValue = resolveNestedPath(record, pathParts);
             const formattedValue = applyFormatter ? column.formatter(rawValue, record) : rawValue;
             const { key, finalValue } = this.getFilterItemKeyValue(formattedValue, column);
@@ -158,6 +158,10 @@ export abstract class BaseFilteringStrategy implements IFilteringStrategy {
         return Promise.resolve(filterItems);
     }
 
+    protected getFilteredData(column: ColumnType, tree: IFilteringExpressionsTree) {
+        return column.grid.gridAPI.filterDataByExpressions(tree);
+    }
+
     protected getFilterItemLabel(column: ColumnType, value: any, applyFormatter: boolean, data: any) {
         if (column.formatter) {
             if (applyFormatter) {
@@ -214,10 +218,6 @@ export abstract class BaseFilteringStrategy implements IFilteringStrategy {
         return { key, finalValue };
     }
 
-    protected getRecord(item: any) {
-        return item;
-    }
-
     protected shouldFormatFilterValues(_column: ColumnType): boolean {
         return false;
     }

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.filtering.strategy.ts

@@ -89,6 +89,10 @@ export class TreeGridFilteringStrategy extends BaseFilteringStrategy {
         return Promise.resolve(items);
     }
 
+    protected override getFilteredData(column: ColumnType, tree: IFilteringExpressionsTree) {
+        return DataUtil.filterDataByExpressions(column.grid.flatData, tree, column.grid);
+    }
+
     private getHierarchicalFilterItems(records: ITreeGridRecord[], column: ColumnType, parent?: IgxFilterItem): IgxFilterItem[] {
         const pathParts = columnFieldPath(column.field);
         return records?.map(record => {
@@ -109,10 +113,6 @@ export class TreeGridFilteringStrategy extends BaseFilteringStrategy {
             return filterItem;
         });
     }
-
-    protected override getRecord(item: any) {
-        return item.data;
-    }
 }
 
 export class TreeGridFormattedValuesFilteringStrategy extends TreeGridFilteringStrategy {