chore(*): addres pending issues and review comment

Author: ddincheva

CHANGELOG.md

@@ -8,7 +8,7 @@ All notable changes for each version of this project will be documented in this
 - `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
     - `uniqueColumnValuesStrategy` input is added. This property provides a callback for loading unique column values on demand. If this property is provided, the unique values it generates will be used by the Excel Style Filtering (instead of using the unique values from the data that is bound to the grid).
     - `igxExcelStyleLoading` directive is added, which can be used to provide a custom loading template for the Excel Style Filtering. If this property is not provided, a default loading template will be used instead.
-    - introduced new propoerties `cellSelection` and `rowSelection` which accepts GridSelection mode enumeration. Grid selection mode could be none, single or multiple. Also `hideRowSelectors` property is added, which allows you to show and hide row selectors when row selection is enabled.
+    - introduced new propoerties `cellSelection` and `rowSelection` which accept GridSelection mode enumeration. Grid selection mode could be none, single or multiple. Also `hideRowSelectors` property is added, which allows you to show and hide row selectors when row selection is enabled.
 ### General
 - `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
     - Removed deprecated event `OnFocusChange`

projects/igniteui-angular/src/lib/core/grid-selection.ts

@@ -646,8 +646,8 @@ export class IgxGridSelectionService {
 
     public getRowDataByID(rowID) {
         if (!this.grid.primaryKey) { return rowID; }
-        const rowIndex = this.getRowIDs(this.grid.gridAPI.get_all_data()).indexOf(rowID);
-        return rowIndex < 0 ? {} : this.grid.gridAPI.get_all_data()[rowIndex];
+        const rowIndex = this.getRowIDs(this.grid.gridAPI.get_all_data(true)).indexOf(rowID);
+        return rowIndex < 0 ? {} : this.grid.gridAPI.get_all_data(true)[rowIndex];
     }
 
     public getRowIDs(data) {
@@ -660,7 +660,7 @@ export class IgxGridSelectionService {
 
     public get allData() {
         const allData = this.isFilteringApplied() || this.grid.sortingExpressions.length ?
-            this.grid.filteredSortedData : this.grid.gridAPI.get_all_data();
+            this.grid.filteredSortedData : this.grid.gridAPI.get_all_data(true);
         return allData.filter(rData => !this.isRowDeleted(this.grid.gridAPI.get_row_id(rData)));
     }
 

projects/igniteui-angular/src/lib/grids/api.service.ts

@@ -505,7 +505,7 @@ export class GridBaseAPIService <T extends IgxGridBaseComponent & IGridDataBinda
 
         this.deleteRowFromData(rowId, index);
 
-        if (grid.selectionService.isRowSelected(rowId)) { grid.selectionService.deselectRow(rowId); }
+        grid.selectionService.isRowSelected(rowId) ? grid.selectionService.deselectRow(rowId) : grid.selectionService.clearHeaderCBState();
         (grid as any)._pipeTrigger++;
         grid.notifyChanges();
         // Data needs to be recalculated if transactions are in place

projects/igniteui-angular/src/lib/grids/grid/grid-row-selection.spec.ts

@@ -1405,7 +1405,6 @@ describe('IgxGrid - Row Selection #grid', () => {
         }));
 
         it('CRUD: Should handle the deselection on a selected row properly', (async () => {
-            pending('need to be fixed');
             let firstRow = grid.getRowByKey(1);
             grid.selectRows([1]);
 
@@ -1823,7 +1822,6 @@ describe('IgxGrid - Row Selection #grid', () => {
         });
 
         it('Should have correct header checkbox when add row', (async () => {
-            pending('need to be fixed');
             grid.height = '800px';
             fix.detectChanges();
             await wait(DEBOUNCETIME);
@@ -1853,7 +1851,6 @@ describe('IgxGrid - Row Selection #grid', () => {
         }));
 
         it('Should be able to select added row', (async () => {
-            pending('need to be fixed');
             grid.height = '800px';
             fix.detectChanges();
             await wait(DEBOUNCETIME);

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-expanding.spec.ts

@@ -991,7 +991,6 @@ describe('IgxTreeGrid - Expanding / Collapsing #tGrid', () => {
             });
 
             it('check row selection when expand a row', async () => {
-                pending('need to be fixed');
                 treeGrid.rowSelection = GridSelectionMode.multiple;
                 fix.detectChanges();
 

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

@@ -508,7 +508,7 @@ export class IgxTreeGridComponent extends IgxGridBaseComponent implements IGridD
 
             parentData[this.childDataKey] = children;
         }
-
+        this.selectionService.clearHeaderCBState();
         this._pipeTrigger++;
     }