chore(*): Change names of the methods to check if a given row is pinned by idx

Author: 3phase

projects/igniteui-angular/src/lib/grids/cell.component.ts

@@ -906,7 +906,7 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
      */
     public get searchMetadata() {
         const meta = new Map<string, any>();
-        meta.set('pinned', this.grid.isRecordPinnedByIndex(this.row.index));
+        meta.set('pinned', this.grid.isRecordPinnedByViewIndex(this.row.index));
         return meta;
     }
 }

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -2723,19 +2723,27 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
     }
 
     /**
+     * Returns whether the record is pinned or not.
+     *
+     * @param rowIndex Index of the record in the `dataView` collection.
+     *
      * @hidden
      * @internal
      */
-    public isRecordPinnedByIndex(rowIndex: number) {
+    public isRecordPinnedByViewIndex(rowIndex: number) {
         return this.hasPinnedRecords && (this.isRowPinningToTop && rowIndex < this.pinnedDataView.length) ||
             (!this.isRowPinningToTop && rowIndex >= this.unpinnedDataView.length);
     }
 
     /**
+     * Returns whether the record is pinned or not.
+     *
+     * @param rowIndex Index of the record in the `filteredSortedData` collection.
+     *
      * @hidden
      * @internal
      */
-    public isFilteredSortedDataRecordPinnedByIndex(rowIndex: number) {
+    public isRecordPinnedByIndex(rowIndex: number) {
         return this.hasPinnedRecords && (this.isRowPinningToTop && rowIndex < this._filteredSortedPinnedData.length) ||
             (!this.isRowPinningToTop && rowIndex >= this._filteredSortedUnpinnedData.length);
     }
@@ -6017,7 +6025,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
                     if (exactMatch) {
                         if (searchValue === searchText) {
                             const metadata = new Map<string, any>();
-                            metadata.set('pinned', this.isFilteredSortedDataRecordPinnedByIndex(rowIndex));
+                            metadata.set('pinned', this.isRecordPinnedByIndex(rowIndex));
                             this.lastSearchInfo.matchInfoCache.push({
                                 row: dataRow,
                                 column: c.field,
@@ -6031,7 +6039,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
 
                         while (searchIndex !== -1) {
                             const metadata = new Map<string, any>();
-                            metadata.set('pinned', this.isFilteredSortedDataRecordPinnedByIndex(rowIndex));
+                            metadata.set('pinned', this.isRecordPinnedByIndex(rowIndex));
                             this.lastSearchInfo.matchInfoCache.push({
                                 row: dataRow,
                                 column: c.field,

projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts

@@ -309,7 +309,7 @@ export class IgxGridNavigationService {
     }
 
     public shouldPerformVerticalScroll(targetRowIndex: number, visibleColIndex: number): boolean {
-        if (this.grid.isRecordPinnedByIndex(targetRowIndex)) { return false; }
+        if (this.grid.isRecordPinnedByViewIndex(targetRowIndex)) { return false; }
         const scrollRowIndex = this.grid.hasPinnedRecords && this.grid.isRowPinningToTop ?
             targetRowIndex - this.grid.pinnedDataView.length : targetRowIndex;
         const targetRow = this.getRowElementByIndex(targetRowIndex);