Skip to content

Commit a7d6b71

Browse files
authored
Merge branch 'master' into mkirova/fix-pinChip-mdv
2 parents 3402559 + 013aa82 commit a7d6b71

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ export class IgxColumnComponent implements AfterContentInit {
276276
this.grid.endEdit(false);
277277
this.grid.summaryService.resetSummaryHeight();
278278
this.grid.filteringService.refreshExpressions();
279+
this.grid.filteringService.hideFilteringRowOnColumnVisibilityChange(this);
279280
this.grid.notifyChanges();
280281
}
281282
}

projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,17 @@ export class IgxFilteringService implements OnDestroy {
9797
filterCell.updateFilterCellArea();
9898
});
9999
});
100+
}
101+
}
100102

101-
this.grid.onColumnVisibilityChanged.pipe(takeUntil(this.destroy$)).subscribe((eventArgs: IColumnVisibilityChangedEventArgs) => {
102-
if (this.grid.filteringRow && this.grid.filteringRow.column === eventArgs.column ) {
103-
this.grid.filteringRow.close();
103+
/**
104+
* Close filtering row if a column is hidden.
105+
*/
106+
public hideFilteringRowOnColumnVisibilityChange(col: IgxColumnComponent) {
107+
const filteringRow = this.grid.filteringRow;
104108

105-
}
106-
});
109+
if (filteringRow && filteringRow.column && filteringRow.column === col) {
110+
filteringRow.close();
107111
}
108112
}
109113

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2138,24 +2138,24 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
21382138
}));
21392139

21402140
it('Should close filter row when hide the current column', fakeAsync(() => {
2141-
pending('This issue is failing because of bug #');
21422141
GridFunctions.clickFilterCellChip(fix, 'ProductName');
21432142

21442143
// Check that the filterRow is opened
2145-
const filterUIRow = fix.debugElement.query(By.css(FILTER_UI_ROW));
2144+
let filterUIRow = fix.debugElement.query(By.css(FILTER_UI_ROW));
21462145
expect(filterUIRow).not.toBeNull();
21472146

21482147
// Add first chip.
21492148
GridFunctions.typeValueInFilterRowInput('a', fix);
21502149
tick(100);
21512150

21522151
grid.getColumnByName('ProductName').hidden = true;
2153-
fix.detectChanges();
21542152
tick(100);
2153+
fix.detectChanges();
21552154

21562155
// Check that the filterRow is closed
2157-
expect(fix.debugElement.query(By.css(FILTER_UI_ROW))).toBeNull();
2158-
expect(grid.rowList.length).toBe(8);
2156+
filterUIRow = fix.debugElement.query(By.css(FILTER_UI_ROW));
2157+
expect(filterUIRow).toBeNull();
2158+
expect(grid.rowList.length).toBe(3, 'filter is not applied');
21592159
}));
21602160

21612161
it('Should keep existing column filter after hiding another column.', fakeAsync(() => {

projects/igniteui-angular/src/lib/paginator/paginator.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { IgxSelectModule } from '../select/index';
77
import { IgxIconModule } from '../icon/index';
88
import { IgxButtonModule } from '../directives/button/button.directive';
99
import { IgxRippleModule } from '../directives/ripple/ripple.directive';
10-
import { IgxInputGroupModule } from '../input-group';
10+
import { IgxInputGroupModule } from '../input-group/index';
1111
import { IPaginatorResourceStrings } from '../core/i18n/paginator-resources';
1212
import { DeprecateProperty } from '../core/deprecateDecorators';
1313

0 commit comments

Comments
 (0)