refactor(combo): only handle selection set in id setter

ddaribo · ddaribo · commit a80cbac9436c · 2024-10-28T12:17:13.000+02:00
diff --git a/projects/igniteui-angular/src/lib/combo/combo.common.ts b/projects/igniteui-angular/src/lib/combo/combo.common.ts
@@ -179,17 +179,11 @@ export abstract class IgxComboBaseDirective implements IgxComboBase, AfterViewCh
             return;
         }
         const selection = this.selectionService.get(this._id);
+        this.selectionService.clear(this._id);
         this._id = value;
         if (selection) {
             this.selectionService.set(this._id, selection);
         }
-        if (this.dropdown?.open) {
-            this.dropdown.close();
-        }
-        if (this.inputGroup?.isFocused) {
-            this.inputGroup.element.nativeElement.blur();
-            this.inputGroup.isFocused = false;
-        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -179,17 +179,11 @@ export abstract class IgxComboBaseDirective implements IgxComboBase, AfterViewCh`
`179`	`179`	`return;`
`180`	`180`	`}`
`181`	`181`	`const selection = this.selectionService.get(this._id);`
	`182`	`+ this.selectionService.clear(this._id);`
`182`	`183`	`this._id = value;`
`183`	`184`	`if (selection) {`
`184`	`185`	`this.selectionService.set(this._id, selection);`
`185`	`186`	`}`
`186`		`- if (this.dropdown?.open) {`
`187`		`- this.dropdown.close();`
`188`		`- }`
`189`		`- if (this.inputGroup?.isFocused) {`
`190`		`- this.inputGroup.element.nativeElement.blur();`
`191`		`- this.inputGroup.isFocused = false;`
`192`		`- }`
`193`	`187`	`}`
`194`	`188`
`195`	`189`	`/**`