Skip to content

Commit a8ff6b8

Browse files
kdinevkdinev
authored
fix(buttons): adding missing type=button #13567 (#13572)
* fix(buttons): adding missing type=button #13567 * ci(*): turning off node 16 CI
1 parent 9f2c510 commit a8ff6b8

File tree

67 files changed

+254
-252
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+254
-252
lines changed

‎.github/workflows/nodejs.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [16.x, 18.x, 20.5.x]
19+
node-version: [18.x, 20.5.x]
2020

2121
steps:
2222
- name: Checkout
@@ -55,7 +55,7 @@ jobs:
5555
- name: Bundle Tree-Shake Test
5656
run: npm run build:bundletest
5757
- name: Publish to coveralls.io
58-
if: github.repository == 'IgniteUI/igniteui-angular' && matrix.node-version == '16.x'
58+
if: github.repository == 'IgniteUI/igniteui-angular' && matrix.node-version == '18.x'
5959
uses: coverallsapp/[email protected]
6060
with:
6161
github-token: ${{ github.token }}

‎azure-pipelines.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ pool:
44
steps:
55
- task: NodeTool@0
66
inputs:
7-
versionSpec: '16.x'
7+
versionSpec: '18.x'
88
displayName: 'Install Node.js'
99

1010
- script: npm ci

‎projects/igniteui-angular/src/lib/action-strip/action-strip.component.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<ng-content #content></ng-content>
33
<ng-container *ngIf="menuItems.length > 0">
44
<button
5+
type="button"
56
igxButton="icon"
67
igxRipple
78
[igxToggleAction]="dropdown"

‎projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-action-button.component.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
<ng-container *ngIf="!asMenuItem">
2-
<button [title]="labelText" igxButton="icon" igxRipple (click)="handleClick($event)" (mousedown)="preventEvent($event)">
2+
<button type="button" [title]="labelText" igxButton="icon" igxRipple (click)="handleClick($event)" (mousedown)="preventEvent($event)">
33
<igx-icon *ngIf="iconSet" [family]="iconSet" [name]="iconName">{{iconName}}</igx-icon>
44
<igx-icon *ngIf="!iconSet" >{{iconName}}</igx-icon>
55
</button>
66
</ng-container>
77

88
<ng-template #menuItemTemplate>
99
<ng-container *ngIf="asMenuItem">
10-
<div #container [className]='containerClass'>
10+
<div #container [className]="containerClass">
1111
<igx-icon *ngIf="iconSet" [family]="iconSet" [name]="iconName">{{iconName}}</igx-icon>
1212
<igx-icon *ngIf="!iconSet" >{{iconName}}</igx-icon>
1313
<label igxLabel>{{labelText}}</label>
1414
</div>
1515
</ng-container>
16-
</ng-template>
16+
</ng-template>

‎projects/igniteui-angular/src/lib/banner/banner.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</div>
1313
<div class="igx-banner__actions">
1414
<ng-container *ngIf="useDefaultTemplate">
15-
<button igxButton="flat" igxRipple (click)="close()">
15+
<button type="button" igxButton="flat" igxRipple (click)="close()">
1616
{{ resourceStrings.igx_banner_button_dismiss }}
1717
</button>
1818
</ng-container>

‎projects/igniteui-angular/src/lib/banner/banner.component.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ export interface BannerCancelEventArgs extends BannerEventArgs, CancelableEventA
4444
* <igx-banner #banner>
4545
* Our privacy settings have changed.
4646
* <igx-banner-actions>
47-
* <button igxButton="raised">Read More</button>
48-
* <button igxButton="raised">Accept and Continue</button>
47+
* <button type="button" igxButton="raised">Read More</button>
48+
* <button type="button" igxButton="raised">Accept and Continue</button>
4949
* </igx-banner-actions>
5050
* </igx-banner>
5151
* ```
@@ -220,7 +220,7 @@ export class IgxBannerComponent implements IToggleView {
220220
* <igx-banner #banner>
221221
* ...
222222
* </igx-banner>
223-
* <button (click)="banner.open()">Open Banner</button>
223+
* <button type="button" (click)="banner.open()">Open Banner</button>
224224
* ```
225225
*/
226226
public open(event?: Event) {
@@ -249,7 +249,7 @@ export class IgxBannerComponent implements IToggleView {
249249
* <igx-banner #banner>
250250
* ...
251251
* </igx-banner>
252-
* <button (click)="banner.close()">Close Banner</button>
252+
* <button type="button" (click)="banner.close()">Close Banner</button>
253253
* ```
254254
*/
255255
public close(event?: Event) {
@@ -278,7 +278,7 @@ export class IgxBannerComponent implements IToggleView {
278278
* <igx-banner #banner>
279279
* ...
280280
* </igx-banner>
281-
* <button (click)="banner.toggle()">Toggle Banner</button>
281+
* <button type="button" (click)="banner.toggle()">Toggle Banner</button>
282282
* ```
283283
*/
284284
public toggle(event?: Event) {

‎projects/igniteui-angular/src/lib/card/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ Supporting directives and components:
2828
</igx-card-content>
2929

3030
<igx-card-actions>
31-
<button igxButton (click)="openUrl('https://www.facebook.com/pages/Elon-Musk/108250442531979')">Like</button>
32-
<button igxButton (click)="openUrl('https://twitter.com/elonmusk')">Share</button>
31+
<button type="button" igxButton (click)="openUrl('https://www.facebook.com/pages/Elon-Musk/108250442531979')">Like</button>
32+
<button type="button" igxButton (click)="openUrl('https://twitter.com/elonmusk')">Share</button>
3333
</igx-card-actions>
3434
</igx-card>
3535
```

‎projects/igniteui-angular/src/lib/card/card.component.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ export class IgxCardFooterDirective {
187187
* <h5 igxCardHeaderSubtitle>{{subtitle}}</h5>
188188
* </igx-card-header>
189189
* <igx-card-actions>
190-
* <button igxButton igxRipple>Share</button>
191-
* <button igxButton igxRipple>Play Album</button>
190+
* <button type="button" igxButton igxRipple>Share</button>
191+
* <button type="button" igxButton igxRipple>Play Album</button>
192192
* </igx-card-actions>
193193
* </igx-card>
194194
* ```

‎projects/igniteui-angular/src/lib/carousel/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ The **IgxCarousel** supports templating indicators and navigation buttons
6161
<igx-carousel #carousel>
6262
...
6363
<ng-template igxCarouselNextButton let-disabled>
64-
<button igxButton="fab" igxRipple="white" [disabled]="disabled">
64+
<button type="button" igxButton="fab" igxRipple="white" [disabled]="disabled">
6565
<igx-icon>add</igx-icon>
6666
</button>
6767
</ng-template>
@@ -73,7 +73,7 @@ The **IgxCarousel** supports templating indicators and navigation buttons
7373
<igx-carousel #carousel>
7474
...
7575
<ng-template igxCarouselPrevButton let-disabled>
76-
<button igxButton="fab" igxRipple="white" [disabled]="disabled">
76+
<button type="button" igxButton="fab" igxRipple="white" [disabled]="disabled">
7777
<igx-icon>remove</igx-icon>
7878
</button>
7979
</ng-template>

‎projects/igniteui-angular/src/lib/carousel/carousel.component.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,9 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
269269
* <igx-carousel #carousel>
270270
* ...
271271
* <ng-template igxCarouselNextButton let-disabled>
272-
* <button igxButton="fab" igxRipple="white" [disabled]="disabled">
273-
* <igx-icon>add</igx-icon>
274-
* </button>
272+
* <button type="button" igxButton="fab" igxRipple="white" [disabled]="disabled">
273+
* <igx-icon>add</igx-icon>
274+
* </button>
275275
* </ng-template>
276276
* </igx-carousel>
277277
* ```
@@ -292,9 +292,9 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
292292
* <igx-carousel #carousel>
293293
* ...
294294
* <ng-template igxCarouselPrevButton let-disabled>
295-
* <button igxButton="fab" igxRipple="white" [disabled]="disabled">
296-
* <igx-icon>remove</igx-icon>
297-
* </button>
295+
* <button type="button" igxButton="fab" igxRipple="white" [disabled]="disabled">
296+
* <igx-icon>remove</igx-icon>
297+
* </button>
298298
* </ng-template>
299299
* </igx-carousel>
300300
* ```

0 commit comments

Comments
 (0)