Skip to content

Commit a9fa356

Browse files
authored
Banner: Update the theme to reflect the latest designs in the UI kit (#14264)
1 parent 5f3dbea commit a9fa356

File tree

5 files changed

+27
-59
lines changed

5 files changed

+27
-59
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"@types/source-map": "0.5.2",
7171
"express": "^4.19.2",
7272
"fflate": "^0.8.1",
73-
"igniteui-theming": "^7.0.2",
73+
"igniteui-theming": "^7.1.0",
7474
"igniteui-trial-watermark": "^3.0.2",
7575
"lodash-es": "^4.17.21",
7676
"rxjs": "^7.8.0",
@@ -140,4 +140,4 @@
140140
"typedoc-plugin-localization": "^3.0.4",
141141
"typescript": "5.4.5"
142142
}
143-
}
143+
}

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"igniteui-trial-watermark": "^3.0.2",
7575
"lodash-es": "^4.17.21",
7676
"uuid": "^9.0.0",
77-
"igniteui-theming": "^7.0.2",
77+
"igniteui-theming": "^7.1.0",
7878
"@igniteui/material-icons-extended": "^3.0.0"
7979
},
8080
"peerDependencies": {

projects/igniteui-angular/src/lib/core/styles/components/banner/_banner-component.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@
3030
@extend %igx-banner__illustration !optional;
3131
}
3232

33-
@include e(border-top) {
34-
@extend %igx-banner__border-top !optional;
35-
}
36-
37-
@include e(border-bottom) {
38-
@extend %igx-banner__border-bottom !optional;
39-
}
40-
4133
@include e(text) {
4234
@extend %igx-banner__text !optional;
4335
}

projects/igniteui-angular/src/lib/core/styles/components/banner/_banner-theme.scss

Lines changed: 20 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
/// @param {Color} $banner-message-color [null] - The color used for the banner label.
1717
/// @param {Color} $banner-border-color [null] - The color used for the banner border.
1818
/// @param {Color} $banner-illustration-color [null] - The color used for the banner illustration.
19+
/// @param {Number} $border-radius [null] - The border-radius for the banner.
1920
///
2021
/// @requires $light-material-schema
2122
///
@@ -28,7 +29,8 @@
2829
$banner-background: null,
2930
$banner-message-color: null,
3031
$banner-border-color: null,
31-
$banner-illustration-color: null
32+
$banner-illustration-color: null,
33+
$border-radius: null,
3234
) {
3335
$name: 'igx-banner';
3436
$selector: 'igx-banner, .igx-banner';
@@ -54,6 +56,7 @@
5456
banner-message-color: $banner-message-color,
5557
banner-border-color: $banner-border-color,
5658
banner-illustration-color: $banner-illustration-color,
59+
border-radius: $border-radius,
5760
_meta: map.merge(if($meta, $meta, ()), (
5861
variant: map.get($schema, '_meta', 'theme')
5962
)),
@@ -96,48 +99,30 @@
9699
justify-content: flex-end;
97100
flex-wrap: wrap;
98101
gap: rem(8px);
99-
100-
padding-inline-start: pad-inline($padding-inline-start);
101-
padding-inline-end: pad-inline($padding);
102-
padding-block: pad-block($padding);
102+
padding: rem(8px);
103+
min-width: rem(320px);
103104
background: var-get($theme, 'banner-background');
104105

105106
@if $variant == 'indigo-design' {
106-
border: 1px solid var-get($theme, 'banner-border-color');
107+
box-shadow: inset 0 0 0 rem(1px) var-get($theme, 'banner-border-color');
107108
padding: rem(16px);
108-
border-radius: rem(6px);
109+
} @else {
110+
box-shadow: inset 0 rem(-1px) 0 0 var-get($theme, 'banner-border-color');
109111
}
110-
}
111-
112-
%igx-banner__illustration {
113-
justify-content: center;
114-
width: rem(40px);
115-
min-width: rem(40px);
116-
height: rem(40px);
117-
color: var-get($theme, 'banner-illustration-color');
118-
119-
@if $variant == 'indigo-design' {
120-
igx-icon {
121-
$icon-size: rem(16px);
122112

123-
--ig-icon-size: #{$icon-size};
124-
--igx-icon-size: #{$icon-size};
125-
}
113+
border-radius: var-get($theme, 'border-radius');
126114

127-
width: initial;
128-
height: initial;
129-
min-width: initial;
115+
igc-icon,
116+
igx-icon,
117+
igc-button,
118+
[igxButton] {
119+
--component-size: var(--ig-size, 2) !important;
130120
}
131121
}
132122

133-
%igx-banner__border-top {
134-
border-block-start: rem(1px) solid var-get($theme, 'banner-border-color');
135-
inset-block-start: rem(-1px);
136-
}
137-
138-
%igx-banner__border-bottom {
139-
border-block-end: rem(1px) solid var-get($theme, 'banner-border-color');
140-
inset-block-start: 0;
123+
%igx-banner__illustration {
124+
justify-content: center;
125+
color: var-get($theme, 'banner-illustration-color');
141126
}
142127

143128
%igx-banner__text {
@@ -156,25 +141,16 @@
156141

157142
@if $variant == 'indigo-design' {
158143
gap: rem(8px);
144+
} @else {
145+
padding: 0 rem(8px);
159146
}
160147
}
161148

162149
%igx-banner__actions,
163150
%igx-banner__actions > igx-banner-actions {
164151
flex-wrap: wrap;
165-
justify-content: flex-end;
166-
align-items: center;
167152
align-self: flex-end;
168153
gap: rem(8px);
169-
min-height: rem(40px);
170-
171-
@if $variant == 'indigo-design' {
172-
min-height: initial;
173-
174-
[igxButton] {
175-
--ig-size: 2;
176-
}
177-
}
178154
}
179155
}
180156

0 commit comments

Comments
 (0)