Skip to content

Commit aa19538

Browse files
wnvkoLipata
authored andcommitted
fix(grid): call notifyChanges in updateRow instead of detectChanges #5934 (#6018)
1 parent c9a1064 commit aa19538

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3839,7 +3839,13 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
38393839
}
38403840
const row = new IgxRow(rowSelector, -1, this.gridAPI.getRowData(rowSelector));
38413841
this.gridAPI.update_row(row, value);
3842-
this.cdr.detectChanges();
3842+
3843+
// TODO: fix for #5934 and probably break for #5763
3844+
// consider adding of third optional boolean parameter in updateRow.
3845+
// If developer set this parameter to true we should call notifyChanges(true), and
3846+
// vise-versa if developer set it to false we should call notifyChanges(false).
3847+
// The parameter should default to false
3848+
this.notifyChanges();
38433849
}
38443850
}
38453851

0 commit comments

Comments
 (0)