Skip to content

Commit ac8d9e4

Browse files
MKirovaMKirova
authored andcommitted
chore(*): Remove header group width pipe as it is not needed.
1 parent 7bc5d13 commit ac8d9e4

File tree

7 files changed

+17
-30
lines changed

7 files changed

+17
-30
lines changed

projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { IgxGridFilteringCellComponent } from '../filtering/base/grid-filtering-
2020
import { ColumnType, GridType, IGX_GRID_BASE } from '../common/grid.interface';
2121
import { GridSelectionMode } from '../common/enums';
2222
import { PlatformUtil } from '../../core/utils';
23-
import { IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe } from './pipes';
23+
import { IgxHeaderGroupStylePipe } from './pipes';
2424
import { IgxResizeHandleDirective } from '../resizing/resize-handle.directive';
2525
import { IgxIconComponent } from '../../icon/icon.component';
2626
import { IgxColumnMovingDropDirective } from '../moving/moving.drop.directive';

projects/igniteui-angular/src/lib/grids/headers/grid-header-row.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { IgxGridFilteringCellComponent } from '../filtering/base/grid-filtering-
1919
import { IgxGridFilteringRowComponent } from '../filtering/base/grid-filtering-row.component';
2020
import { IgxGridHeaderGroupComponent } from './grid-header-group.component';
2121
import { IgxGridHeaderComponent } from './grid-header.component';
22-
import { IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe } from './pipes';
22+
import { IgxHeaderGroupStylePipe } from './pipes';
2323
import { IgxGridTopLevelColumns } from '../common/pipes';
2424
import { IgxCheckboxComponent } from '../../checkbox/checkbox.component';
2525
import { IgxColumnMovingDropDirective } from '../moving/moving.drop.directive';

projects/igniteui-angular/src/lib/grids/headers/pipes.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,6 @@ export class SortingIndexPipe implements PipeTransform {
1414
}
1515
}
1616

17-
@Pipe({
18-
name: 'igxHeaderGroupWidth',
19-
standalone: true
20-
})
21-
export class IgxHeaderGroupWidthPipe implements PipeTransform {
22-
23-
public transform(width: any, hasLayout: boolean) {
24-
const isFitContent = width === 'fit-content';
25-
return hasLayout ? '' : isFitContent ? width : `${parseFloat(width)}px`;
26-
}
27-
}
28-
29-
3017
@Pipe({
3118
name: 'igxHeaderGroupStyle',
3219
standalone: true

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@
254254
<igx-pivot-row-header-group #rowDimensionHeaders
255255
[ngClass]="dimCol.headerGroupClasses"
256256
[ngStyle]="dimCol.headerGroupStyles | igxHeaderGroupStyle:dimCol:grid.pipeTrigger"
257-
[style.min-width]="grid.rowDimensionWidthToPixels(this.grid.visibleRowDimensions[colIndex]) | igxHeaderGroupWidth:hasMRL"
258-
[style.flex-basis]="grid.rowDimensionWidthToPixels(this.grid.visibleRowDimensions[colIndex]) | igxHeaderGroupWidth:hasMRL"
257+
[style.min-width]="grid.rowDimensionWidthToPixels(this.grid.visibleRowDimensions[colIndex])"
258+
[style.flex-basis]="grid.rowDimensionWidthToPixels(this.grid.visibleRowDimensions[colIndex])"
259259
[column]="dimCol"
260260
[rootDimension]="grid.visibleRowDimensions[colIndex]"
261261
[dimWidth]="grid.rowDimensionWidthToPixels(this.grid.visibleRowDimensions[colIndex])"
@@ -271,8 +271,8 @@
271271
@for (column of pinnedStartColumnCollection | igxTopLevel; track column) {
272272
<igx-grid-header-group [ngClass]="column.headerGroupClasses"
273273
[ngStyle]="column.headerGroupStyles | igxHeaderGroupStyle:column:grid.pipeTrigger" [column]="column"
274-
[style.min-width]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
275-
[style.flex-basis]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
274+
[style.min-width]="column.resolvedWidth"
275+
[style.flex-basis]="column.resolvedWidth"
276276
(pointerdown)="grid.navigation.focusOutRowHeader($event)">
277277
</igx-grid-header-group>
278278
}
@@ -287,8 +287,8 @@
287287
<igx-grid-header-group [ngClass]="column.headerGroupClasses"
288288
[style.height.px]="totalDepth > 1 ? calcHeight(column, i) : undefined"
289289
[ngStyle]="column.headerGroupStyles |igxHeaderGroupStyle:column:grid.pipeTrigger" [column]="column"
290-
[style.min-width]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
291-
[style.flex-basis]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
290+
[style.min-width]="column.resolvedWidth"
291+
[style.flex-basis]="column.resolvedWidth"
292292
[class.igx-grid__tr-pivot--columnDimensionLeaf]="isDuplicateOfExistingParent(column, i)"
293293
[class.igx-grid__tr-pivot--columnMultiRowSpan]="isMultiRow(column, i)"
294294
>
@@ -303,8 +303,8 @@
303303
@for (column of pinnedEndColumnCollection | igxTopLevel; track column) {
304304
<igx-grid-header-group [ngClass]="column.headerGroupClasses"
305305
[ngStyle]="column.headerGroupStyles |igxHeaderGroupStyle:column:grid.pipeTrigger" [column]="column"
306-
[style.min-width]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
307-
[style.flex-basis]="column.resolvedWidth | igxHeaderGroupWidth:hasMRL"
306+
[style.min-width]="column.resolvedWidth"
307+
[style.flex-basis]="column.resolvedWidth"
308308
[style.left]="column.rightPinnedOffset" (pointerdown)="grid.navigation.focusOutRowHeader($event)">
309309
</igx-grid-header-group>
310310
}

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { DropPosition } from '../moving/moving.service';
2626
import { IPivotAggregator, IPivotDimension, IPivotValue, PivotDimensionType } from './pivot-grid.interface';
2727
import { PivotUtil } from './pivot-util';
2828
import { IgxGridTopLevelColumns } from '../common/pipes';
29-
import { IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe } from '../headers/pipes';
29+
import { IgxHeaderGroupStylePipe } from '../headers/pipes';
3030
import { IgxExcelStyleSearchComponent } from '../filtering/excel-style/excel-style-search.component';
3131
import { IgxGridExcelStyleFilteringComponent, IgxExcelStyleColumnOperationsTemplateDirective, IgxExcelStyleFilterOperationsTemplateDirective } from '../filtering/excel-style/excel-style-filtering.component';
3232
import { IgxDropDownItemComponent } from '../../drop-down/drop-down-item.component';
@@ -56,7 +56,7 @@ import { IgxPivotRowHeaderGroupComponent } from './pivot-row-header-group.compon
5656
NgTemplateOutlet, IgxGridHeaderGroupComponent, NgClass, NgStyle, IgxGridForOfDirective,
5757
IgxDropDownComponent, IgxDropDownItemComponent, IgxGridExcelStyleFilteringComponent,
5858
IgxExcelStyleColumnOperationsTemplateDirective, IgxExcelStyleFilterOperationsTemplateDirective,
59-
IgxExcelStyleSearchComponent, IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe, IgxGridTopLevelColumns,
59+
IgxExcelStyleSearchComponent, IgxHeaderGroupStylePipe, IgxGridTopLevelColumns,
6060
IgxPivotRowHeaderGroupComponent]
6161
})
6262
export class IgxPivotHeaderRowComponent extends IgxGridHeaderRowComponent implements OnChanges {

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-row-dimension-content.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
<div class="igx-grid__tr igx-grid__tr-header-row" role="row" [style.width.px]="width">
44
<igx-pivot-row-dimension-header-group [ngClass]="rowDimensionColumn.headerGroupClasses"
55
[ngStyle]="rowDimensionColumn.headerGroupStyles | igxHeaderGroupStyle:rowDimensionColumn:grid.pipeTrigger" [column]="rowDimensionColumn"
6-
[style.min-width]="getHeaderWidthFromDimension() | igxHeaderGroupWidth:hasMRL"
7-
[style.width]="getHeaderWidthFromDimension() | igxHeaderGroupWidth:hasMRL"
8-
[style.flex-basis]="getHeaderWidthFromDimension() | igxHeaderGroupWidth:hasMRL"
6+
[style.min-width]="getHeaderWidthFromDimension()"
7+
[style.width]="getHeaderWidthFromDimension()"
8+
[style.flex-basis]="getHeaderWidthFromDimension()"
99
[rowIndex]="rowIndex"
1010
[colIndex]="colIndex"
1111
[layout]="layout"

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-row-dimension-content.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { IgxGridHeaderRowComponent } from '../headers/grid-header-row.component'
2323
import { IPivotDimension, IPivotDimensionData, IPivotGridGroupRecord } from './pivot-grid.interface';
2424
import { IgxPivotRowDimensionHeaderGroupComponent } from './pivot-row-dimension-header-group.component';
2525
import { PivotUtil } from './pivot-util';
26-
import { IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe } from '../headers/pipes';
26+
import { IgxHeaderGroupStylePipe } from '../headers/pipes';
2727
import { IgxIconComponent } from '../../icon/icon.component';
2828
import { NgClass, NgStyle } from '@angular/common';
2929
import { IMultiRowLayoutNode } from '../common/types';
@@ -40,7 +40,7 @@ import { IMultiRowLayoutNode } from '../common/types';
4040
changeDetection: ChangeDetectionStrategy.OnPush,
4141
selector: 'igx-pivot-row-dimension-content',
4242
templateUrl: './pivot-row-dimension-content.component.html',
43-
imports: [IgxPivotRowDimensionHeaderGroupComponent, NgClass, NgStyle, IgxIconComponent, IgxHeaderGroupWidthPipe, IgxHeaderGroupStylePipe]
43+
imports: [IgxPivotRowDimensionHeaderGroupComponent, NgClass, NgStyle, IgxIconComponent, IgxHeaderGroupStylePipe]
4444
})
4545
export class IgxPivotRowDimensionContentComponent extends IgxGridHeaderRowComponent implements OnChanges {
4646
@HostBinding('style.grid-row-start')

0 commit comments

Comments
 (0)