chore(*): Add custom migration logic for DropPosition.None.

Author: MKirova

projects/igniteui-angular/migrations/migration-collection.json

@@ -75,6 +75,11 @@
             "version": "9.1.0",
             "description": "Updates Ignite UI for Angular from v9.0.x to v9.1.0",
             "factory": "./update-9_1_0"
+        },
+        "migration-16": {
+            "version": "10.1.0",
+            "description": "Updates Ignite UI for Angular from v9.1.x to v10.1.0",
+            "factory": "./update-10_1_0"
         }
     }
 }

projects/igniteui-angular/migrations/update-10_1_0/index.spec.ts

@@ -0,0 +1,71 @@
+import * as path from 'path';
+
+// tslint:disable:no-implicit-dependencies
+import { virtualFs } from '@angular-devkit/core';
+import { EmptyTree } from '@angular-devkit/schematics';
+// tslint:disable-next-line:no-submodule-imports
+import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
+
+describe('Update 10.1.0', () => {
+    let appTree: UnitTestTree;
+    const schematicRunner = new SchematicTestRunner('ig-migrate', path.join(__dirname, '../migration-collection.json'));
+    const configJson = {
+        defaultProject: 'testProj',
+        projects: {
+            testProj: {
+                sourceRoot: '/testSrc'
+            }
+        },
+        schematics: {
+            '@schematics/angular:component': {
+                prefix: 'appPrefix'
+            }
+        }
+      };
+
+    beforeEach(() => {
+        appTree = new UnitTestTree(new EmptyTree());
+        appTree.create('/angular.json', JSON.stringify(configJson));
+    });
+
+    it('should update DropPosition.None', done => {
+        const origFileContent =
+            `import { Component, Injectable, ViewChild } from "@angular/core";` +
+            `import { IgxGridComponent, DropPosition } from "igniteui-angular";` +
+            `import { IgxColumnComponent } from "igniteui-angular";\r\n` +
+            `@Component({` +
+            `    providers: [RemoteService]` +
+            `})` +
+            `export class GridSampleComponent {` +
+            `    @ViewChild("grid1", { read: IgxGridComponent }) public grid1: IgxGridComponent;` +
+            `    public move() {` +
+            `        const column: IgxColumnComponent = this.grid1.columns[0];` +
+            `        const column2: IgxColumnComponent = this.grid1.columns[1];` +
+            `        this.grid1.moveColumn(col1, col2, DropPosition.None);` +
+            `    }` +
+            `}`;
+        const expectedFileContent =
+        `import { Component, Injectable, ViewChild } from "@angular/core";` +
+        `import { IgxGridComponent, DropPosition } from "igniteui-angular";` +
+        `import { IgxColumnComponent } from "igniteui-angular";\r\n` +
+        `@Component({` +
+        `    providers: [RemoteService]` +
+        `})` +
+        `export class GridSampleComponent {` +
+        `    @ViewChild("grid1", { read: IgxGridComponent }) public grid1: IgxGridComponent;` +
+        `    public move() {` +
+        `        const column: IgxColumnComponent = this.grid1.columns[0];` +
+        `        const column2: IgxColumnComponent = this.grid1.columns[1];` +
+        `        this.grid1.moveColumn(col1, col2, DropPosition.AfterDropTarget);` +
+        `    }` +
+        `}`;
+        appTree.create(
+            '/testSrc/appPrefix/component/drop.component.ts',
+            origFileContent);
+
+        const tree = schematicRunner.runSchematic('migration-16', {}, appTree);
+        expect(tree.readContent('/testSrc/appPrefix/component/drop.component.ts'))
+            .toEqual(expectedFileContent);
+        done();
+    });
+});

projects/igniteui-angular/migrations/update-10_1_0/index.ts

@@ -0,0 +1,35 @@
+import {
+    Rule,
+    SchematicContext,
+    Tree
+} from '@angular-devkit/schematics';
+import { UpdateChanges } from '../common/UpdateChanges';
+import {  getIdentifierPositions } from '../common/tsUtils';
+import * as ts from 'typescript';
+
+const version = '10.1.0';
+
+export default function(): Rule {
+    return (host: Tree, context: SchematicContext) => {
+        context.logger.info(`Applying migration for Ignite UI for Angular to version ${version}`);
+
+        const update = new UpdateChanges(__dirname, host, context);
+        // update.applyChanges();
+
+        // replace DropPosition.None with DropPosition.AfterDropTarget
+        for (const entryPath of update.tsFiles) {
+            let content = host.read(entryPath).toString();
+            if (content.indexOf('DropPosition.None') !== -1) {
+                const pos = getIdentifierPositions(content, 'DropPosition');
+                for (let i = pos.length; i--;) {
+                    const end = pos[i].end + 5;
+                    const isMatch = content.slice(pos[i].start, end) === 'DropPosition.None';
+                    if (isMatch) {
+                        content = content.slice(0, pos[i].start) + 'DropPosition.AfterDropTarget' + content.slice(end);
+                    }
+                }
+                host.overwrite(entryPath, content);
+            }
+        }
+    };
+}

projects/igniteui-angular/src/lib/grids/moving/moving.service.ts

@@ -2,7 +2,7 @@ import { Injectable } from '@angular/core';
 import { IgxColumnComponent } from '../columns/column.component';
 
 /**
- * This enumeration is used to configure whether the pinning position is set before or after
+ * This enumeration is used to configure whether the drop position is set before or after
  * the target.
  */
 export enum DropPosition {