Skip to content

Commit b12933f

Browse files
Merge branch '20.0.x' into rivanova/fix-15976-20.0.x
2 parents 8031d67 + 9953ebd commit b12933f

File tree

12 files changed

+135
-51
lines changed

12 files changed

+135
-51
lines changed

projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -299,20 +299,16 @@
299299
bottom: 0;
300300
}
301301

302-
igx-icon {
302+
igx-icon,
303+
igc-icon {
303304
justify-content: center;
304-
--component-size: 1;
305-
306-
@if $variant == 'fluent' {
307-
--component-size: 3;
308-
}
309305

310306
@if $variant == 'indigo' {
311307
$icon-size: sizable(rem(14px), rem(16px), rem(16px));
312308

313-
width: var(--ig-icon-size, $icon-size);
314-
height: var(--ig-icon-size, $icon-size);
315-
font-size: var(--ig-icon-size, $icon-size);
309+
--size: #{$icon-size};
310+
} @else {
311+
--component-size: 1;
316312
}
317313
}
318314
}

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,6 +1534,9 @@
15341534
}
15351535

15361536
%igx-grid__td--bool {
1537+
display: flex;
1538+
flex-grow: 1;
1539+
15371540
igx-icon {
15381541
--component-size: #{if($variant == 'indigo', 2, 1)};
15391542
}
@@ -2238,6 +2241,7 @@
22382241
%grid-cell-number {
22392242
text-align: $grid-cell-align-num;
22402243
justify-content: flex-end;
2244+
flex-grow: 1;
22412245

22422246
%grid-cell-header-icons {
22432247
justify-content: flex-start;

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6169,7 +6169,7 @@ export abstract class IgxGridBaseDirective implements GridType,
61696169
* @hidden @internal
61706170
*/
61716171
public trackColumnChanges(_index, col) {
6172-
return col.field + col._calcWidth;
6172+
return col.field + col._calcWidth.toString();
61736173
}
61746174

61756175
/**

projects/igniteui-angular/src/lib/grids/grid/expandable-cell.component.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<div
99
igxTextHighlight class="igx-grid__td-text"
1010
[cssClass]="highlightClass"
11+
[class.igx-grid__td--number]="column.dataType === 'number' || column.dataType === 'percent' || column.dataType === 'currency'"
1112
[activeCssClass]="activeHighlightClass"
1213
[groupName]="gridID"
1314
[value]="formatter ? (value | columnFormatter:formatter:rowData)
@@ -32,11 +33,13 @@
3233
}
3334

3435
@if (column.dataType === 'boolean' && !this.formatter) {
36+
<div [class.igx-grid__td--bool]="column.dataType === 'boolean'">
3537
<igx-icon
3638
family="default"
3739
[name]="value ? 'confirm' : 'close'"
3840
[ngClass]="{ 'igx-icon--success': value, 'igx-icon--error': !value }">
3941
</igx-icon>
42+
</div>
4043
}
4144
@if (column.dataType === 'image') {
4245
<img [src]="value" [alt]="value | igxCellImageAlt" />

projects/igniteui-angular/src/lib/grids/grid/grid-validation.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class IgxGridValidationService {
3636
owner: this.grid
3737
};
3838
this.grid.formGroupCreated.emit(args);
39+
formGroup.patchValue(data);
3940
this.add(rowId, formGroup);
4041
} else {
4142
// reset to pristine.

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-data-selector.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import { IgxIconComponent } from "../../icon/icon.component";
4747
import { IgxInputGroupComponent } from "../../input-group/input-group.component";
4848
import { fadeIn, fadeOut } from 'igniteui-angular/animations';
4949
import { Size } from '../common/enums';
50+
import { GridColumnDataType } from '../../data-operations/data-util';
5051

5152
interface IDataSelectorPanel {
5253
name: string;
@@ -541,8 +542,13 @@ export class IgxPivotDataSelectorComponent {
541542
* @internal
542543
*/
543544
public onAggregationChange(event: ISelectionEventArgs) {
545+
544546
if (!this.isSelected(event.newSelection.value)) {
545547
this.value.aggregate = event.newSelection.value;
548+
const isSingleValue = this.grid.values.length === 1;
549+
550+
PivotUtil.updateColumnTypeByAggregator(this.grid.columns, this.value, isSingleValue);
551+
546552
this.grid.pipeTrigger++;
547553
this.grid.cdr.markForCheck();
548554
}

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts

Lines changed: 38 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ import {
3232
} from '@angular/core';
3333
import { NgTemplateOutlet, NgClass, NgStyle } from '@angular/common';
3434

35-
import { first, take, takeUntil} from 'rxjs/operators';
35+
import { first, take, takeUntil } from 'rxjs/operators';
3636
import { IgxGridBaseDirective } from '../grid-base.directive';
3737
import { IgxFilteringService } from '../filtering/grid-filtering.service';
3838
import { IgxGridSelectionService } from '../selection/selection.service';
3939
import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service';
40-
import { ColumnType, GridType, IGX_GRID_BASE, IGX_GRID_SERVICE_BASE, IgxColumnTemplateContext, RowType } from '../common/grid.interface';
40+
import { ColumnType, GridType, IGX_GRID_BASE, IGX_GRID_SERVICE_BASE, IgxColumnTemplateContext, PivotGridType, RowType } from '../common/grid.interface';
4141
import { IgxGridCRUDService } from '../common/crud.service';
4242
import { IgxGridSummaryService } from '../summaries/grid-summary.service';
4343
import { DEFAULT_PIVOT_KEYS, IDimensionsChange, IgxPivotGridValueTemplateContext, IPivotConfiguration, IPivotConfigurationChangedEventArgs, IPivotDimension, IPivotValue, IValuesChange, PivotDimensionType, IPivotUISettings, PivotRowLayoutType, PivotSummaryPosition } from './pivot-grid.interface';
@@ -72,7 +72,7 @@ import { IgxPivotColumnResizingService } from '../resizing/pivot-grid/pivot-resi
7272
import { IgxFlatTransactionFactory, IgxOverlayService, State, Transaction, TransactionService } from '../../services/public_api';
7373
import { cloneArray, PlatformUtil, resizeObservable } from '../../core/utils';
7474
import { IgxPivotFilteringService } from './pivot-filtering.service';
75-
import { DataUtil } from '../../data-operations/data-util';
75+
import { DataUtil, GridColumnDataType } from '../../data-operations/data-util';
7676
import { IFilteringExpressionsTree } from '../../data-operations/filtering-expressions-tree';
7777
import { IgxGridTransaction } from '../common/types';
7878
import { GridBaseAPIService } from '../api.service';
@@ -199,7 +199,7 @@ const MINIMUM_COLUMN_WIDTH_SUPER_COMPACT = 104;
199199
schemas: [CUSTOM_ELEMENTS_SCHEMA]
200200
})
201201
export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnInit, AfterContentInit,
202-
GridType, AfterViewInit, OnChanges {
202+
PivotGridType, AfterViewInit, OnChanges {
203203

204204
/**
205205
* Emitted when the dimension collection is changed via the grid chip area.
@@ -1667,7 +1667,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
16671667
public autoSizeRowDimension(dimension: IPivotDimension) {
16681668
if (this.getDimensionType(dimension) === PivotDimensionType.Row) {
16691669
const relatedDims: string[] = PivotUtil.flatten([dimension]).map((x: IPivotDimension) => x.memberName);
1670-
const contentCollection = this.getContentCollection(dimension);
1670+
const contentCollection = this.getContentCollection(dimension);
16711671
const content = contentCollection.filter(x => relatedDims.indexOf(x.dimension.memberName) !== -1);
16721672
const headers = content.map(x => x.headerGroups.toArray()).flat().map(x => x.header && x.header.refInstance);
16731673
if (this.pivotUI.showRowHeaders) {
@@ -1941,8 +1941,8 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
19411941
*/
19421942
public getRowDimensionByName(memberName: string) {
19431943
const visibleRows = this.pivotUI.rowLayout === PivotRowLayoutType.Vertical ?
1944-
this.pivotConfiguration.rows :
1945-
PivotUtil.flatten(this.pivotConfiguration.rows);
1944+
this.pivotConfiguration.rows :
1945+
PivotUtil.flatten(this.pivotConfiguration.rows);
19461946
const dimIndex = visibleRows.findIndex((target) => target.memberName === memberName);
19471947
const dim = visibleRows[dimIndex];
19481948
return dim;
@@ -2266,7 +2266,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
22662266
const separator = this.pivotKeys.columnDimensionSeparator;
22672267
const dataArr = fields.map(x => x.split(separator)).sort(x => x.length);
22682268
const hierarchy = new Map<string, any>();
2269-
const columnDimensions = PivotUtil.flatten(this.columnDimensions);
2269+
const columnDimensions = PivotUtil.flatten(this.columnDimensions);
22702270
dataArr.forEach(arr => {
22712271
let currentHierarchy = hierarchy;
22722272
const path = [];
@@ -2286,17 +2286,22 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
22862286
});
22872287
return hierarchy;
22882288
}
2289-
22902289
protected generateColumnHierarchy(fields: Map<string, any>, data, parent = null): IgxColumnComponent[] {
22912290
let columns = [];
22922291
if (fields.size === 0) {
22932292
this.values.forEach((value) => {
22942293
const ref = createComponent(IgxColumnComponent, { environmentInjector: this.envInjector, elementInjector: this.injector });
2294+
let columnDataType = value.dataType || this.resolveDataTypes(data.length ? data[0][value.member] : null);
2295+
2296+
if (value.aggregate?.key?.toLowerCase() === 'count' && (columnDataType === GridColumnDataType.Currency || columnDataType == GridColumnDataType.Percent)) {
2297+
columnDataType = GridColumnDataType.Number;
2298+
}
2299+
22952300
ref.instance.header = value.displayName;
22962301
ref.instance.field = value.member;
22972302
ref.instance.parent = parent;
22982303
ref.instance.sortable = true;
2299-
ref.instance.dataType = value.dataType || this.resolveDataTypes(data.length ? data[0][value.member] : null);
2304+
ref.instance.dataType = columnDataType;
23002305
ref.instance.formatter = value.formatter;
23012306
columns.push(ref.instance);
23022307
});
@@ -2310,9 +2315,20 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
23102315
}
23112316
if (shouldGenerate && (value.children == null || value.children.length === 0 || value.children.size === 0)) {
23122317
const col = this.createColumnForDimension(value, data, parent, this.hasMultipleValues);
2318+
2319+
if (!this.hasMultipleValues && this.values.length > 0) {
2320+
PivotUtil.updateColumnTypeByAggregator([col], this.values[0], true);
2321+
}
2322+
23132323
columns.push(col);
23142324
if (this.hasMultipleValues) {
23152325
const measureChildren = this.getMeasureChildren(data, col, false, value.dimension.width);
2326+
2327+
measureChildren.forEach((child, index) => {
2328+
const pivotValue = this.values[index];
2329+
PivotUtil.updateColumnTypeByAggregator([child], pivotValue, this.values.length === 1);
2330+
});
2331+
23162332
col.children.reset(measureChildren);
23172333
columns = columns.concat(measureChildren);
23182334
}
@@ -2382,20 +2398,20 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
23822398
};
23832399
values.push(value);
23842400
break;
2385-
}
2386-
case "date":
2387-
{
2388-
const dimension: IPivotDimension = new IgxPivotDateDimension(
2401+
}
2402+
case "date":
23892403
{
2390-
memberName: field,
2391-
enabled: isFirstDate,
2392-
dataType: dataType
2404+
const dimension: IPivotDimension = new IgxPivotDateDimension(
2405+
{
2406+
memberName: field,
2407+
enabled: isFirstDate,
2408+
dataType: dataType
2409+
}
2410+
)
2411+
rowDimensions.push(dimension);
2412+
isFirstDate = false;
2413+
break;
23932414
}
2394-
)
2395-
rowDimensions.push(dimension);
2396-
isFirstDate = false;
2397-
break;
2398-
}
23992415
default: {
24002416
const dimension: IPivotDimension = {
24012417
memberName: field,

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import { IgxDropDirective } from '../../directives/drag-drop/drag-drop.directive
3838
import { NgTemplateOutlet, NgClass, NgStyle } from '@angular/common';
3939
import { IgxPivotRowHeaderGroupComponent } from './pivot-row-header-group.component';
4040
import { IgxPivotRowDimensionHeaderGroupComponent } from './pivot-row-dimension-header-group.component';
41+
import { GridColumnDataType } from '../../data-operations/data-util';
4142

4243
/**
4344
*
@@ -137,7 +138,7 @@ export class IgxPivotHeaderRowComponent extends IgxGridHeaderRowComponent implem
137138
@Inject(IGX_GRID_BASE) public override grid: PivotGridType,
138139
ref: ElementRef<HTMLElement>,
139140
cdr: ChangeDetectorRef,
140-
protected renderer: Renderer2,
141+
protected renderer: Renderer2
141142
) {
142143
super(ref, cdr);
143144
}
@@ -407,8 +408,13 @@ export class IgxPivotHeaderRowComponent extends IgxGridHeaderRowComponent implem
407408
* @internal
408409
*/
409410
public onAggregationChange(event: ISelectionEventArgs) {
411+
410412
if (!this.isSelected(event.newSelection.value)) {
411413
this.value.aggregate = event.newSelection.value;
414+
const isSingleValue = this.grid.values.length === 1;
415+
416+
PivotUtil.updateColumnTypeByAggregator(this.grid.columns, this.value, isSingleValue);
417+
412418
this.grid.pipeTrigger++;
413419
}
414420
}

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-util.ts

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { DataUtil, GridColumnDataType } from '../../data-operations/data-util';
33
import { FilteringLogic } from '../../data-operations/filtering-expression.interface';
44
import { FilteringExpressionsTree } from '../../data-operations/filtering-expressions-tree';
55
import { ISortingExpression } from '../../data-operations/sorting-strategy';
6-
import { PivotGridType } from '../common/grid.interface';
6+
import { ColumnType, PivotGridType } from '../common/grid.interface';
77
import { IGridSortingStrategy, IgxSorting } from '../common/strategy';
88
import { IgxPivotAggregate, IgxPivotDateAggregate, IgxPivotNumericAggregate, IgxPivotTimeAggregate } from './pivot-grid-aggregate';
99
import { IPivotAggregator, IPivotConfiguration, IPivotDimension, IPivotGridRecord, IPivotKeys, IPivotValue, PivotDimensionType, PivotSummaryPosition } from './pivot-grid.interface';
@@ -88,13 +88,13 @@ export class PivotUtil {
8888
}
8989

9090
public static flattenGroupsHorizontally(data: IPivotGridRecord[],
91-
dimension: IPivotDimension,
92-
expansionStates,
93-
defaultExpand: boolean,
94-
visibleDimensions: IPivotDimension[],
95-
summariesPosition: PivotSummaryPosition,
96-
parent?: IPivotDimension,
97-
parentRec?: IPivotGridRecord) {
91+
dimension: IPivotDimension,
92+
expansionStates,
93+
defaultExpand: boolean,
94+
visibleDimensions: IPivotDimension[],
95+
summariesPosition: PivotSummaryPosition,
96+
parent?: IPivotDimension,
97+
parentRec?: IPivotGridRecord) {
9898
for (let i = 0; i < data.length; i++) {
9999
const rec = data[i];
100100
const field = dimension.memberName;
@@ -316,7 +316,7 @@ export class PivotUtil {
316316
const aggregationKey = groupName ? groupName + pivotKeys.columnDimensionSeparator + key : key;
317317
rec.aggregationValues.set(aggregationKey, aggregationData[key]);
318318
});
319-
} else if (aggregationKeys.length === 1) {
319+
} else if (aggregationKeys.length === 1) {
320320
const aggregationKey = aggregationKeys[0];
321321
rec.aggregationValues.set(groupName || aggregationKey, aggregationData[aggregationKey]);
322322
}
@@ -508,5 +508,24 @@ export class PivotUtil {
508508
}
509509
}
510510

511+
public static updateColumnTypeByAggregator(columns: any[], value: IPivotValue, isSingleValue: boolean): void {
512+
const targetColumnType = PivotUtil.getColumnDataTypeForValue(value);
513+
columns.forEach(column => {
514+
if ((column.field?.includes(value.member) || isSingleValue) && targetColumnType !== undefined) {
515+
column.dataType = targetColumnType;
516+
}
517+
})
518+
}
519+
520+
private static getColumnDataTypeForValue(value: IPivotValue): GridColumnDataType {
521+
const isCountAggregator = value.aggregate.aggregator?.name?.toLowerCase() === 'count' || value.aggregate.aggregatorName?.toLowerCase() === 'count';
511522

523+
if ((value.dataType === GridColumnDataType.Currency || value.dataType === GridColumnDataType.Percent) && isCountAggregator) {
524+
return GridColumnDataType.Number;
525+
} else if (value.dataType === GridColumnDataType.Currency && !isCountAggregator) {
526+
return GridColumnDataType.Currency;
527+
} else if (value.dataType === GridColumnDataType.Percent && !isCountAggregator) {
528+
return GridColumnDataType.Percent;
529+
}
530+
}
512531
}

projects/igniteui-angular/src/lib/splitter/splitter-pane/splitter-pane.component.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, HostBinding, Input, ElementRef, Output, EventEmitter, booleanAttribute } from '@angular/core';
1+
import { Component, HostBinding, Input, ElementRef, Output, EventEmitter, booleanAttribute, signal } from '@angular/core';
22

33
/**
44
* Represents individual resizable/collapsible panes.
@@ -22,6 +22,7 @@ import { Component, HostBinding, Input, ElementRef, Output, EventEmitter, boolea
2222
export class IgxSplitterPaneComponent {
2323
private _minSize: string;
2424
private _maxSize: string;
25+
private _order = signal<number | null>(null);
2526

2627
/**
2728
* @hidden @internal
@@ -102,7 +103,12 @@ export class IgxSplitterPaneComponent {
102103

103104
/** @hidden @internal */
104105
@HostBinding('style.order')
105-
public order!: number;
106+
public get order() {
107+
return this._order();
108+
}
109+
public set order(val) {
110+
this._order.set(val)
111+
}
106112

107113
/**
108114
* @hidden @internal

0 commit comments

Comments
 (0)