Skip to content

Commit b1424af

Browse files
committed
fix(adv-filtering): column header moved to ExpressionOperandItem #5993
(cherry picked from commit 374a909)
1 parent c5bfffd commit b1424af

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

projects/igniteui-angular/src/lib/data-operations/filtering-expression.interface.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export enum FilteringLogic {
1010
*/
1111
export declare interface IFilteringExpression {
1212
fieldName: string;
13-
headerName?: string;
1413
condition: IFilteringOperation;
1514
searchVal?: any;
1615
ignoreCase?: boolean;

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ <h6 class="igx-filter-empty__title">
9999
(onRemove)="onChipRemove(expressionItem)"
100100
(onSelectionDone)="onChipSelectionEnd()"
101101
>
102-
<span igxPrefix class="igx-filter-tree__expression-column">{{ expressionItem.expression.headerName || expressionItem.expression.fieldName }}</span>
102+
<span igxPrefix class="igx-filter-tree__expression-column">{{ expressionItem.columnHeader || expressionItem.expression.fieldName }}</span>
103103
<igx-icon
104104
igxPrefix
105105
fontSet="filtering-icons"

projects/igniteui-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class ExpressionOperandItem extends ExpressionItem {
5656
inEditMode: boolean;
5757
inAddMode: boolean;
5858
hovered: boolean;
59+
columnHeader: string;
5960
}
6061

6162
/**
@@ -468,9 +469,9 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
468469
public commitOperandEdit() {
469470
if (this.editedExpression) {
470471
this.editedExpression.expression.fieldName = this.selectedColumn.field;
471-
this.editedExpression.expression.headerName = this.selectedColumn.header;
472472
this.editedExpression.expression.condition = this.selectedColumn.filters.condition(this.selectedCondition);
473473
this.editedExpression.expression.searchVal = DataUtil.parseValue(this.selectedColumn.dataType, this.searchValue);
474+
this.editedExpression.columnHeader = this.selectedColumn.header;
474475

475476
this.editedExpression.inEditMode = false;
476477
this.editedExpression = null;
@@ -564,12 +565,13 @@ export class IgxAdvancedFilteringDialogComponent implements AfterViewInit, OnDes
564565
const filteringExpr = expr as IFilteringExpression;
565566
const exprCopy: IFilteringExpression = {
566567
fieldName: filteringExpr.fieldName,
567-
headerName: filteringExpr.headerName,
568568
condition: filteringExpr.condition,
569569
searchVal: filteringExpr.searchVal,
570570
ignoreCase: filteringExpr.ignoreCase
571571
};
572572
const operandItem = new ExpressionOperandItem(exprCopy, groupItem);
573+
const column = this.grid.getColumnByName(filteringExpr.fieldName);
574+
operandItem.columnHeader = column.header;
573575
groupItem.children.push(operandItem);
574576
}
575577
}

0 commit comments

Comments
 (0)