fix: tighten grader checks per review feedback

- Combo import check now specifically requires the entry-point import
  (igniteui-angular/combo) and rejects root barrel imports
- Theming grader now enforces core() must appear before theme() by
  comparing line numbers
- README updated to match actual grader behavior (no build step)

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

Author: Copilot

evals/README.md

@@ -79,9 +79,10 @@ npm run validate:theming       # theming-palette-generation only
 2. Write a clear, unambiguous `instruction.md` that tells the agent exactly what
    to build.
 
-3. Write `tests/test.sh` to check **outcomes** (files exist, project compiles,
-   correct selectors are present) rather than specific steps. The grader must
-   write a reward (0.0–1.0) to `logs/verifier/reward.txt`.
+3. Write `tests/test.sh` to check **outcomes** (files exist, correct selectors
+   and entry-point imports are present, correct API call ordering) rather than
+   specific steps. The grader must write a reward (0.0–1.0) to
+   `logs/verifier/reward.txt`.
 
 4. Write `prompts/quality.md` with rubric dimensions that sum to 1.0.
 
@@ -117,10 +118,11 @@ automatically on PRs that modify `skills/**` or `evals/**`. It:
 ## Grading Strategy
 
 **Deterministic grader (60% weight)** — checks:
-- Project builds without errors
+- Expected component files exist
 - Correct Ignite UI selector is present in the generated template
-- Required imports exist
+- Required entry-point imports exist (not root barrel)
 - No use of forbidden alternatives
+- Correct API call ordering (e.g. `core()` before `theme()`)
 
 **LLM rubric grader (40% weight)** — evaluates:
 - Correct intent routing

evals/tasks/component-combo-reactive-form/tests/test.sh

@@ -73,19 +73,21 @@ else
   DETAILS="${DETAILS}FAIL: Forbidden alternative (native select, mat-select, igx-select) detected\n"
 fi
 
-# --- Check 5: Correct import from igniteui-angular ---
+# --- Check 5: Correct entry-point import from igniteui-angular/combo ---
+# The skill requires entry-point imports (not the root barrel).
+COMBO_IMPORT_PATTERN="from ['\"](@infragistics/)?igniteui-angular/combo['\"]"
 IMPORT_FOUND=0
 if [ -n "${COMPONENT_FILE:-}" ]; then
-  if grep -qE "from ['\"]igniteui-angular|from ['\"]@infragistics/igniteui-angular" "$COMPONENT_FILE" 2>/dev/null; then
+  if grep -qE "$COMBO_IMPORT_PATTERN" "$COMPONENT_FILE" 2>/dev/null; then
     IMPORT_FOUND=1
   fi
 fi
 
 if [ "$IMPORT_FOUND" -eq 1 ]; then
   SCORE=$((SCORE + 1))
-  DETAILS="${DETAILS}PASS: igniteui-angular import found\n"
+  DETAILS="${DETAILS}PASS: Correct combo entry-point import found\n"
 else
-  DETAILS="${DETAILS}FAIL: No igniteui-angular import found\n"
+  DETAILS="${DETAILS}FAIL: Missing import from igniteui-angular/combo entry point\n"
 fi
 
 # --- Calculate reward ---

evals/tasks/theming-palette-generation/tests/test.sh

@@ -50,12 +50,17 @@ else
   DETAILS="${DETAILS}FAIL: No theme() mixin call found\n"
 fi
 
-# --- Check 4: core() mixin call (must be before theme) ---
-if grep -qE '@include.*core\(' "$STYLES_FILE" 2>/dev/null; then
-  SCORE=$((SCORE + 1))
-  DETAILS="${DETAILS}PASS: core() mixin call found\n"
-else
+# --- Check 4: core() mixin call must appear before theme() ---
+CORE_LINE=$(grep -nE '@include.*core\(' "$STYLES_FILE" 2>/dev/null | head -1 | cut -d: -f1)
+THEME_LINE=$(grep -nE '@include.*theme\(' "$STYLES_FILE" 2>/dev/null | head -1 | cut -d: -f1)
+
+if [ -z "${CORE_LINE:-}" ]; then
   DETAILS="${DETAILS}FAIL: No core() mixin call found\n"
+elif [ -n "${THEME_LINE:-}" ] && [ "$CORE_LINE" -gt "$THEME_LINE" ]; then
+  DETAILS="${DETAILS}FAIL: core() must be called before theme() (core on line $CORE_LINE, theme on line $THEME_LINE)\n"
+else
+  SCORE=$((SCORE + 1))
+  DETAILS="${DETAILS}PASS: core() mixin call found before theme()\n"
 fi
 
 # --- Check 5: No hardcoded CSS custom properties as the sole theming approach ---