Skip to content

Commit b2ff7ff

Browse files
Copilotdamyanpetev
andcommitted
refactor: improve comments to clarify assertions and checks
- Add comment explaining non-null assertions are safe due to namedImportFilter validation - Clarify the quick check is for base imports (not subpaths) Co-authored-by: damyanpetev <[email protected]>
1 parent 00b00e1 commit b2ff7ff

File tree

1 file changed

+2
-1
lines changed
  • projects/igniteui-angular/migrations/update-21_0_0_import-migration

1 file changed

+2
-1
lines changed

projects/igniteui-angular/migrations/update-21_0_0_import-migration/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -724,6 +724,7 @@ function migrateImportDeclaration(node: ts.ImportDeclaration, sourceFile: ts.Sou
724724
return null;
725725
}
726726

727+
// namedImportFilter already validates importClause and namedBindings exist with NamedImports type
727728
const importClause = node.importClause!;
728729
const namedBindings = importClause.namedBindings as ts.NamedImports;
729730

@@ -872,7 +873,7 @@ export default function migrate(): Rule {
872873

873874
const originalContent = content.toString();
874875

875-
// Check if file has igniteui-angular imports
876+
// Quick check if file has base igniteui-angular imports (not using entry point subpaths)
876877
if (!originalContent.includes(`from '${IG_PACKAGE_NAME}'`) && !originalContent.includes(`from "${IG_PACKAGE_NAME}"`) &&
877878
!originalContent.includes(`from '${IG_LICENSED_PACKAGE_NAME}'`) && !originalContent.includes(`from "${IG_LICENSED_PACKAGE_NAME}"`)) {
878879
return;

0 commit comments

Comments
 (0)