Skip to content

Commit b3995d5

Browse files
authored
Merge branch 'master' into pbozhinov/fix-9073
2 parents 7686a91 + 34b8a6e commit b3995d5

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

projects/igniteui-angular/src/lib/radio/radio.component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,9 +349,11 @@ export class IgxRadioComponent implements ControlValueAccessor, EditorProvider {
349349
this.nativeRadio.nativeElement.blur();
350350
}
351351

352-
this.checked = true;
353-
this.change.emit({ value: this.value, radio: this });
354-
this._onChangeCallback(this.value);
352+
if(!this.checked) {
353+
this.checked = true;
354+
this.change.emit({ value: this.value, radio: this });
355+
this._onChangeCallback(this.value);
356+
}
355357
}
356358

357359
/**

src/app/input/input.sample.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ <h4 class="sample-title">Checkbox sample</h4>
118118
<article class="sample-column">
119119
<h4 class="sample-title">Radio w/ ngModel</h4>
120120

121-
<igx-radio [ngModel]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option1">Option 1</igx-radio>
122-
<igx-radio [ngModel]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option2">Option 2</igx-radio>
123-
<igx-radio [ngModel]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option3" disabled="true">Option 3</igx-radio>
121+
<igx-radio [(ngModel)]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option1">Option 1</igx-radio>
122+
<igx-radio [(ngModel)]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option2">Option 2</igx-radio>
123+
<igx-radio [(ngModel)]="selected" (ngModelChange)="onChange($event)" (change)="onRadioChanged($event)" value="option3" disabled="true">Option 3</igx-radio>
124124
<br>
125125
<button igxButton="raised" (click)="selectSecond()">Select second</button>
126126
</article>

src/app/input/input.sample.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
import { Component } from '@angular/core';
1+
import { Component, ChangeDetectionStrategy } from '@angular/core';
22
import { IChangeRadioEventArgs } from 'igniteui-angular';
33

44
@Component({
5+
changeDetection: ChangeDetectionStrategy.OnPush,
56
selector: 'app-input-sample',
67
styleUrls: ['input.sample.css'],
78
templateUrl: 'input.sample.html'
89
})
910
export class InputSampleComponent {
1011
public placeholder = 'Please enter a value';
11-
public selected: string;
12+
public selected = 'option1';
1213

1314
public user = {
1415
comment: '',
@@ -53,10 +54,7 @@ export class InputSampleComponent {
5354
}
5455

5556
public onChange(value: string) {
56-
if(this.selected !== value) {
57-
console.log('changed radio selection');
58-
this.selected = value;
59-
}
57+
console.log(value);
6058
}
6159

6260
public onRadioChanged(event: IChangeRadioEventArgs) {

0 commit comments

Comments
 (0)