Skip to content

Commit b74de69

Browse files
authored
Merge pull request #6185 from IgniteUI/fix-5973
feat(slider): Fix slider position inside grid cell
2 parents 5ff6a66 + e1479a4 commit b74de69

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

projects/igniteui-angular/src/lib/core/styles/components/slider/_slider-theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@
128128
display: flex;
129129
position: relative;
130130
height: rem($slider-height);
131+
flex-grow: 1;
131132
align-items: center;
132133
transition: all .2s $ease-out-quad;
133134

projects/igniteui-angular/src/lib/slider/slider.component.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,6 +638,7 @@ describe('IgxSlider', () => {
638638
it('tick marks(steps) should be shown equally spread based on labels length', () => {
639639
const ticks = fixture.nativeElement.querySelector('.igx-slider__track-ticks');
640640
const sliderWidth = parseInt(fixture.nativeElement.querySelector('igx-slider').clientWidth, 10);
641+
fixture.detectChanges();
641642

642643
expect(slider.type).toBe(SliderType.SLIDER);
643644
expect(ticks).toBeDefined();
@@ -922,6 +923,7 @@ describe('IgxSlider', () => {
922923
it('tick marks(steps) should be shown equally spread based on labels length', () => {
923924
const ticks = fixture.nativeElement.querySelector('.igx-slider__track-ticks');
924925
const sliderWidth = parseInt(fixture.nativeElement.querySelector('igx-slider').clientWidth, 10);
926+
fixture.detectChanges();
925927

926928
expect(slider.type).toBe(SliderType.RANGE);
927929
expect(ticks).not.toBeNull();

projects/igniteui-angular/src/lib/slider/slider.component.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,7 @@ let NEXT_ID = 0;
5151
@Component({
5252
providers: [{ provide: NG_VALUE_ACCESSOR, useExisting: IgxSliderComponent, multi: true }],
5353
selector: 'igx-slider',
54-
templateUrl: 'slider.component.html',
55-
styles: [`
56-
:host {
57-
display: block;
58-
}
59-
`]
54+
templateUrl: 'slider.component.html'
6055
})
6156
export class IgxSliderComponent implements
6257
ControlValueAccessor,

0 commit comments

Comments
 (0)