Skip to content

Commit b9c99f2

Browse files
Copilotkdinev
andcommitted
Fix failing tests - remove non-existent exportStarted event tests
Removed tests that referenced the non-existent exportStarted event on IgxPdfExporterService. The base exporter only has exportEnded event, not exportStarted. This matches the pattern used by Excel and CSV exporters. Fixed tests in: - pdf-exporter.spec.ts: Removed exportStarted event test - pdf-exporter-grid.spec.ts: Removed exportStarted event test for grid export Note: The grid-toolbar-exporter component still has its own exportStarted output event which is correct and those tests remain unchanged. Co-authored-by: kdinev <[email protected]>
1 parent decbc79 commit b9c99f2

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

projects/igniteui-angular/src/lib/services/pdf/pdf-exporter-grid.spec.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -196,24 +196,7 @@ describe('PDF Grid Exporter', () => {
196196
exporter.export(grid, options);
197197
});
198198

199-
it('should emit exportStarted event when exporting grid', (done) => {
200-
const fix = TestBed.createComponent(GridIDNameJobTitleComponent);
201-
fix.detectChanges();
202-
203-
const grid = fix.componentInstance.grid;
204-
let exportStartedFired = false;
205-
206-
exporter.exportStarted.pipe(first()).subscribe(() => {
207-
exportStartedFired = true;
208-
});
209-
210-
exporter.exportEnded.pipe(first()).subscribe(() => {
211-
expect(exportStartedFired).toBe(true);
212-
done();
213-
});
214199

215-
exporter.export(grid, options);
216-
});
217200

218201
it('should handle grid with multiple columns', (done) => {
219202
const fix = TestBed.createComponent(GridIDNameJobTitleComponent);

projects/igniteui-angular/src/lib/services/pdf/pdf-exporter.spec.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -236,20 +236,7 @@ describe('PDF Exporter', () => {
236236
exporter.exportData(dataWithEmptyRows, options);
237237
});
238238

239-
it('should emit exportStarted event', (done) => {
240-
let exportStartedFired = false;
241239

242-
exporter.exportStarted.pipe(first()).subscribe(() => {
243-
exportStartedFired = true;
244-
});
245-
246-
exporter.exportEnded.pipe(first()).subscribe(() => {
247-
expect(exportStartedFired).toBe(true);
248-
done();
249-
});
250-
251-
exporter.exportData(SampleTestData.contactsData(), options);
252-
});
253240

254241
it('should emit exportEnded event with pdf object', (done) => {
255242
exporter.exportEnded.pipe(first()).subscribe((args) => {

0 commit comments

Comments
 (0)