Skip to content

Commit ba83c78

Browse files
committed
fix(column-group): remove filter/sort expr by column
remove filter/sort expressions by column-group without recursive iteration Closes #5393
1 parent 8dec58c commit ba83c78

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.component.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4286,9 +4286,7 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
42864286

42874287
diff.forEachRemovedItem((record: IterableChangeRecord<IgxColumnComponent | IgxColumnGroupComponent>) => {
42884288
const isColumnGroup = record.item instanceof IgxColumnGroupComponent;
4289-
if (isColumnGroup) {
4290-
this.clearSortingAndFilteringRecursively(record.item);
4291-
} else {
4289+
if (!isColumnGroup) {
42924290
// Clear Filtering
42934291
this.gridAPI.clear_filter(record.item.field);
42944292

@@ -5106,19 +5104,6 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements
51065104
return false;
51075105
}
51085106

5109-
private clearSortingAndFilteringRecursively(column: IgxColumnGroupComponent | IgxColumnComponent) {
5110-
const isColumnGroup = column instanceof IgxColumnGroupComponent;
5111-
if (isColumnGroup) {
5112-
const columnChildren = column.children;
5113-
columnChildren.forEach((col: IgxColumnComponent | IgxColumnGroupComponent) => {
5114-
return this.clearSortingAndFilteringRecursively(col);
5115-
});
5116-
} else {
5117-
this.gridAPI.clear_filter(column.field);
5118-
this.gridAPI.clear_sort(column.field);
5119-
}
5120-
}
5121-
51225107
/**
51235108
* @hidden
51245109
*/

0 commit comments

Comments
 (0)