Skip to content

Commit bc2f8dc

Browse files
author
mmart1n
committed
fix(*): apply requested changes
1 parent 84f0bbb commit bc2f8dc

File tree

5 files changed

+13
-33
lines changed

5 files changed

+13
-33
lines changed

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Component, HostBinding, Input } from '@angular/core';
22
import { IgxGridActionsBaseDirective } from './grid-actions-base.directive';
3-
import { showMessage } from '../../core/deprecateDecorators';
3+
import { showMessage } from '../../core/utils';
44
import { addRow, addChild } from '@igniteui/material-icons-extended';
55

66
@Component({

projects/igniteui-angular/src/lib/core/deprecateDecorators.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

projects/igniteui-angular/src/lib/core/utils.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,18 @@ import {
2525
swingOutLefttFwd, swingOutRightBck, swingOutRightFwd, swingOutTopBck, swingOutTopFwd
2626
} from '../animations/main';
2727
import { setImmediate } from './setImmediate';
28+
import { isDevMode } from '@angular/core';
29+
30+
/**
31+
* @hidden
32+
*/
33+
export const showMessage = (message: string, isMessageShown: boolean): boolean => {
34+
if (!isMessageShown && isDevMode()) {
35+
console.warn(message);
36+
}
37+
38+
return true;
39+
};
2840

2941
export const mkenum = <T extends { [index: string]: U }, U extends string>(x: T) => x;
3042

projects/igniteui-angular/src/lib/drop-down/drop-down-item.base.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import { IDropDownBase, IGX_DROPDOWN_BASE } from './drop-down.common';
22
import { Directive, Input, HostBinding, HostListener, ElementRef, Optional, Inject, DoCheck, Output, EventEmitter } from '@angular/core';
33
import { IgxSelectionAPIService } from '../core/selection';
4-
import { showMessage } from '../core/deprecateDecorators';
54
import { IgxDropDownGroupComponent } from './drop-down-group.component';
65

76
let NEXT_ID = 0;
8-
let warningShown = false;
97

108
/**
119
* An abstract class defining a drop-down item:
@@ -57,10 +55,6 @@ export class IgxDropDownItemBaseDirective implements DoCheck {
5755
@Input()
5856
public get index(): number {
5957
if (this._index === null) {
60-
warningShown = showMessage(
61-
'IgxDropDownItemBaseDirective: Automatic index is deprecated.' +
62-
'Bind in the template instead using `<igx-drop-down-item [index]="i"` instead.`',
63-
warningShown);
6458
return this.itemIndex;
6559
}
6660
return this._index;

projects/igniteui-angular/src/lib/grids/cell.component.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -705,20 +705,6 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
705705
});
706706
}
707707

708-
/**
709-
* @deprecated in version 8.2.0. Use 'selected' property instead
710-
*
711-
* Gets whether the cell is selected.
712-
*
713-
* ```typescript
714-
* let isCellSelected = thid.cell.isCellSelected();
715-
* ```
716-
* @memberof IgxGridCellComponent
717-
*/
718-
public isCellSelected() {
719-
return this.selectionService.selected(this.selectionNode);
720-
}
721-
722708
/**
723709
* @hidden
724710
* @internal

0 commit comments

Comments
 (0)