Merge branch '10.2.x' of https://github.com/IgniteUI/igniteui-angular into zkolev/code-coverage-gh-actions-102x

Author: zdrawku

projects/igniteui-angular/src/lib/data-operations/filtering-condition.ts

@@ -548,7 +548,7 @@ export class IgxStringFilteringOperand extends IgxFilteringOperand {
      * @memberof IgxStringFilteringOperand
      */
     public static applyIgnoreCase(a: string, ignoreCase: boolean): string {
-        a = a || '';
+        a = a ?? '';
         // bulletproof
         return ignoreCase ? ('' + a).toLowerCase() : a;
     }

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.spec.ts

@@ -17,6 +17,7 @@ import { IgxDateTimeEditorModule, IgxDateTimeEditorDirective } from '../directiv
 import { DateRangeType } from '../core/dates';
 import { IgxDateRangePickerComponent, IgxDateRangeEndComponent } from './public_api';
 import { IgxIconModule } from '../icon/public_api';
+import { AutoPositionStrategy } from '../services/public_api';
 
 // The number of milliseconds in one day
 const ONE_DAY = 1000 * 60 * 60 * 24;
@@ -30,6 +31,7 @@ const CSS_CLASS_CALENDAR_TOGGLE = '.igx-toggle';
 const CSS_CLASS_ICON = 'igx-icon';
 const CSS_CLASS_DONE_BUTTON = 'igx-button--flat';
 const CSS_CLASS_LABEL = 'igx-input-group__label';
+const CSS_CLASS_OVERLAY_CONTENT = 'igx-overlay__content';
 
 describe('IgxDateRangePicker', () => {
     describe('Unit tests: ', () => {
@@ -1120,6 +1122,23 @@ describe('IgxDateRangePicker', () => {
                 const result = fixture.componentInstance.formatter({ start: startDate, end: endDate });
                 expect(singleInputElement.nativeElement.value).toEqual(result);
             });
+
+            it('should invoke AutoPositionStrategy by default with proper arguments', fakeAsync(() => {
+                fixture = TestBed.createComponent(DateRangeDefaultComponent);
+                fixture.detectChanges();
+                spyOn<any>(AutoPositionStrategy.prototype, 'position');
+
+                dateRange = fixture.componentInstance.dateRange;
+                dateRange.open();
+                tick();
+                fixture.detectChanges();
+
+                const overlayContent = document.getElementsByClassName(CSS_CLASS_OVERLAY_CONTENT)[0] as HTMLElement;
+                expect(AutoPositionStrategy.prototype.position).toHaveBeenCalledTimes(1);
+                expect(AutoPositionStrategy.prototype.position)
+                    .toHaveBeenCalledWith(overlayContent, jasmine.anything(), document,
+                        jasmine.anything(), dateRange.element.nativeElement);
+            }));
         });
     });
 });
@@ -1136,7 +1155,7 @@ export class DateRangeTestComponent implements OnInit {
     public minValue: Date | String;
     public maxValue: Date | String;
 
-    @ViewChild(IgxDateRangePickerComponent, { read: IgxDateRangePickerComponent, static: true })
+    @ViewChild(IgxDateRangePickerComponent, { static: true })
     public dateRange: IgxDateRangePickerComponent;
 
     public ngOnInit(): void {

projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts

@@ -516,8 +516,8 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
      * @example
      * ```typescript
      * public selectFiveDayRange() {
-     *  const inFiveDays = new Date(new Date().setDate(today.getDate() + 5));
      *  const today = new Date();
+     *  const inFiveDays = new Date(new Date().setDate(today.getDate() + 5));
      *  this.dateRange.selectRange(today, inFiveDays);
      * }
      * ```
@@ -756,6 +756,9 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
     public handleSelection(selectionData: Date[]): void {
         this.value = this.extractRange(selectionData);
         this.rangeSelected.emit(this.value);
+        if (this.mode === InteractionMode.DropDown && selectionData?.length > 1) {
+            this.close();
+        }
     }
 
     protected onStatusChanged = () => {
@@ -955,7 +958,7 @@ export class IgxDateRangePickerComponent extends DisplayDensityBase
             closeAnimation: fadeOut
         };
         this._dropDownOverlaySettings.positionStrategy = new AutoPositionStrategy(this._positionSettings);
-        this.dropdownOverlaySettings.target = this.element.nativeElement;
+        this._dropDownOverlaySettings.target = this.element.nativeElement;
     }
 
     private configOverlaySettings(): void {

projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.spec.ts

@@ -12,6 +12,7 @@ describe('IgxRadioGroupDirective', () => {
         TestBed.configureTestingModule({
             declarations: [
                 RadioGroupComponent,
+                RadioGroupSimpleComponent,
                 RadioGroupWithModelComponent,
                 RadioGroupReactiveFormsComponent,
                 RadioGroupDeepProjectionComponent
@@ -193,8 +194,37 @@ describe('IgxRadioGroupDirective', () => {
         expect(radioGroup.value).toEqual(0);
         expect(radioGroup.radioButtons.first.checked).toEqual(true);
     }));
+
+    it('Updates checked radio button correctly', fakeAsync(() => {
+        const fixture = TestBed.createComponent(RadioGroupSimpleComponent);
+        fixture.detectChanges();
+        tick();
+
+        const radioGroup = fixture.componentInstance.radioGroup;
+        expect(radioGroup.radioButtons.first.checked).toEqual(true);
+        expect(radioGroup.radioButtons.last.checked).toEqual(false);
+
+        radioGroup.radioButtons.last.select();
+        fixture.detectChanges();
+        tick();
+
+        expect(radioGroup.radioButtons.first.checked).toEqual(false);
+        expect(radioGroup.radioButtons.last.checked).toEqual(true);
+    }));
 });
 
+@Component({
+    template: `
+    <igx-radio-group #radioGroup>
+        <igx-radio [checked]="true">Option 1</igx-radio>
+        <igx-radio>Option 2</igx-radio>
+    </igx-radio-group>
+`
+})
+class RadioGroupSimpleComponent {
+    @ViewChild('radioGroup', { read: IgxRadioGroupDirective, static: true }) public radioGroup: IgxRadioGroupDirective;
+}
+
 @Component({
     template: `<igx-radio-group #radioGroup name="radioGroup" value="Baz" required="true" labelPosition="before">
     <igx-radio *ngFor="let item of ['Foo', 'Bar', 'Baz']" value="{{item}}">

projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.ts

@@ -315,13 +315,11 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
      * @internal
      */
     private _selectedRadioButtonChanged(args: IChangeRadioEventArgs) {
-        if (this._selected !== args.radio) {
-            if (this._selected) {
-                this._selected.checked = false;
-            }
-            this._selected = args.radio;
-        }
+        this.radioButtons.forEach(button => {
+            button.checked = button.id === args.radio.id;
+        });
 
+        this._selected = args.radio;
         this._value = args.value;
 
         if (this._isInitialized) {

projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts

@@ -216,9 +216,9 @@ export class IgxFilteringService implements OnDestroy {
                 this.gridAPI.filter(field, value, expressionForColumn.condition, filteringIgnoreCase);
             }
         }
-
+        const eventArgs = this.grid.filteringExpressionsTree.find(field) as FilteringExpressionsTree;
         // Wait for the change detection to update filtered data through the pipes and then emit the event.
-        requestAnimationFrame(() => this.grid.onFilteringDone.emit(col.filteringExpressionsTree));
+        requestAnimationFrame(() => this.grid.onFilteringDone.emit(eventArgs));
     }
 
     /**

projects/igniteui-angular/src/lib/grids/grid/grid-filtering.spec.ts

@@ -649,6 +649,16 @@ describe('IgxGrid - Filtering actions #grid', () => {
         expect(grid.rowList.length).toEqual(1);
     }));
 
+    it('should exclude null and undefined values when filter by \'false\'', fakeAsync(() => {
+        expect(grid.rowList.length).toEqual(8);
+
+        grid.filter('Released', false, IgxStringFilteringOperand.instance().condition('equals'), true);
+        fix.detectChanges();
+        expect(grid.rowList.length).toEqual(2);
+        expect(grid.getCellByColumn(0, 'Released').value).toBe(false);
+        expect(grid.getCellByColumn(1, 'Released').value).toBe(false);
+    }));
+
     it('should correctly apply multiple filtering through API', fakeAsync(() => {
         const gridExpressionsTree = new FilteringExpressionsTree(FilteringLogic.And);
         gridExpressionsTree.filteringOperands = [
@@ -895,6 +905,17 @@ describe('IgxGrid - Filtering actions #grid', () => {
         expect(grid.rowList.length).toEqual(2);
     }));
 
+    it('Should always emit onFilteringDone with proper eventArgs, even when column does not exist', fakeAsync(() => {
+        spyOn(grid.onFilteringDone, 'emit');
+        grid.filteringLogic = FilteringLogic.Or;
+        grid.filter('Nonexisting', 'ignite', IgxStringFilteringOperand.instance().condition('contains'), true);
+        tick(100);
+        fix.detectChanges();
+        expect(grid.rowList.length).toEqual(0);
+        const args = grid.filteringExpressionsTree.find('Nonexisting') as FilteringExpressionsTree;
+        expect(grid.onFilteringDone.emit).toHaveBeenCalledWith(args);
+    }));
+
     it('Should emit onFilteringDone when filtering globally', fakeAsync(() => {
         spyOn(grid.onFilteringDone, 'emit');