Skip to content

Commit bf1f695

Browse files
MKirovaMKirova
authored andcommitted
chore(*): Remove empty containers.
1 parent 5792aaf commit bf1f695

File tree

4 files changed

+35
-33
lines changed

4 files changed

+35
-33
lines changed

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<div igxGridBody (keydown.control.c)="copyHandler($event)" (copy)="copyHandler($event)" class="igx-grid__tbody" role="rowgroup">
2222
<div *ngFor='let dim of rowDimensions' #rowDimensionContainer role="rowgroup" class='igx-grid__tbody-pivot-dimension'>
2323
<ng-template igxGridFor let-rowData [igxGridForOf]="dataView
24-
| pivotGridCellMerging:pivotConfiguration:pivotKeys:pipeTrigger"
24+
| pivotGridCellMerging:pivotConfiguration:dim:pivotKeys:pipeTrigger"
2525
let-rowIndex="index" [igxForScrollOrientation]="'vertical'" [igxForScrollContainer]='verticalScroll'
2626
[igxForContainerSize]='calcHeight'
2727
[igxForItemSize]="renderedRowHeight"

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.pipes.ts

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -110,44 +110,46 @@ export class IgxPivotCellMergingPipe implements PipeTransform {
110110
public transform(
111111
collection: any[],
112112
config: IPivotConfiguration,
113+
dim: IPivotDimension,
113114
pivotKeys: IPivotKeys,
114115
_pipeTrigger?: number
115116
): any[] {
116117
if (collection.length === 0 || config.rows.length === 0) return collection;
117118
const data = collection ? cloneArray(collection, true) : [];
119+
const res = [];
118120

119121
const enabledRows = config.rows.filter(x => x.enabled);
120-
let prev;
121-
for (let dim of enabledRows) {
122-
let groupData = [];
123-
let prevValue;
124-
let prevDim;
125-
let prevDimRoot;
126-
for (let rec of data) {
127-
const dimData = PivotUtil.getDimensionLevel(dim, rec, pivotKeys);
128-
const val = rec[dimData.dimension.memberName];
129-
const sameSiblingDim = prev ? rec[prev.memberName] : true;
130-
if (prevValue !== val && groupData.length > 0 && sameSiblingDim) {
131-
groupData.forEach((gr, ind) => {
132-
if (ind === 0) {
133-
gr[prevDim.dimension.memberName + pivotKeys.rowDimensionSeparator + 'first'] = true;
134-
gr[prevDimRoot.memberName + pivotKeys.rowDimensionSeparator + 'height'] = groupData.length * this.grid.renderedRowHeight;
135-
} else {
136-
gr[prevDimRoot.memberName + pivotKeys.rowDimensionSeparator + 'height'] = 1;
137-
}
138-
gr[prevDim.dimension.memberName + pivotKeys.rowDimensionSeparator + 'rowSpan'] = groupData.length;
139-
});
140-
groupData[groupData.length - 1][prevDim.dimension.memberName + pivotKeys.rowDimensionSeparator + 'last'] = true;
141-
groupData = [];
142-
}
143-
groupData.push(rec);
144-
prevValue = val;
145-
prevDim = dimData;
146-
prevDimRoot = dim;
122+
123+
const prevDims = enabledRows.filter((d, ind) => ind < enabledRows.indexOf(dim));
124+
let groupData = [];
125+
let prevValue;
126+
let prevDim;
127+
let prevDimRoot;
128+
let prevId;
129+
for (let rec of data) {
130+
const dimData = PivotUtil.getDimensionLevel(dim, rec, pivotKeys);
131+
const val = rec[dimData.dimension.memberName];
132+
const id = PivotUtil.getRecordKey(rec, dimData.dimension, prevDims, pivotKeys);
133+
if (prevValue !== val && groupData.length > 0 && prevId !== id) {
134+
const h = groupData.length > 1 ? groupData.length * this.grid.renderedRowHeight : undefined;
135+
groupData[0][prevDimRoot.memberName + pivotKeys.rowDimensionSeparator + 'height'] = h;
136+
groupData[0][prevDim.dimension.memberName + pivotKeys.rowDimensionSeparator + 'rowSpan'] = groupData.length;
137+
res.push(groupData[0]);
138+
groupData = [];
147139
}
148-
prev = dim;
140+
groupData.push(rec);
141+
prevValue = val;
142+
prevDim = dimData;
143+
prevDimRoot = dim;
144+
prevId = id;
145+
}
146+
if (groupData.length > 0) {
147+
const h = groupData.length > 1 ? groupData.length * this.grid.rowHeight + (groupData.length - 1) + 1 : undefined;
148+
groupData[0][prevDimRoot.memberName + pivotKeys.rowDimensionSeparator + 'height'] = h;
149+
groupData[0][prevDim.dimension.memberName + pivotKeys.rowDimensionSeparator + 'rowSpan'] = groupData.length;
150+
res.push(groupData[0]);
149151
}
150-
return data;
152+
return res;
151153
}
152154
}
153155

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-row-dimension-content.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<div role="rowgroup" class="igx-grid-thead__wrapper" [style.width.px]="width"
22
[class.igx-grid__tr--mrl]="hasMRL">
33
<div class="igx-grid__tr igx-grid__tr-header-row" role="row" [style.width.px]="width">
4-
<igx-pivot-row-dimension-header-group *ngIf='isFirst' [ngClass]="rowDimensionColumn.headerGroupClasses"
4+
<igx-pivot-row-dimension-header-group [ngClass]="rowDimensionColumn.headerGroupClasses"
55
[ngStyle]="rowDimensionColumn.headerGroupStyles |igxHeaderGroupStyle:rowDimensionColumn:grid.pipeTrigger" [column]="rowDimensionColumn"
66
[style.min-width]="rowDimensionColumn.calcWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:hasMRL"
77
[style.flex-basis]="rowDimensionColumn.calcWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:hasMRL"
88
[rowIndex]="rowIndex"
9-
[style.min-height.px]='headerHeight'>
9+
[style.min-height.px]='rowSpan > 1 ? headerHeight : undefined'>
1010
</igx-pivot-row-dimension-header-group>
1111
</div>
1212
</div>

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-row-dimension-content.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export class IgxPivotRowDimensionContentComponent extends IgxGridHeaderRowCompon
118118
}
119119

120120
get headerHeight() {
121-
return this.rowSpan * this.grid.rowHeight;
121+
return this.rowSpan * this.grid.rowHeight + (this.rowSpan - 1);
122122
}
123123

124124
get isFirst() {

0 commit comments

Comments
 (0)