fix(query-builder): on select all click return fields should be *

Author: teodosiah

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts

@@ -611,11 +611,7 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
         if (this._expressionTree) {
             this._expressionTree.entity = this._entityNewValue.name;
 
-            if (this.fields.length === this._selectedReturnFields.length) {
-                this._expressionTree.returnFields = ['*'];
-            } else {
-                this._expressionTree.returnFields =  this._selectedReturnFields;
-            }
+            this._expressionTree.returnFields = this.fields.length === this._selectedReturnFields.length ? ['*'] : this._selectedReturnFields;
 
             this._expressionTree.filteringOperands = [];
 
@@ -649,7 +645,7 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
             this._selectedReturnFields = value;
 
             if (this._expressionTree && !this.parentExpression) {
-                this._expressionTree.returnFields = value;
+                this._expressionTree.returnFields = value.length === this.fields.length ? ['*'] : value;
                 this.expressionTreeChange.emit(this._expressionTree);
             }
         }

projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts

@@ -444,7 +444,7 @@ describe('IgxQueryBuilder', () => {
       expect((dropdownItems[4] as HTMLElement).innerText).toBe('Released');
     }));
 
-    it('ReturnFields should be properly calculated.', fakeAsync(() => {
+    it('ReturnFields should be properly calculated on entity change.', fakeAsync(() => {
       queryBuilder.expressionTree = QueryBuilderFunctions.generateExpressionTree();
       queryBuilder.showEntityChangeDialog = false;
       fix.detectChanges();
@@ -470,6 +470,30 @@ describe('IgxQueryBuilder', () => {
       expect(exprTreeReturnFields).toBe(`["*"]`);
     }));
 
+    it('ReturnFields should be properly calculated on selectAll click.', fakeAsync(() => {
+      queryBuilder.expressionTree = QueryBuilderFunctions.generateExpressionTree();
+      queryBuilder.showEntityChangeDialog = false;
+      fix.detectChanges();
+      
+      // Click selectAll button in order to deselect all fields
+      QueryBuilderFunctions.selectFieldsInEditModeExpression(fix, [0]);
+      tick(100);
+      fix.detectChanges();
+       
+      // Verify the returnFields
+      let exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields);
+      expect(exprTreeReturnFields).toBe(`[]`);
+      
+      // Click selectAll button in order to select all fields
+      QueryBuilderFunctions.selectFieldsInEditModeExpression(fix, [0]);
+      tick(100);
+      fix.detectChanges();
+
+      // Verify the returnFields
+      exprTreeReturnFields = JSON.stringify(fix.componentInstance.queryBuilder.expressionTree.returnFields);
+      expect(exprTreeReturnFields).toBe(`["*"]`);
+    }));
+
     it('Column dropdown should contain proper fields based on the entity.', fakeAsync(() => {
       const queryBuilderElement: HTMLElement = fix.debugElement.queryAll(By.css(`.${QueryBuilderSelectors.QUERY_BUILDER_TREE}`))[0].nativeElement;