Merge branch 'master' into update-10

Author: kdinev

CHANGELOG.md

@@ -17,10 +17,18 @@ All notable changes for each version of this project will be documented in this
 ### New Features
 - `IgxGrid`
     - `showGroupArea` input is added, which can be used to enable/disable the group area row.
+    - The event arguments of `onCellEdit`, `onCellEditEnter` and `onCellEditCancel` events will contain a reference to the row data, as well as a reference to the column.
+    - The event arguments of `onRowEdit`, `onRowEditEnter` and `onRowEditCancel` events will contain a reference to the row data.
 
 - `IgxSelect` support for `igxHint` directive added.
     - Allows the user to add `igxHint` to be displayed bellow the input element.
 
+## 9.1.4
+
+### New Features
+- `IgxList`
+    - Added localization support.
+
 ## 9.1.1
 
 ### General
@@ -188,7 +196,6 @@ All notable changes for each version of this project will be documented in this
     - Added support for tabIndex attribute applied to the main chip element.
     - Added `tabIndex` input so it can support change detection as well.
 
-
 - `IgxHighlightDirective`
     - New `metadata` property was introduced, which allows adding additional, custom logic to the activation condition of a highlighted element.
 

projects/igniteui-angular/src/lib/core/i18n/list-resources.ts

@@ -0,0 +1,9 @@
+export interface IListResourceStrings {
+    igx_list_no_items?: string;
+    igx_list_loading?: string;
+}
+
+export const ListResourceStringsEN: IListResourceStrings = {
+    igx_list_no_items: 'There are no items in the list.',
+    igx_list_loading: 'Loading data from the server...'
+};

projects/igniteui-angular/src/lib/core/i18n/resources.ts

@@ -4,6 +4,7 @@ import { ITimePickerResourceStrings, TimePickerResourceStringsEN } from './time-
 import { PaginatorResourceStringsEN } from './paginator-resources';
 import { cloneValue } from '../utils';
 import { ICarouselResourceStrings, CarouselResourceStringsEN } from './carousel-resources';
+import { ListResourceStringsEN } from './list-resources';
 
 export interface IResourceStrings extends IGridResourceStrings, ITimePickerResourceStrings, ICarouselResourceStrings  {}
 
@@ -16,6 +17,7 @@ export const CurrentResourceStrings = {
     TimePickerResStrings: cloneValue(TimePickerResourceStringsEN),
     DateRangePickerResStrings: cloneValue(DateRangePickerResourceStringsEN),
     CarouselResStrings: cloneValue(CarouselResourceStringsEN),
+    ListResStrings: cloneValue(ListResourceStringsEN),
 };
 
 function updateResourceStrings(currentStrings: IResourceStrings, newStrings: IResourceStrings ) {

projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss

@@ -889,7 +889,6 @@
         display: block;
         border: none;
         height: rem(32px, map-get($base-scale-size, 'comfortable'));
-        line-height: 0 !important; /* resets typography styles */
         width: 100%;
         min-width: 0;
         overflow: visible;
@@ -900,13 +899,18 @@
         border-top: rem(3px) solid transparent;
         padding-bottom: rem(3px);
 
+        &:not([type='date']) {
+            line-height: 0 !important; /* resets typography styles */
+        }
+
         &::-webkit-input-placeholder {
             line-height: normal;
         }
 
         &::placeholder {
             color: --var($theme, 'placeholder-color');
             opacity: 1;
+            line-height: normal; /* Fix placeholder position in Safari */
         }
     }
 

projects/igniteui-angular/src/lib/directives/focus/focus.directive.ts

@@ -63,7 +63,7 @@ export class IgxFocusDirective {
      */
     trigger() {
         if (this.focusState) {
-            requestAnimationFrame(() => this.nativeElement.focus());
+            requestAnimationFrame(() => this.nativeElement.focus({ preventScroll: true}));
         }
     }
 }

projects/igniteui-angular/src/lib/grids/api.service.ts

@@ -144,6 +144,7 @@ export class GridBaseAPIService <T extends IgxGridBaseDirective & GridType> {
 
         const args = cell.createEditEventArgs();
 
+        // TODO: emit onCellEdit after value is updated - issue #7304
         this.grid.onCellEdit.emit(args);
         if (args.cancel) {
             return args;
@@ -231,6 +232,7 @@ export class GridBaseAPIService <T extends IgxGridBaseDirective & GridType> {
             return args;
         }
 
+        // TODO: emit onRowEdit after value is updated - issue #7304
         grid.onRowEdit.emit(args);
 
         if (args.cancel) {

projects/igniteui-angular/src/lib/grids/common/events.ts

@@ -7,6 +7,7 @@ import { IgxGridCellComponent } from '../cell.component';
 import { IgxColumnComponent } from '../columns/column.component';
 import { IgxGridBaseDirective } from '../grid-base.directive';
 import { IgxRowDirective } from '../row.directive';
+import { ColumnType } from './column.interface';
 export { GridSelectionRange } from '../selection/selection.service';
 
 export interface IGridClipboardEvent {
@@ -26,9 +27,12 @@ export interface IGridEditEventArgs extends CancelableEventArgs, IBaseEventArgs
         columnID: any,
         rowIndex: number
     };
+    rowData: any;
     oldValue: any;
     newValue?: any;
     event?: Event;
+    column?: ColumnType;
+    owner?: IgxGridBaseDirective & GridType;
 }
 
 export interface IPinColumnEventArgs extends IBaseEventArgs {

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -4034,7 +4034,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
                     rowIndex: index
                 };
 
-                const cell = new IgxCell(id, index, col, rowData[col.field], rowData[col.field], rowData);
+                const cell = new IgxCell(id, index, col, rowData[col.field], rowData[col.field], rowData, this);
                 const args = this.gridAPI.update_cell(cell, value);
 
                 if (this.crudService.cell && this.crudService.sameCell(cell)) {
@@ -4069,7 +4069,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
             if (editableCell && editableCell.id.rowID === rowSelector) {
                 this.gridAPI.escape_editMode();
             }
-            const row = new IgxRow(rowSelector, -1, this.gridAPI.getRowData(rowSelector));
+            const row = new IgxRow(rowSelector, -1, this.gridAPI.getRowData(rowSelector), this);
             this.gridAPI.update_row(row, value);
 
             // TODO: fix for #5934 and probably break for #5763

projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts

@@ -557,12 +557,21 @@ describe('IgxGrid - Cell Editing #grid', () => {
         it(`Should properly emit 'onCellEditEnter' event`, () => {
             spyOn(grid.onCellEditEnter, 'emit').and.callThrough();
             let cell = grid.getCellByColumn(0, 'fullName');
+            let initialRowData = {...cell.rowData};
             expect(cell.editMode).toBeFalsy();
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
 
-            let cellArgs: IGridEditEventArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 'John Brown', cancel: false };
+            let cellArgs: IGridEditEventArgs = {
+                rowID: cell.row.rowID,
+                cellID: cell.cellID,
+                rowData: initialRowData,
+                oldValue: 'John Brown',
+                cancel: false,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledWith(cellArgs);
             expect(cell.editMode).toBeTruthy();
@@ -573,7 +582,16 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             expect(cell.editMode).toBeFalsy();
             cell = grid.getCellByColumn(0, 'age');
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 20, cancel: false };
+            initialRowData = {...cell.rowData};
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 20,
+                cancel: false,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledTimes(2);
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledWith(cellArgs);
             expect(cell.editMode).toBeTruthy();
@@ -585,25 +603,43 @@ describe('IgxGrid - Cell Editing #grid', () => {
                 e.cancel = true;
             });
             let cell = grid.getCellByColumn(0, 'fullName');
+            let initialRowData = {...cell.rowData};
             expect(cell.editMode).toBeFalsy();
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
 
-            let cellArgs: IGridEditEventArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 'John Brown', cancel: true };
+            let cellArgs: IGridEditEventArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 'John Brown',
+                cancel: true,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledWith(cellArgs);
             expect(cell.editMode).toBeFalsy();
 
             // press enter on a cell
             cell = grid.getCellByColumn(0, 'age');
+            initialRowData = {...cell.rowData};
             UIInteractions.simulateClickAndSelectEvent(cell);
             fixture.detectChanges();
 
             UIInteractions.triggerEventHandlerKeyDown('enter', gridContent);
             fixture.detectChanges();
 
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 20, cancel: true };
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 20,
+                cancel: true,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledTimes(2);
             expect(grid.onCellEditEnter.emit).toHaveBeenCalledWith(cellArgs);
             expect(cell.editMode).toBeFalsy();
@@ -626,7 +662,17 @@ describe('IgxGrid - Cell Editing #grid', () => {
             UIInteractions.triggerEventHandlerKeyDown('tab', gridContent);
             fixture.detectChanges();
 
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 'John Brown', newValue: 'New Name', cancel: false };
+            // TODO: onCellEdit should emit updated rowData - issue #7304
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: cell.rowData,
+                oldValue: 'John Brown',
+                newValue: 'New Name',
+                cancel: false,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEdit.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
@@ -640,7 +686,17 @@ describe('IgxGrid - Cell Editing #grid', () => {
             UIInteractions.triggerEventHandlerKeyDown('enter', gridContent);
             fixture.detectChanges();
 
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 20, newValue: 1, cancel: false };
+            // TODO: onCellEdit should emit updated rowData - issue #7304
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: cell.rowData,
+                oldValue: 20,
+                newValue: 1,
+                cancel: false,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEdit.emit).toHaveBeenCalledTimes(2);
             expect(grid.onCellEdit.emit).toHaveBeenCalledWith(cellArgs);
         });
@@ -652,6 +708,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
             });
             let cellArgs: IGridEditEventArgs;
             let cell = grid.getCellByColumn(0, 'fullName');
+            let initialRowData = {...cell.rowData};
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
@@ -665,14 +722,25 @@ describe('IgxGrid - Cell Editing #grid', () => {
             UIInteractions.triggerEventHandlerKeyDown('tab', gridContent);
             fixture.detectChanges();
 
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 'John Brown', newValue: 'New Name', cancel: true };
+            // TODO: onCellEdit should emit updated rowData - issue #7304
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 'John Brown',
+                newValue: 'New Name',
+                cancel: true,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEdit.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
             expect(cell.editMode).toBe(false);
             expect(cell.value).toBe('John Brown');
 
             cell = grid.getCellByColumn(0, 'age');
+            initialRowData = {...cell.rowData};
             expect(cell.editMode).toBe(true);
             editTemplate = fixture.debugElement.query(By.css('input'));
             UIInteractions.clickAndSendInputElementValue(editTemplate, 1);
@@ -682,7 +750,17 @@ describe('IgxGrid - Cell Editing #grid', () => {
             UIInteractions.triggerEventHandlerKeyDown('enter', gridContent);
             fixture.detectChanges();
 
-            cellArgs = { cellID: cell.cellID, rowID: cell.row.rowID, oldValue: 20, newValue: '1', cancel: true };
+            // TODO: onCellEdit should emit updated rowData - issue #7304
+            cellArgs = {
+                cellID: cell.cellID,
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 20,
+                newValue: '1',
+                cancel: true,
+                column: cell.column,
+                owner: grid
+            };
             expect(grid.onCellEdit.emit).toHaveBeenCalledTimes(2);
             expect(grid.onCellEdit.emit).toHaveBeenCalledWith(cellArgs);
 
@@ -767,6 +845,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
         it(`Should properly emit 'onCellEditCancel' event`, () => {
             spyOn(grid.onCellEditCancel, 'emit').and.callThrough();
             const cell = grid.getCellByColumn(0, 'fullName');
+            const initialRowData = {...cell.rowData};
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
@@ -782,7 +861,13 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             const cellArgs: IGridEditEventArgs = {
                 cellID: cell.cellID,
-                rowID: cell.row.rowID, oldValue: 'John Brown', newValue: 'New Name', cancel: false
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 'John Brown',
+                newValue: 'New Name',
+                cancel: false,
+                column: cell.column,
+                owner: grid
             };
             expect(grid.onCellEditCancel.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEditCancel.emit).toHaveBeenCalledWith(cellArgs);
@@ -796,6 +881,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
                 e.cancel = true;
             });
             const cell = grid.getCellByColumn(0, 'fullName');
+            const initialRowData = {...cell.rowData};
 
             UIInteractions.simulateDoubleClickAndSelectEvent(cell);
             fixture.detectChanges();
@@ -805,13 +891,19 @@ describe('IgxGrid - Cell Editing #grid', () => {
             UIInteractions.clickAndSendInputElementValue(editTemplate, 'New Name');
             fixture.detectChanges();
 
-           // press escape on edited cell
-           UIInteractions.triggerEventHandlerKeyDown('escape', gridContent);
-           fixture.detectChanges();
+            // press escape on edited cell
+            UIInteractions.triggerEventHandlerKeyDown('escape', gridContent);
+            fixture.detectChanges();
 
             const cellArgs: IGridEditEventArgs = {
                 cellID: cell.cellID,
-                rowID: cell.row.rowID, oldValue: 'John Brown', newValue: 'New Name', cancel: true
+                rowID: cell.row.rowID,
+                rowData: initialRowData,
+                oldValue: 'John Brown',
+                newValue: 'New Name',
+                cancel: true,
+                column: cell.column,
+                owner: grid
             };
             expect(grid.onCellEditCancel.emit).toHaveBeenCalledTimes(1);
             expect(grid.onCellEditCancel.emit).toHaveBeenCalledWith(cellArgs);