Skip to content

Commit c386bdf

Browse files
committed
fix(position-strategies): check for defined offset
1 parent 47cc6f7 commit c386bdf

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

projects/igniteui-angular/src/lib/services/overlay/position/connected-positioning-strategy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ export class ConnectedPositioningStrategy implements IPositionStrategy {
2727
verticalStartPoint: VerticalAlignment.Bottom,
2828
openAnimation: scaleInVerTop,
2929
closeAnimation: scaleOutVerTop,
30-
minSize: { width: 0, height: 0 },
31-
offset: 0
30+
minSize: { width: 0, height: 0 }
3231
};
3332

3433
constructor(settings?: PositionSettings) {

projects/igniteui-angular/src/lib/services/overlay/utilities.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,10 @@ export class Util {
349349
return connectedFit.horizontalOffset;
350350
}
351351

352+
if (settings.offset == null) {
353+
return 0;
354+
}
355+
352356
if (
353357
settings.horizontalDirection === HorizontalAlignment.Left &&
354358
settings.horizontalStartPoint === HorizontalAlignment.Left
@@ -373,6 +377,10 @@ export class Util {
373377
return connectedFit.verticalOffset;
374378
}
375379

380+
if (settings.offset == null) {
381+
return 0;
382+
}
383+
376384
if (
377385
settings.verticalDirection === VerticalAlignment.Top &&
378386
settings.verticalStartPoint === VerticalAlignment.Top

0 commit comments

Comments
 (0)