chore(*): some refactoring

Author: kdinev

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

@@ -1128,10 +1128,10 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
     }
 
 
-    private hg_verticalScrollHandler(event) {
+    private hg_verticalScrollHandler() {
         this.scrollTop = this.verticalScrollContainer.scrollPosition;
     }
-    private hg_horizontalScrollHandler(event) {
+    private hg_horizontalScrollHandler() {
         this.scrollLeft = this.headerContainer.scrollPosition;
     }
 }

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.spec.ts

@@ -15,7 +15,7 @@ import { GridSelectionMode } from '../common/enums';
 import { GridFunctions } from '../../test-utils/grid-functions.spec';
 import { IgxGridCellComponent } from '../cell.component';
 
-describe('Basic IgxHierarchicalGrid', () => {
+describe('Basic IgxHierarchicalGrid #hGrid', () => {
     configureTestSuite();
 
     beforeAll(waitForAsync(() => {
@@ -1583,7 +1583,7 @@ describe('Basic IgxHierarchicalGrid', () => {
     describe('Columns and row islands runtime change', () => {
         let fixture: ComponentFixture<IgxHierarchicalGridToggleRIAndColsComponent>;
         let hierarchicalGrid: IgxHierarchicalGridComponent;
-        
+
         it('should allow changing columns runtime in root grid when there are no row islands.', fakeAsync(() => {
             fixture = TestBed.createComponent(IgxHierarchicalGridToggleRIAndColsComponent);
             fixture.detectChanges();
@@ -1593,7 +1593,7 @@ describe('Basic IgxHierarchicalGrid', () => {
             fixture.componentInstance.toggleColumns = true;
             fixture.detectChanges();
             tick();
-    
+
             expect(hierarchicalGrid.columns.length).toBe(2);
 
             fixture.componentInstance.toggleRI = true;
@@ -1680,7 +1680,7 @@ describe('Basic IgxHierarchicalGrid', () => {
             expect(gridCellValues.length).toBe(1);
         }));
     });
-    
+
 });
 
 @Component({

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.spec.ts

@@ -39,7 +39,7 @@ describe('IgxPivotGrid #pivotGrid', () => {
     }));
 
     describe('Basic IgxPivotGrid #pivotGrid', () => {
-        let fixture;
+        let fixture: ComponentFixture<IgxPivotGridTestBaseComponent>;
 
         beforeEach(waitForAsync(() => {
             fixture = TestBed.createComponent(IgxPivotGridTestBaseComponent);
@@ -214,7 +214,7 @@ describe('IgxPivotGrid #pivotGrid', () => {
             fixture.detectChanges();
             expect(pivotGrid.pivotConfiguration.values[1].enabled).toBeFalse();
             expect(pivotGrid.values.length).toBe(0);
-            expect(pivotGrid.columns.length).toBe(3)
+            expect(pivotGrid.columns.length).toBe(3);
         });
 
         it('should remove filter dimension from chip', () => {
@@ -271,7 +271,8 @@ describe('IgxPivotGrid #pivotGrid', () => {
                         memberName: 'Country',
                         enabled: true
                     }
-                ]
+                ],
+                values: null
             };
             pivotGrid.pipeTrigger++;
             pivotGrid.setupColumns();
@@ -1127,7 +1128,7 @@ describe('IgxPivotGrid #pivotGrid', () => {
                 expected = ['Uruguay', 'USA', 'Bulgaria'];
                 expect(colHeaders).toEqual(expected);
                 const expectedExpressions: ISortingExpression[] = [
-                    { dir: SortingDirection.None, fieldName: 'All', strategy: DefaultPivotSortingStrategy.instance()}, 
+                    { dir: SortingDirection.None, fieldName: 'All', strategy: DefaultPivotSortingStrategy.instance()},
                     { dir: SortingDirection.None, fieldName: 'ProductCategory', strategy: DefaultPivotSortingStrategy.instance()},
                     { dir: SortingDirection.Desc, fieldName: 'Country', strategy: DefaultPivotSortingStrategy.instance() }
                 ];
@@ -1140,7 +1141,6 @@ describe('IgxPivotGrid #pivotGrid', () => {
                 pivotGrid.pivotConfiguration.columns = [{
                     memberName: 'Country',
                     memberFunction: (data) => {
-                        const len = data['Country'].length;
                         return data['Country'];
                     },
                     enabled: true
@@ -1167,7 +1167,7 @@ describe('IgxPivotGrid #pivotGrid', () => {
                 expected = ['Uruguay', 'USA', 'Bulgaria'];
                 expect(colHeaders).toEqual(expected);
                 const expectedExpressions: ISortingExpression[] = [
-                    { dir: SortingDirection.None, fieldName: 'All', strategy: DefaultPivotSortingStrategy.instance()}, 
+                    { dir: SortingDirection.None, fieldName: 'All', strategy: DefaultPivotSortingStrategy.instance()},
                     { dir: SortingDirection.None, fieldName: 'ProductCategory', strategy: DefaultPivotSortingStrategy.instance()},
                     { dir: SortingDirection.Desc, fieldName: 'Country', strategy: DefaultPivotSortingStrategy.instance() }
                 ];
@@ -1830,7 +1830,7 @@ describe('IgxPivotGrid #pivotGrid', () => {
     });
 
     describe('IgxPivotGrid complex hierarchy #pivotGrid', () => {
-        let fixture;
+        let fixture: ComponentFixture<IgxPivotGridTestComplexHierarchyComponent>;
 
         beforeEach(waitForAsync(() => {
             fixture = TestBed.createComponent(IgxPivotGridTestComplexHierarchyComponent);

projects/igniteui-angular/src/lib/test-utils/grid-functions.spec.ts

@@ -23,6 +23,7 @@ import { IgxRowDirective } from '../grids/row.directive';
 import { CellType, GridType, RowType } from '../grids/common/grid.interface';
 import { IgxTreeNodeComponent } from '../tree/tree-node/tree-node.component';
 import { IgxColumnComponent } from '../grids/columns/column.component';
+import { IgxPivotGridComponent } from '../grids/pivot-grid/pivot-grid.component';
 
 
 const SUMMARY_LABEL_CLASS = '.igx-grid-summary__label';
@@ -149,7 +150,7 @@ export class GridFunctions {
         return row.query(By.css(DISPLAY_CONTAINER));
     }
 
-    public static getColGroup(grid: IgxGridComponent, headerName: string): IgxColumnGroupComponent {
+    public static getColGroup(grid: IgxGridComponent | IgxPivotGridComponent, headerName: string): IgxColumnGroupComponent {
         const colGroups = grid.columns.filter(c => c.columnGroup && c.header === headerName);
         if (colGroups.length === 0) {
             return null;
@@ -2030,7 +2031,7 @@ export class GridFunctions {
             const groupBlock = mrlBlocks[index] as any;
             const cellsFromBlock = firstRowCells.filter((cell) => cell.nativeElement.parentNode === groupBlock);
             expect(groupBlock).not.toBeNull();
-            groupSetting.columns.forEach((col, colIndex) => {
+            groupSetting.columns.forEach((col) => {
                 const cell = cellsFromBlock.find(x => x.column.field == col.field) as any;
                 const cellElem = cell.nativeElement;
                 // check correct attributes are applied